From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: geert@linux-m68k.org, tglx@kernel.org, miodrag.dinic@mips.com
Cc: radu@rendec.net, zewenchen@google.com, jamiechen@google.com,
edwardwchen@google.com, marscheng@google.com,
eleanor15x@gmail.com, jserv@ccns.ncku.edu.tw,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH 5/6] m68k/irq: Add empty irq_eoi callback to auto/user IRQ chips
Date: Tue, 8 Sep 2026 09:40:15 +0000 [thread overview]
Message-ID: <20260908094016.1997918-6-visitorckw@gmail.com> (raw)
In-Reply-To: <20260908094016.1997918-1-visitorckw@gmail.com>
When an irq_chip lacks an irq_eoi callback, chained_irq_enter() falls
back to invoking chip->irq_mask(). On auto_irq_chip and user_irq_chip,
this leads to a NULL pointer dereference because autovector interrupts
are masked via the CPU SR rather than dedicated mask registers.
Add a no-op m68k_irq_eoi() callback to auto_irq_chip and user_irq_chip
so chained interrupt handlers can safely attach to these chips.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
arch/m68k/kernel/ints.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/m68k/kernel/ints.c b/arch/m68k/kernel/ints.c
index cf2b13488476..731d04ac95bd 100644
--- a/arch/m68k/kernel/ints.c
+++ b/arch/m68k/kernel/ints.c
@@ -33,16 +33,22 @@ extern u16 user_irqvec_fixup[];
static int m68k_first_user_vec;
+static void m68k_irq_eoi(struct irq_data *data)
+{
+}
+
static struct irq_chip auto_irq_chip = {
.name = "auto",
.irq_startup = m68k_irq_startup,
.irq_shutdown = m68k_irq_shutdown,
+ .irq_eoi = m68k_irq_eoi,
};
static struct irq_chip user_irq_chip = {
.name = "user",
.irq_startup = m68k_irq_startup,
.irq_shutdown = m68k_irq_shutdown,
+ .irq_eoi = m68k_irq_eoi,
};
/*
--
2.55.0.979.g7e5102b832-goog
next prev parent reply other threads:[~2026-09-08 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 9:40 [PATCH 0/6] m68k: virt: Switch to generic goldfish PIC driver Kuan-Wei Chiu
2026-09-08 9:40 ` [PATCH 1/6] irqchip/goldfish-pic: Use gf_ioread32/gf_iowrite32 for MMIO access Kuan-Wei Chiu
2026-09-08 9:40 ` [PATCH 2/6] irqchip/goldfish-pic: Use for_each_set_bit() to iterate pending IRQ Kuan-Wei Chiu
2026-09-08 9:40 ` [PATCH 3/6] irqchip/goldfish-pic: Allow selecting CONFIG_GOLDFISH_PIC on other architectures Kuan-Wei Chiu
2026-09-08 9:40 ` [PATCH 4/6] irqchip/goldfish-pic: Add goldfish_pic_init() for non DT platforms Kuan-Wei Chiu
2026-09-08 9:40 ` Kuan-Wei Chiu [this message]
2026-09-08 9:40 ` [PATCH 6/6] m68k: virt: Switch to generic goldfish-pic driver Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908094016.1997918-6-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=edwardwchen@google.com \
--cc=eleanor15x@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jamiechen@google.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=marscheng@google.com \
--cc=miodrag.dinic@mips.com \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=zewenchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.