Re: [PATCH v3 4/4] ARM: dts: mediatek: Add basic support for Amazon ford board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree Compiler (DTC) warnings due to using a unit address without a 'reg' property in the simple-framebuffer node.
--

commit 03486b0d7f26e5bd328d2d2b8f2a803bdf72c6b4
Author: Zakariya Hadrami <zkh@mailbox.org>

ARM: dts: mediatek: Add basic support for Amazon ford board

This tablet uses a MediaTek MT8127 system-on-chip with 1GB of RAM.
It can currently boot into initramfs with a working UART and
Simple Framebuffer using already initialized panel by the bootloader.

> diff --git a/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts
> new file mode 100644
> index 0000000000000..21bdab0e43f88
> --- /dev/null
> +++ b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts

[ ... ]

> +	chosen {
> +		stdout-path = "serial0:921600n8";
> +
> +		framebuffer0: framebuffer@b7a00000 {

[Severity: Low]
Will this node name cause Device Tree Compiler warnings during make dtbs?

Since the node is named with a unit address (@b7a00000) but only uses a
memory-region property without a corresponding reg property, it seems this
would trigger a unit_address_vs_reg warning.

Additionally, it might trigger an avoid_default_addr_size warning because
its parent (chosen) lacks #address-cells and #size-cells.

Would it be better to omit the unit address here?

> +			compatible = "simple-framebuffer";
> +			memory-region = <&framebuffer_reserved>;
> +			width = <1024>;
> +			height = <600>;
> +			stride = <(1024 * 2)>;
> +			format = "r5g6b5";
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-mt8127-amazon-ford-basic-v3-0-fc46bf1b6cb2@mailbox.org?part=4