Re: [PATCH v3 4/4] ARM: dts: mediatek: Add basic support for Amazon ford board

[Zakariya Hadrami <zkh@mailbox.org>]

On Tue, Sep 08, 2026 at 10:07:30PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Device Tree Compiler (DTC) warnings due to using a unit address without a 'reg' property in the simple-framebuffer node.
> --
> 
> commit 03486b0d7f26e5bd328d2d2b8f2a803bdf72c6b4
> Author: Zakariya Hadrami <zkh@mailbox.org>
> 
> ARM: dts: mediatek: Add basic support for Amazon ford board
> 
> This tablet uses a MediaTek MT8127 system-on-chip with 1GB of RAM.
> It can currently boot into initramfs with a working UART and
> Simple Framebuffer using already initialized panel by the bootloader.
> 
> > diff --git a/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts
> > new file mode 100644
> > index 0000000000000..21bdab0e43f88
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts
> 
> [ ... ]
> 
> > +	chosen {
> > +		stdout-path = "serial0:921600n8";
> > +
> > +		framebuffer0: framebuffer@b7a00000 {
> 
> [Severity: Low]
> Will this node name cause Device Tree Compiler warnings during make dtbs?
> 
> Since the node is named with a unit address (@b7a00000) but only uses a
> memory-region property without a corresponding reg property, it seems this
> would trigger a unit_address_vs_reg warning.
> 
> Additionally, it might trigger an avoid_default_addr_size warning because
> its parent (chosen) lacks #address-cells and #size-cells.
> 
> Would it be better to omit the unit address here?
> 

unit_address_vs_reg warning is in fact reported by dtc and DTSpec
explicitly says to use unique node-name without unit-address where no
reg specified. Meanwhile,
Documentation/devicetree/bindings/display/simple-framebuffer.yaml
requires nodes to be named framebuffer@<address>. So I'm a bit confused
and therefore I will keep this unchanged until further reviews on v4.

Missing #address-cells and #size-cells were added in v4.

Thank you!

Link to v4: https://patch.msgid.link/20260909-mt8127-amazon-ford-basic-v4-0-e9af5c420ab1@mailbox.org

> > +			compatible = "simple-framebuffer";
> > +			memory-region = <&framebuffer_reserved>;