All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Richard Cheng <icheng@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
	Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	Linus Walleij <linusw@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Len Brown <lenb@kernel.org>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jic23@kernel.org>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dan Williams <djbw@kernel.org>, Ira Weiny <iweiny@kernel.org>,
	Li Ming <ming.li@zohomail.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Lizhi Hou <lizhi.hou@amd.com>
Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, linux-gpio@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org,
	Allan Nielsen <allan.nielsen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Daniel Machon <daniel.machon@microchip.com>,
	Steen Hegelund <steen.hegelund@microchip.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH v11 02/10] drivers: core: Use fw_devlink_set_device()
Date: Wed,  9 Sep 2026 10:01:01 +0200	[thread overview]
Message-ID: <20260909080114.591938-3-herve.codina@bootlin.com> (raw)
In-Reply-To: <20260909080114.591938-1-herve.codina@bootlin.com>

The code set directly fwnode->dev field.

Use the dedicated fw_devlink_set_device() helper to perform this
operation.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Richard Cheng <icheng@nvidia.com>
---
 drivers/base/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 4c0c373998a1..3268e9350c86 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -3754,7 +3754,7 @@ int device_add(struct device *dev)
 	 * device and the driver sync_state callback is called for this device.
 	 */
 	if (dev->fwnode && !dev->fwnode->dev) {
-		dev->fwnode->dev = dev;
+		fw_devlink_set_device(dev->fwnode, dev);
 		fw_devlink_link_device(dev);
 	}
 
@@ -3929,7 +3929,7 @@ void device_del(struct device *dev)
 	device_unlock(dev);
 
 	if (dev->fwnode && dev->fwnode->dev == dev)
-		dev->fwnode->dev = NULL;
+		fw_devlink_set_device(dev->fwnode, NULL);
 
 	/* Notify clients of device removal.  This call must come
 	 * before dpm_sysfs_remove().
-- 
2.55.0


  parent reply	other threads:[~2026-09-09  8:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  8:00 [PATCH v11 00/10] lan966x pci device: Add support for SFPs, PCI part Herve Codina
2026-09-09  8:01 ` [PATCH v11 01/10] driver core: fw_devlink: Introduce fw_devlink_set_device() Herve Codina
2026-09-09  8:05   ` sashiko-bot
2026-09-09 11:31   ` Bartosz Golaszewski
2026-09-09  8:01 ` Herve Codina [this message]
2026-09-09  8:11   ` [PATCH v11 02/10] drivers: core: Use fw_devlink_set_device() sashiko-bot
2026-09-09  9:05   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 03/10] pinctrl: cs42l43: " Herve Codina
2026-09-09  8:05   ` sashiko-bot
2026-09-09  9:06   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 04/10] cxl/test: Use device_set_node() Herve Codina
2026-09-09  8:04   ` sashiko-bot
2026-09-09  9:06   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 05/10] cxl/test: Use fw_devlink_set_device() Herve Codina
2026-09-09  8:04   ` sashiko-bot
2026-09-09  9:06   ` Bartosz Golaszewski
2026-09-09  9:23   ` Bartosz Golaszewski
2026-09-09 11:27   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 06/10] PCI: of: " Herve Codina
2026-09-09  8:13   ` sashiko-bot
2026-09-09 11:27   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 07/10] PCI: of: Clear fwnode->dev during root bridge node removal and error path Herve Codina
2026-09-09  8:12   ` sashiko-bot
2026-09-09 11:31   ` Bartosz Golaszewski
2026-09-09  8:01 ` [PATCH v11 08/10] PCI: of: Set fwnode device of newly created PCI device nodes Herve Codina
2026-09-09  8:14   ` sashiko-bot
2026-09-09  8:01 ` [PATCH v11 09/10] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node Herve Codina
2026-09-09  8:15   ` sashiko-bot
2026-09-09  8:01 ` [PATCH v11 10/10] PCI: of: Avoid np->data usage for the node changeset Herve Codina
2026-09-09  8:17   ` sashiko-bot
2026-09-09  9:06     ` Herve Codina
2026-09-09  9:12   ` Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909080114.591938-3-herve.codina@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=alison.schofield@intel.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=brgl@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=dakr@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david.rhodes@cirrus.com \
    --cc=djbw@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=ming.li@zohomail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rafael@kernel.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=saravanak@kernel.org \
    --cc=steen.hegelund@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.