From: sashiko-bot@kernel.org
To: "Herve Codina" <herve.codina@bootlin.com>
Cc: linux-pci@vger.kernel.org, linux-cxl@vger.kernel.org
Subject: Re: [PATCH v11 08/10] PCI: of: Set fwnode device of newly created PCI device nodes
Date: Wed, 09 Sep 2026 08:14:48 +0000 [thread overview]
Message-ID: <20260909081448.B57FA1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909080114.591938-9-herve.codina@bootlin.com>
> Device-tree node can be created when CONFIG_PCI_DYNAMIC_OF_NODES. Those
> nodes are created and filled based on PCI core information but the
> fwnode device field is not set.
>
> When later an overlay is applied, this confuses fw_devlink. Indeed,
> without any device attached to the node, fw_devlink considers that this
> node will never become a device. When this node is pointed as a
> supplier, devlink looks at its ancestors in order to find a node with a
> device that could be used as the supplier.
>
> In the PCI use case, this leads to links that wrongly use the PCI root
> bridge device as the supplier instead of the expected PCI device.
>
> Setting the fwnode device to the device of the PCI device allows devlink
> to use this device as a supplier and so, correct links are created.
>
> Fixes: 407d1a51921e ("PCI: Create device tree node for bridge")
> Cc: stable@vger.kernel.org
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909080114.591938-1-herve.codina@bootlin.com?part=8
next prev parent reply other threads:[~2026-09-09 8:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:00 [PATCH v11 00/10] lan966x pci device: Add support for SFPs, PCI part Herve Codina
2026-09-09 8:01 ` [PATCH v11 01/10] driver core: fw_devlink: Introduce fw_devlink_set_device() Herve Codina
2026-09-09 8:05 ` sashiko-bot
2026-09-09 11:31 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 02/10] drivers: core: Use fw_devlink_set_device() Herve Codina
2026-09-09 8:11 ` sashiko-bot
2026-09-09 9:05 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 03/10] pinctrl: cs42l43: " Herve Codina
2026-09-09 8:05 ` sashiko-bot
2026-09-09 9:06 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 04/10] cxl/test: Use device_set_node() Herve Codina
2026-09-09 8:04 ` sashiko-bot
2026-09-09 9:06 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 05/10] cxl/test: Use fw_devlink_set_device() Herve Codina
2026-09-09 8:04 ` sashiko-bot
2026-09-09 9:06 ` Bartosz Golaszewski
2026-09-09 9:23 ` Bartosz Golaszewski
2026-09-09 11:27 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 06/10] PCI: of: " Herve Codina
2026-09-09 8:13 ` sashiko-bot
2026-09-09 11:27 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 07/10] PCI: of: Clear fwnode->dev during root bridge node removal and error path Herve Codina
2026-09-09 8:12 ` sashiko-bot
2026-09-09 11:31 ` Bartosz Golaszewski
2026-09-09 8:01 ` [PATCH v11 08/10] PCI: of: Set fwnode device of newly created PCI device nodes Herve Codina
2026-09-09 8:14 ` sashiko-bot [this message]
2026-09-09 8:01 ` [PATCH v11 09/10] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node Herve Codina
2026-09-09 8:15 ` sashiko-bot
2026-09-09 8:01 ` [PATCH v11 10/10] PCI: of: Avoid np->data usage for the node changeset Herve Codina
2026-09-09 8:17 ` sashiko-bot
2026-09-09 9:06 ` Herve Codina
2026-09-09 9:12 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909081448.B57FA1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.