Re: [PATCH v3 2/2] arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

Re: [PATCH v3 2/2] arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260901075552.3558150-3-xin.liu@oss.qualcomm.com>
References: <20260901075552.3558150-3-xin.liu@oss.qualcomm.com>
TO: Xin Liu <xin.liu@oss.qualcomm.com>
TO: andersson@kernel.org
TO: konradybcio@kernel.org
TO: robh@kernel.org
TO: krzk+dt@kernel.org
TO: conor+dt@kernel.org
CC: linux-arm-msm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: kernel@oss.qualcomm.com
CC: xin.liu@oss.qualcomm.com
CC: tingwei.zhang@oss.qualcomm.com
CC: jie.gan@oss.qualcomm.com

Hi Xin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e30626823a406725ce29bc75cb8ec467d3e1e326]

url:    https://github.com/intel-lab-lkp/linux/commits/Xin-Liu/arm64-dts-qcom-hamoa-Add-PSCI-SYSTEM_RESET2-types/20260901-005545
base:   e30626823a406725ce29bc75cb8ec467d3e1e326
patch link:    https://lore.kernel.org/r/20260901075552.3558150-3-xin.liu%40oss.qualcomm.com
patch subject: [PATCH v3 2/2] arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types
:::::: branch date: 9 days ago
:::::: commit date: 9 days ago
config: arm64-randconfig-2054-20260909 (https://download.01.org/0day-ci/archive/20260909/202609092217.BKNSBRZH-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 10.5.0
dtschema: 2026.7.dev16+g39602f98e
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260909/202609092217.BKNSBRZH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202609092217.BKNSBRZH-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb: psci (arm,psci-1.0): 'reboot-mode' does not match any of the regexes: '^pinctrl-[0-9]+$', '^power-domain-'
   	from schema $id: http://devicetree.org/schemas/arm/psci.yaml
--
>> arch/arm64/boot/dts/qcom/hamoa-iot-evk-el2.dtb: psci (arm,psci-1.0): 'reboot-mode' does not match any of the regexes: '^pinctrl-[0-9]+$', '^power-domain-'
   	from schema $id: http://devicetree.org/schemas/arm/psci.yaml

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH v3 0/2] Add psci_sys_reset2 reboot modes for hamoa and purwa boards

[Xin Liu]

Adding PSCI SYSTEM_RESET2 reboot-modes for hamoa and purwa based boards.

These DT patches depend on PSCI SYSTEM_RESET2 support introduced in:
https://lore.kernel.org/all/20260803-arm-psci-system_reset2-vendor-reboots-v24-0-889281373870@oss.qualcomm.com/

To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
---
Changes in v3:
- Split into two patches: one for hamoa, one for purwa
- Move reboot-mode from shared hamoa.dtsi to board-specific files
- Add psci label in hamoa.dtsi to allow board files to reference the node
- Link to v2: https://lore.kernel.org/all/20260226054113.4156874-1-xin.liu@oss.qualcomm.com/

Changes in v2:
- Fix mode-bootloader and mode-edl reset_type
- Link to v1: https://lore.kernel.org/all/20260209042700.1186392-1-xin.liu@oss.qualcomm.com/

---
Xin Liu (2):
      arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types
      arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/hamoa.dtsi        | 2 +-
 arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 7 +++++++
 3 files changed, 15 insertions(+), 1 deletion(-)
---
base-commit: e30626823a406725ce29bc75cb8ec467d3e1e326

Best regards,
--
Xin Liu <xin.liu@oss.qualcomm.com>

[PATCH v3 2/2] arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

[Xin Liu]

Add support for SYSTEM_RESET2 vendor-specific resets as
reboot-modes in the psci node.  Describe the resets: "bootloader"
will cause device to reboot and stop in the bootloader's fastboot
mode.  "edl" will cause device to reboot into "emergency download
mode", which permits loading images via the Firehose protocol.

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
index ad503beec1d3..a6a1145f11dd 100644
--- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
@@ -1180,6 +1180,13 @@ &pmk8550_pwm {
 	status = "okay";
 };

+&psci {
+	reboot-mode {
+		mode-bootloader = <0x80010001 0x2>;
+		mode-edl = <0x80000000 0x1>;
+	};
+};
+
 &sdhc_2 {
 	cd-gpios = <&tlmm 71 GPIO_ACTIVE_LOW>;

--
2.34.1

Re: [PATCH v3 2/2] arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `reboot-mode` child node in the `psci` node violates the DT binding schema and is completely unhandled by the kernel, resulting in validation failures and a non-functional feature.
--

commit 6aadf5c7e368cd8a19850d3a52be3816bc1f1974
Author: Xin Liu <xin.liu@oss.qualcomm.com>

arm64: dts: qcom: purwa: Add PSCI SYSTEM_RESET2 types

This commit adds vendor-specific reset types to the psci device tree node
as reboot-modes for the purwa-iot-evk. The new modes are intended to allow
the device to reboot into fastboot or emergency download mode.

> diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> --- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
[ ... ]
> @@ -1180,6 +1180,13 @@ &pmk8550_pwm {
>  	status = "okay";
>  };
>  
> +&psci {
> +	reboot-mode {
> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;
> +	};
> +};

[Severity: Medium]
Will this reboot-mode node cause a dtbs_check validation error?

The psci device tree binding schema in 
Documentation/devicetree/bindings/arm/psci.yaml specifies
"additionalProperties: false" and does not define a reboot-mode child node.
Furthermore, this node lacks a compatible string, which means standard
reboot-mode drivers will not bind to it.

Additionally, are these vendor-specific reset modes actually supported by the
psci driver?

Looking at psci_sys_reset() in drivers/firmware/psci/psci.c, the kernel
hardcodes the arguments for SYSTEM_RESET2 to 0 instead of parsing them
from the device tree:

psci_sys_reset() {
		/*
		 * reset_type[31] = 0 (architectural)
		 * reset_type[30:0] = 0 (SYSTEM_WARM_RESET)
		 * cookie = 0 (ignored by the implementation)
		 */
		invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0);
}

This means that executing a command like "reboot edl" might just perform
a standard warm reset rather than the requested vendor reset, leaving the
feature non-functional.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901075552.3558150-1-xin.liu@oss.qualcomm.com?part=2