* [PATCH v12 1/2] dt-bindings: mfd: x-powers: Add AC200
2026-09-10 0:26 [PATCH v12 0/2] mfd: add X-Powers AC200 support James Hilliard
@ 2026-09-10 0:26 ` James Hilliard
2026-09-10 0:29 ` sashiko-bot
2026-09-10 0:26 ` [PATCH v12 2/2] mfd: ac200: Add X-Powers AC200 support James Hilliard
1 sibling, 1 reply; 5+ messages in thread
From: James Hilliard @ 2026-09-10 0:26 UTC (permalink / raw)
To: Jernej Skrabec, James Hilliard, Lee Jones, Arnd Bergmann,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Andrew Lunn, Jagielski, Jedrzej, Andre Przywara, Chen-Yu Tsai,
linux-sunxi, mfd, devicetree, linux-kernel, Conor Dooley
The AC200 is an I2C-controlled mixed-signal companion IC containing
audio, video, RTC and Fast Ethernet PHY functions.
Describe the shared input clock, audio DAI, TV encoder display graph and
optional bandgap calibration in one parent node. The codec and TV encoder
do not need separate firmware nodes.
AC_LDOIN and TV_VCC are distinct 3.3 V supply inputs. Describe them
separately without requiring different external regulators. Require the
audio supply when the DAI is described and the video supply when the
display graph is present, while allowing PHY-only configurations.
Describe the optional shared INTB connection without an internal
interrupt domain. Cable detection status remains readable over I2C when
INTB is not connected. Include wired and unwired examples.
The Ethernet PHY is represented by a PHY package on its MDIO bus, with a
phandle back to this device for access to the package control registers.
It therefore does not require an MFD child node. The input clock must run
at 24 or 27 MHz when the Ethernet PHY is used, matching the rates encoded
by its documented clock selector.
Co-developed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/mfd/x-powers,ac200.yaml | 168 +++++++++++++++++++++
MAINTAINERS | 7 +
2 files changed, 175 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
new file mode 100644
index 000000000000..75dafa7c1071
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
@@ -0,0 +1,168 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/x-powers,ac200.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: X-Powers AC200 mixed-signal IC
+
+maintainers:
+ - James Hilliard <james.hilliard1@gmail.com>
+ - Jernej Skrabec <jernej.skrabec@gmail.com>
+
+description:
+ The AC200 is a mixed-signal companion IC containing audio, video, RTC and
+ Fast Ethernet PHY functions. Its control registers are accessed over I2C.
+ The audio codec and TV encoder are described by properties of this node.
+ The Ethernet PHY is described separately on its MDIO bus.
+
+allOf:
+ - $ref: /schemas/sound/dai-common.yaml#
+
+properties:
+ compatible:
+ const: x-powers,ac200
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+ description:
+ AC200 input clock. When using the Ethernet PHY, its configured rate must
+ be 24 or 27 MHz, matching the rates encoded by the documented EPHY clock
+ selector.
+
+ interrupts:
+ maxItems: 1
+ description:
+ The shared, level-triggered, open-drain INTB output for the TV encoder,
+ Ethernet PHY and RTC interrupts. Omit when INTB is not connected. TV
+ encoder cable detection status can also be read over I2C without an
+ interrupt.
+
+ '#sound-dai-cells':
+ const: 0
+
+ ac-ldoin-supply:
+ description:
+ The 3.3 V supply connected to the AC_LDOIN pin for the audio codec LDO
+ input. This may be the same regulator as tv-vcc-supply.
+
+ tv-vcc-supply:
+ description:
+ The 3.3 V supply connected to the TV_VCC pin for the composite-video
+ DAC. This may be the same regulator as ac-ldoin-supply.
+
+ nvmem-cells:
+ maxItems: 1
+ description: TV encoder bandgap calibration.
+
+ nvmem-cell-names:
+ items:
+ - const: bandgap
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Input to the TV encoder, carrying CCIR656.
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Output to the composite-video connector.
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+dependencies:
+ '#sound-dai-cells': [ ac-ldoin-supply ]
+ ports: [ tv-vcc-supply ]
+ nvmem-cells: [ nvmem-cell-names ]
+ nvmem-cell-names: [ nvmem-cells ]
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mixed-signal@10 {
+ compatible = "x-powers,ac200";
+ reg = <0x10>;
+ clocks = <&pwm 5>;
+ interrupt-parent = <&pio>;
+ interrupts = <1 20 IRQ_TYPE_LEVEL_LOW>;
+ #sound-dai-cells = <0>;
+ ac-ldoin-supply = <®_aldo2>;
+ tv-vcc-supply = <®_aldo2>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ tve_in: endpoint {
+ remote-endpoint = <&tcon_out_tve>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ tve_out: endpoint {
+ remote-endpoint = <&composite_in>;
+ };
+ };
+ };
+ };
+ };
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mixed-signal@10 {
+ compatible = "x-powers,ac200";
+ reg = <0x10>;
+ clocks = <&pwm 5>;
+ /* INTB is not connected. */
+ tv-vcc-supply = <®_aldo2>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ endpoint {
+ remote-endpoint = <&tcon_out_tve>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ endpoint {
+ remote-endpoint = <&composite_in>;
+ };
+ };
+ };
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 3a19da74d00c..419340093c9b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -29504,6 +29504,13 @@ F: drivers/net/wwan/
F: include/linux/wwan.h
F: include/uapi/linux/wwan.h
+X-POWERS AC200 DRIVERS
+M: Jernej Skrabec <jernej.skrabec@gmail.com>
+M: James Hilliard <james.hilliard1@gmail.com>
+L: linux-sunxi@lists.linux.dev
+S: Maintained
+F: Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
+
X-POWERS AXP288 PMIC DRIVERS
M: Hans de Goede <hansg@kernel.org>
S: Maintained
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v12 2/2] mfd: ac200: Add X-Powers AC200 support
2026-09-10 0:26 [PATCH v12 0/2] mfd: add X-Powers AC200 support James Hilliard
2026-09-10 0:26 ` [PATCH v12 1/2] dt-bindings: mfd: x-powers: Add AC200 James Hilliard
@ 2026-09-10 0:26 ` James Hilliard
2026-09-10 0:32 ` sashiko-bot
1 sibling, 1 reply; 5+ messages in thread
From: James Hilliard @ 2026-09-10 0:26 UTC (permalink / raw)
To: Jernej Skrabec, James Hilliard, Lee Jones, Arnd Bergmann,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Andrew Lunn, Jagielski, Jedrzej, Andre Przywara, Chen-Yu Tsai,
linux-sunxi, mfd, devicetree, linux-kernel
The X-Powers AC200 is a mixed-signal companion IC with a paged register
map accessed over I2C.
Enable and rate-lock the shared input clock, retain the vendor resume
path's 40 ms wait before creating the regmap and accessing registers, and
deassert the common reset. No minimum delay is documented. Set only the
deassert bit instead of forcing a reset cycle, avoiding a chip-wide reset
of unrelated function registers. Leave the common reset deasserted during
driver removal and system shutdown; function drivers own their block
resets. Supplier unbind still tears down linked consumers and releases
the provider's clock references.
Cache only the common page selector. Individual functions can reset
independently and invalidate their other registers, so leave all
functional registers volatile.
Register the audio codec and TV encoder using static MFD cells and
automatically assigned platform device IDs. Their firmware properties
belong to the parent node. Map their supply lookups to the parent with MFD
supply aliases, without assigning separate OF nodes to the cells.
When INTB is connected, pass its physical IRQ to the TV encoder cell.
Select a cell array without IRQ resources when INTB is absent. No regmap
IRQ controller or private IRQ domain is needed.
Configure the level-triggered INTB output, defaulting to level-low when
the upstream IRQ has no trigger type. Mask all sources before enabling
INTB. Function drivers request shared threaded IRQs before enabling their
own source, check and clear their own status, and mask their source before
freeing the IRQ. Disable INTB after removing the children on failure or
removal, while the regmap and clock are still available.
The Ethernet PHY is enumerated on its MDIO bus rather than as an MFD
child. It follows the x-powers,ac200 phandle and uses this regmap for
ancillary package-control access.
Co-developed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
MAINTAINERS | 1 +
drivers/mfd/Kconfig | 14 ++++
drivers/mfd/Makefile | 1 +
drivers/mfd/ac200.c | 231 +++++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 247 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 419340093c9b..1d03b0060bda 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -29510,6 +29510,7 @@ M: James Hilliard <james.hilliard1@gmail.com>
L: linux-sunxi@lists.linux.dev
S: Maintained
F: Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
+F: drivers/mfd/ac200.c
X-POWERS AXP288 PMIC DRIVERS
M: Hans de Goede <hansg@kernel.org>
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 857ca3bb0d5b..071cba7c775b 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -205,6 +205,20 @@ config MFD_AC100
This driver include only the core APIs. You have to select individual
components like codecs or RTC under the corresponding menus.
+config MFD_AC200
+ tristate "X-Powers AC200"
+ depends on COMMON_CLK
+ depends on I2C
+ depends on OF
+ select MFD_CORE
+ select REGMAP_I2C
+ help
+ Support for the X-Powers AC200 mixed-signal companion IC. The AC200
+ contains audio, video, RTC and Fast Ethernet PHY functions and is
+ co-packaged with some Allwinner H6 and H616 SoCs. This driver provides
+ the shared register access and instantiates the individual function
+ devices.
+
config MFD_AXP20X
tristate
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 72d3944b0ad8..f8101d2a9ce9 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -150,6 +150,7 @@ obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o
obj-$(CONFIG_MFD_DA9052_I2C) += da9052-i2c.o
obj-$(CONFIG_MFD_AC100) += ac100.o
+obj-$(CONFIG_MFD_AC200) += ac200.o
obj-$(CONFIG_MFD_AXP20X) += axp20x.o
obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o
obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o
diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c
new file mode 100644
index 000000000000..af0d27ff5f45
--- /dev/null
+++ b/drivers/mfd/ac200.c
@@ -0,0 +1,231 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * MFD core driver for the X-Powers AC200
+ *
+ * Copyright (C) 2019 Jernej Skrabec <jernej.skrabec@gmail.com>
+ * Copyright (C) 2026 James Hilliard <james.hilliard1@gmail.com>
+ */
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/i2c.h>
+#include <linux/irq.h>
+#include <linux/mfd/core.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+
+#define AC200_SYS_CONTROL_REG 0x0002
+#define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0)
+#define AC200_SYS_IRQ_ENABLE_REG 0x0004
+#define AC200_SYS_IRQ_INTB_ENABLE BIT(15)
+#define AC200_SYS_IRQ_INTB_ACTIVE_HIGH BIT(14)
+#define AC200_SYS_IRQ_RTC BIT(12)
+#define AC200_SYS_IRQ_EPHY BIT(8)
+#define AC200_SYS_IRQ_TVE BIT(4)
+
+/* Interface register accessible from every register page. */
+#define AC200_TWI_REG_ADDR_H 0x00fe
+#define AC200_MAX_REG 0xa1f2
+
+static const struct regmap_range_cfg ac200_range_cfg[] = {
+ {
+ .range_max = AC200_MAX_REG,
+ .selector_reg = AC200_TWI_REG_ADDR_H,
+ .selector_mask = 0xff,
+ .window_len = 256,
+ },
+};
+
+/*
+ * Each AC200 sub-block can reset independently, invalidating its register
+ * contents without regmap's knowledge. Cache only the common page selector;
+ * this avoids a selector read-modify-write for every access on the same page
+ * without ever returning stale functional-register values.
+ */
+static bool ac200_volatile_reg(struct device *dev, unsigned int reg)
+{
+ return reg != AC200_TWI_REG_ADDR_H;
+}
+
+static const struct regmap_config ac200_regmap_config = {
+ .name = "ac200",
+ .reg_bits = 8,
+ .reg_stride = 2,
+ .val_bits = 16,
+ .ranges = ac200_range_cfg,
+ .num_ranges = ARRAY_SIZE(ac200_range_cfg),
+ .max_register = AC200_MAX_REG,
+ .volatile_reg = ac200_volatile_reg,
+ .cache_type = REGCACHE_MAPLE,
+};
+
+static const char * const ac200_codec_supplies[] = {
+ "ac-ldoin",
+};
+
+static const char * const ac200_tve_supplies[] = {
+ "tv-vcc",
+};
+
+static const struct resource ac200_tve_resources[] = {
+ DEFINE_RES_IRQ_NAMED(0, "intb"),
+};
+
+#define AC200_CELL(_name, _supplies, _resources) \
+ { \
+ .name = (_name), \
+ .parent_supplies = (_supplies), \
+ .num_parent_supplies = ARRAY_SIZE(_supplies), \
+ .resources = (_resources), \
+ .num_resources = MFD_RES_SIZE(_resources), \
+ }
+
+static const struct mfd_cell ac200_cells[] = {
+ AC200_CELL("ac200-codec", ac200_codec_supplies, NULL),
+ AC200_CELL("ac200-tve", ac200_tve_supplies, ac200_tve_resources),
+};
+
+static const struct mfd_cell ac200_noirq_cells[] = {
+ AC200_CELL("ac200-codec", ac200_codec_supplies, NULL),
+ AC200_CELL("ac200-tve", ac200_tve_supplies, NULL),
+};
+
+static void ac200_disable_intb(void *data)
+{
+ struct regmap *regmap = data;
+ int ret;
+
+ ret = regmap_clear_bits(regmap, AC200_SYS_IRQ_ENABLE_REG,
+ AC200_SYS_IRQ_INTB_ENABLE);
+ if (ret)
+ dev_err(regmap_get_device(regmap), "failed to disable INTB: %d\n",
+ ret);
+}
+
+static int ac200_init_irq(struct device *dev, struct regmap *regmap, int irq)
+{
+ unsigned int trigger;
+ u16 value = 0;
+ int ret;
+
+ trigger = irq_get_trigger_type(irq);
+ switch (trigger) {
+ case IRQ_TYPE_LEVEL_HIGH:
+ value |= AC200_SYS_IRQ_INTB_ACTIVE_HIGH;
+ break;
+ case IRQ_TYPE_NONE:
+ case IRQ_TYPE_LEVEL_LOW:
+ break;
+ default:
+ return dev_err_probe(dev, -EINVAL,
+ "INTB is level triggered, not type %u\n",
+ trigger);
+ }
+
+ /* Mask every source before enabling the shared output. */
+ ret = regmap_update_bits(regmap, AC200_SYS_IRQ_ENABLE_REG,
+ AC200_SYS_IRQ_INTB_ENABLE |
+ AC200_SYS_IRQ_INTB_ACTIVE_HIGH |
+ AC200_SYS_IRQ_RTC | AC200_SYS_IRQ_EPHY |
+ AC200_SYS_IRQ_TVE, value);
+ if (ret)
+ return ret;
+
+ /* Children are removed before INTB is disabled and the regmap released. */
+ ret = devm_add_action_or_reset(dev, ac200_disable_intb, regmap);
+ if (ret)
+ return ret;
+
+ if (trigger == IRQ_TYPE_NONE) {
+ ret = irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to set INTB trigger\n");
+ }
+
+ /*
+ * Function drivers request INTB with IRQF_SHARED | IRQF_ONESHOT before
+ * enabling their own source. They check and clear their own status and
+ * mask their source before freeing the IRQ. No IRQ domain is needed.
+ */
+ return regmap_set_bits(regmap, AC200_SYS_IRQ_ENABLE_REG,
+ AC200_SYS_IRQ_INTB_ENABLE);
+}
+
+static int ac200_probe(struct i2c_client *client)
+{
+ const struct mfd_cell *cells = ac200_noirq_cells;
+ unsigned int num_cells = ARRAY_SIZE(ac200_noirq_cells);
+ struct device *dev = &client->dev;
+ struct regmap *regmap;
+ struct clk *clk;
+ int ret;
+
+ clk = devm_clk_get_enabled(dev, NULL);
+ if (IS_ERR(clk))
+ return dev_err_probe(dev, PTR_ERR(clk),
+ "failed to enable input clock\n");
+
+ ret = devm_clk_rate_exclusive_get(dev, clk);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to lock clock rate\n");
+
+ /*
+ * No minimum delay is documented. Retain the vendor resume path's 40 ms
+ * wait after enabling the input clock and before register access.
+ */
+ msleep(40);
+
+ regmap = devm_regmap_init_i2c(client, &ac200_regmap_config);
+ if (IS_ERR(regmap))
+ return dev_err_probe(dev, PTR_ERR(regmap),
+ "failed to initialize regmap\n");
+
+ ret = regmap_set_bits(regmap, AC200_SYS_CONTROL_REG,
+ AC200_SYS_CONTROL_CHIP_RESET_DEASSERT);
+ if (ret)
+ return ret;
+
+ if (client->irq > 0) {
+ ret = ac200_init_irq(dev, regmap, client->irq);
+ if (ret)
+ return ret;
+ cells = ac200_cells;
+ num_cells = ARRAY_SIZE(ac200_cells);
+ }
+
+ /* Function drivers read their firmware properties from the parent. */
+ ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, cells, num_cells,
+ NULL, client->irq, NULL);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to add function devices\n");
+
+ return 0;
+}
+
+static const struct of_device_id ac200_of_match[] = {
+ { .compatible = "x-powers,ac200" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, ac200_of_match);
+
+static const struct i2c_device_id ac200_i2c_ids[] = {
+ { .name = "ac200" },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, ac200_i2c_ids);
+
+static struct i2c_driver ac200_driver = {
+ .driver = {
+ .name = "ac200",
+ .of_match_table = ac200_of_match,
+ },
+ .probe = ac200_probe,
+ .id_table = ac200_i2c_ids,
+};
+module_i2c_driver(ac200_driver);
+
+MODULE_AUTHOR("Jernej Skrabec <jernej.skrabec@gmail.com>");
+MODULE_AUTHOR("James Hilliard <james.hilliard1@gmail.com>");
+MODULE_DESCRIPTION("X-Powers AC200 MFD core driver");
+MODULE_LICENSE("GPL");
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread