All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
	ast@fiberby.net, i.maximets@ovn.org, one-d-wide@protonmail.com,
	fw@strlen.de, pablo@netfilter.org,
	netfilter-devel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 4/7] netlink: specs: conntrack: fix the nat-attrs attribute IDs
Date: Wed,  9 Sep 2026 17:38:48 -0700	[thread overview]
Message-ID: <20260910003852.2184031-5-kuba@kernel.org> (raw)
In-Reply-To: <20260910003852.2184031-1-kuba@kernel.org>

The enum for attr IDs says:

     CTA_NAT_V4_MINIP,
  #define CTA_NAT_MINIP CTA_NAT_V4_MINIP
     CTA_NAT_V4_MAXIP,
  #define CTA_NAT_MAXIP CTA_NAT_V4_MAXIP
     CTA_NAT_PROTO,
     CTA_NAT_V6_MINIP,
     CTA_NAT_V6_MAXIP,

Move nat-proto to the right place in the YAML spec to make sure
the attr IDs match.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/netlink/specs/conntrack.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/netlink/specs/conntrack.yaml b/Documentation/netlink/specs/conntrack.yaml
index 105b53d4b76a..0d1528507c4b 100644
--- a/Documentation/netlink/specs/conntrack.yaml
+++ b/Documentation/netlink/specs/conntrack.yaml
@@ -314,16 +314,16 @@ doc: >-
         name: nat-v4-maxip
         type: u32
         byte-order: big-endian
+      -
+        name: nat-proto
+        type: nest
+        nested-attributes: nat-proto-attrs
       -
         name: nat-v6-minip
         type: binary
       -
         name: nat-v6-maxip
         type: binary
-      -
-        name: nat-proto
-        type: nest
-        nested-attributes: nat-proto-attrs
   -
     name: seqadj-attrs
     attributes:
-- 
2.55.0


  parent reply	other threads:[~2026-09-10  0:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  0:38 [PATCH net-next 0/7] netlink: specs: conntrack: minor spec fixes Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 1/7] netlink: specs: conntrack: timestamp is a nest, not a be64 Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 2/7] netlink: specs: conntrack: fix the get reply attribute lists Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 3/7] netlink: specs: conntrack: fix SCTP conntrack state names Jakub Kicinski
2026-09-10  0:38 ` Jakub Kicinski [this message]
2026-09-10  0:38 ` [PATCH net-next 5/7] netlink: specs: conntrack: describe CTA_HELP_INFO Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 6/7] netlink: specs: conntrack: fix the per-CPU stats reply Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 7/7] netlink: specs: conntrack: tweak definition of obsolete attrs Jakub Kicinski
2026-09-10  6:40 ` [PATCH net-next 0/7] netlink: specs: conntrack: minor spec fixes Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910003852.2184031-5-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=one-d-wide@protonmail.com \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.