All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	donald.hunter@gmail.com, ast@fiberby.net, i.maximets@ovn.org,
	one-d-wide@protonmail.com, fw@strlen.de, pablo@netfilter.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] netlink: specs: conntrack: minor spec fixes
Date: Thu, 10 Sep 2026 14:40:26 +0800	[thread overview]
Message-ID: <aqJQ2rz2HDF5FTM3@fedora> (raw)
In-Reply-To: <20260910003852.2184031-1-kuba@kernel.org>

Hi Jakub,
On Wed, Sep 09, 2026 at 05:38:44PM -0700, Jakub Kicinski wrote:
> Clashiko raised a bunch of pre-existing issues on a recent series
> from Ilya. Let's fix those and whatever else pops out in AI review
> and looks relatively legitimate.
> 
> Jakub Kicinski (7):
>   netlink: specs: conntrack: timestamp is a nest, not a be64
>   netlink: specs: conntrack: fix the get reply attribute lists
>   netlink: specs: conntrack: fix SCTP conntrack state names
>   netlink: specs: conntrack: fix the nat-attrs attribute IDs
>   netlink: specs: conntrack: describe CTA_HELP_INFO
>   netlink: specs: conntrack: fix the per-CPU stats reply
>   netlink: specs: conntrack: tweak definition of obsolete attrs
> 
>  Documentation/netlink/specs/conntrack.yaml | 54 ++++++++++++++--------
>  1 file changed, 36 insertions(+), 18 deletions(-)
> 
> -- 
> 2.55.0
> 

All the changes look reasonable to me and the change matches the conntrack code.
For the series

Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>

BTW, I'm still working on rt lwtunnel encap support. I noticed some sections
in your change have documentation while others do not. Are there any mandatory
requirements for documentation at this point?

Thanks
Hangbin

  parent reply	other threads:[~2026-09-10  6:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  0:38 [PATCH net-next 0/7] netlink: specs: conntrack: minor spec fixes Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 1/7] netlink: specs: conntrack: timestamp is a nest, not a be64 Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 2/7] netlink: specs: conntrack: fix the get reply attribute lists Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 3/7] netlink: specs: conntrack: fix SCTP conntrack state names Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 4/7] netlink: specs: conntrack: fix the nat-attrs attribute IDs Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 5/7] netlink: specs: conntrack: describe CTA_HELP_INFO Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 6/7] netlink: specs: conntrack: fix the per-CPU stats reply Jakub Kicinski
2026-09-10  0:38 ` [PATCH net-next 7/7] netlink: specs: conntrack: tweak definition of obsolete attrs Jakub Kicinski
2026-09-10  6:40 ` Hangbin Liu [this message]
2026-09-10 16:03   ` [PATCH net-next 0/7] netlink: specs: conntrack: minor spec fixes Jakub Kicinski
2026-09-12  0:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqJQ2rz2HDF5FTM3@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=one-d-wide@protonmail.com \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.