Re: [PATCH v12 02/12] cxl: Make HDM commit helpers available to reset code

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `config CXL_RESET` inside the `if CXL_BUS` block causes a Kconfig unmet direct dependency warning when `CXL_BUS=m`.
--

commit 8c6d2d2149249d98c40c726d32df18f750f68999
Author: Srirangan Madhavan <smadhavan@nvidia.com>

cxl: Make HDM commit helpers available to reset code

This commit builds generic HDM resource helpers under CONFIG_CXL_RESET so
PCI reset paths can use them when cxl_core is modular. It exports the
necessary lock and commit entry points consumed by cxl_core.

> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 80aeb0d556bd7..9e6fb2290fed1 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -6,6 +6,7 @@ menuconfig CXL_BUS
>  	select FW_UPLOAD
>  	select PCI_DOE
>  	select FIRMWARE_TABLE
> +	select CXL_RESET
>  	select NUMA_KEEP_MEMINFO if NUMA_MEMBLKS
>  	select FWCTL if CXL_FEATURES
>  	help

[ ... ]

> @@ -243,4 +244,7 @@ config CXL_ATL
>  	depends on CXL_REGION
>  	depends on ACPI_PRMT && AMD_NB
>  
> +config CXL_RESET
> +	bool
> +
>  endif

[Severity: Low]
Will defining config CXL_RESET inside the if CXL_BUS block cause an unmet
direct dependency warning during build when CONFIG_CXL_BUS=m?

Because CXL_BUS uses select CXL_RESET, but CXL_RESET inherently inherits
the if CXL_BUS direct dependency, configuring CONFIG_CXL_BUS=m forces the
boolean target CXL_RESET to y while its direct dependency evaluates to m.

Could this be resolved by moving config CXL_RESET outside the if CXL_BUS
block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910070808.1444264-1-smadhavan@nvidia.com?part=2