All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: oe-kbuild-all@lists.linux.dev, Niklas Cassel <cassel@kernel.org>
Subject: [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
Date: Thu, 10 Sep 2026 07:15:44 +0800	[thread overview]
Message-ID: <202609100732.jcpwPdM6-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git for-next
head:   d82c5cf658c306979c786a6702487cf9fbc2b5de
commit: d82c5cf658c306979c786a6702487cf9fbc2b5de [7/7] ata: pata_parport: unregister devices on protocol unregister
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609100732.jcpwPdM6-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/ata/pata_parport/pata_parport.c: In function 'pi_remove_by_proto':
   drivers/ata/pata_parport/pata_parport.c:621:17: error: implicit declaration of function 'pi_remove_one' [-Wimplicit-function-declaration]
     621 |                 pi_remove_one(dev);
         |                 ^~~~~~~~~~~~~
   drivers/ata/pata_parport/pata_parport.c: At top level:
>> drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
     707 | static void pi_remove_one(struct device *dev)
         |             ^~~~~~~~~~~~~
   drivers/ata/pata_parport/pata_parport.c:707:13: error: static declaration of 'pi_remove_one' follows non-static declaration
   drivers/ata/pata_parport/pata_parport.c:621:17: note: previous implicit declaration of 'pi_remove_one' with type 'void(struct device *)'
     621 |                 pi_remove_one(dev);
         |                 ^~~~~~~~~~~~~


vim +707 drivers/ata/pata_parport/pata_parport.c

246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  706  
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23 @707  static void pi_remove_one(struct device *dev)
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  708  {
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  709  	struct ata_host *host = dev_get_drvdata(dev);
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  710  	struct pi_adapter *pi = host->private_data;
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  711  
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  712  	ata_host_detach(host);
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  713  	pi_disconnect(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  714  	pi_release(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  715  	device_unregister(dev);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14  716  	/* pata_parport_dev_release will do ida_free(dev->id) and kfree(pi) */
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  717  }
246a1c4c6b7ffb drivers/ata/pata_parport.c              Ondrej Zary 2023-01-23  718  

:::::: The code at line 707 was first introduced by commit
:::::: 246a1c4c6b7ffba88a2553d2b88f7b6280f253a2 ata: pata_parport: add driver (PARIDE replacement)

:::::: TO: Ondrej Zary <linux@zary.sk>
:::::: CC: Damien Le Moal <damien.lemoal@opensource.wdc.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-09-09 23:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 23:15 kernel test robot [this message]
2026-09-10  0:53 ` [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)' Pei Xiao
2026-09-10  1:03   ` Niklas Cassel
2026-09-10  1:04     ` Pei Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609100732.jcpwPdM6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cassel@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=xiaopei01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.