* [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
@ 2026-09-09 23:15 kernel test robot
2026-09-10 0:53 ` Pei Xiao
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2026-09-09 23:15 UTC (permalink / raw)
To: Pei Xiao; +Cc: oe-kbuild-all, Niklas Cassel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git for-next
head: d82c5cf658c306979c786a6702487cf9fbc2b5de
commit: d82c5cf658c306979c786a6702487cf9fbc2b5de [7/7] ata: pata_parport: unregister devices on protocol unregister
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609100732.jcpwPdM6-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/ata/pata_parport/pata_parport.c: In function 'pi_remove_by_proto':
drivers/ata/pata_parport/pata_parport.c:621:17: error: implicit declaration of function 'pi_remove_one' [-Wimplicit-function-declaration]
621 | pi_remove_one(dev);
| ^~~~~~~~~~~~~
drivers/ata/pata_parport/pata_parport.c: At top level:
>> drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
707 | static void pi_remove_one(struct device *dev)
| ^~~~~~~~~~~~~
drivers/ata/pata_parport/pata_parport.c:707:13: error: static declaration of 'pi_remove_one' follows non-static declaration
drivers/ata/pata_parport/pata_parport.c:621:17: note: previous implicit declaration of 'pi_remove_one' with type 'void(struct device *)'
621 | pi_remove_one(dev);
| ^~~~~~~~~~~~~
vim +707 drivers/ata/pata_parport/pata_parport.c
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 706
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 @707 static void pi_remove_one(struct device *dev)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 708 {
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 709 struct ata_host *host = dev_get_drvdata(dev);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 710 struct pi_adapter *pi = host->private_data;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 711
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 712 ata_host_detach(host);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 713 pi_disconnect(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 714 pi_release(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 715 device_unregister(dev);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 716 /* pata_parport_dev_release will do ida_free(dev->id) and kfree(pi) */
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 717 }
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 718
:::::: The code at line 707 was first introduced by commit
:::::: 246a1c4c6b7ffba88a2553d2b88f7b6280f253a2 ata: pata_parport: add driver (PARIDE replacement)
:::::: TO: Ondrej Zary <linux@zary.sk>
:::::: CC: Damien Le Moal <damien.lemoal@opensource.wdc.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
2026-09-09 23:15 [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)' kernel test robot
@ 2026-09-10 0:53 ` Pei Xiao
2026-09-10 1:03 ` Niklas Cassel
0 siblings, 1 reply; 4+ messages in thread
From: Pei Xiao @ 2026-09-10 0:53 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, Niklas Cassel
在 2026/9/10 07:15, kernel test robot 写道:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git for-next
> head: d82c5cf658c306979c786a6702487cf9fbc2b5de
> commit: d82c5cf658c306979c786a6702487cf9fbc2b5de [7/7] ata: pata_parport: unregister devices on protocol unregister
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 16.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202609100732.jcpwPdM6-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> drivers/ata/pata_parport/pata_parport.c: In function 'pi_remove_by_proto':
> drivers/ata/pata_parport/pata_parport.c:621:17: error: implicit declaration of function 'pi_remove_one' [-Wimplicit-function-declaration]
hi Maintainer,
I'm very sorry about this. I haven't had my physical machine with me
recently, so this patch hasn't been tested. What should I do now? Do I
need to revert this patch, or should I just fix this compilation error?
Pei.
Sorry again.> 621 | pi_remove_one(dev);
> | ^~~~~~~~~~~~~
> drivers/ata/pata_parport/pata_parport.c: At top level:
>>> drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
> 707 | static void pi_remove_one(struct device *dev)
> | ^~~~~~~~~~~~~
> drivers/ata/pata_parport/pata_parport.c:707:13: error: static declaration of 'pi_remove_one' follows non-static declaration
> drivers/ata/pata_parport/pata_parport.c:621:17: note: previous implicit declaration of 'pi_remove_one' with type 'void(struct device *)'
> 621 | pi_remove_one(dev);
> | ^~~~~~~~~~~~~
>
>
> vim +707 drivers/ata/pata_parport/pata_parport.c
>
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 706
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 @707 static void pi_remove_one(struct device *dev)
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 708 {
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 709 struct ata_host *host = dev_get_drvdata(dev);
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 710 struct pi_adapter *pi = host->private_data;
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 711
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 712 ata_host_detach(host);
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 713 pi_disconnect(pi);
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 714 pi_release(pi);
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 715 device_unregister(dev);
> 5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 716 /* pata_parport_dev_release will do ida_free(dev->id) and kfree(pi) */
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 717 }
> 246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 718
>
> :::::: The code at line 707 was first introduced by commit
> :::::: 246a1c4c6b7ffba88a2553d2b88f7b6280f253a2 ata: pata_parport: add driver (PARIDE replacement)
>
> :::::: TO: Ondrej Zary <linux@zary.sk>
> :::::: CC: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
2026-09-10 0:53 ` Pei Xiao
@ 2026-09-10 1:03 ` Niklas Cassel
2026-09-10 1:04 ` Pei Xiao
0 siblings, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2026-09-10 1:03 UTC (permalink / raw)
To: Pei Xiao; +Cc: kernel test robot, oe-kbuild-all, Damien Le Moal
On Thu, Sep 10, 2026 at 08:53:40AM +0800, Pei Xiao wrote:
> 在 2026/9/10 07:15, kernel test robot 写道:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git for-next
> > head: d82c5cf658c306979c786a6702487cf9fbc2b5de
> > commit: d82c5cf658c306979c786a6702487cf9fbc2b5de [7/7] ata: pata_parport: unregister devices on protocol unregister
> > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/config)
> > compiler: m68k-linux-gcc (GCC) 16.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202609100732.jcpwPdM6-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/ata/pata_parport/pata_parport.c: In function 'pi_remove_by_proto':
> > drivers/ata/pata_parport/pata_parport.c:621:17: error: implicit declaration of function 'pi_remove_one' [-Wimplicit-function-declaration]
> hi Maintainer,
> I'm very sorry about this. I haven't had my physical machine with me
> recently, so this patch hasn't been tested. What should I do now? Do I
> need to revert this patch, or should I just fix this compilation error?
I dropped this series from for-7.4.
Please send a new version that you have actually tested.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)'
2026-09-10 1:03 ` Niklas Cassel
@ 2026-09-10 1:04 ` Pei Xiao
0 siblings, 0 replies; 4+ messages in thread
From: Pei Xiao @ 2026-09-10 1:04 UTC (permalink / raw)
To: Niklas Cassel; +Cc: kernel test robot, oe-kbuild-all, Damien Le Moal
在 2026/9/10 09:03, Niklas Cassel 写道:
> On Thu, Sep 10, 2026 at 08:53:40AM +0800, Pei Xiao wrote:
>> 在 2026/9/10 07:15, kernel test robot 写道:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git for-next
>>> head: d82c5cf658c306979c786a6702487cf9fbc2b5de
>>> commit: d82c5cf658c306979c786a6702487cf9fbc2b5de [7/7] ata: pata_parport: unregister devices on protocol unregister
>>> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/config)
>>> compiler: m68k-linux-gcc (GCC) 16.1.0
>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100732.jcpwPdM6-lkp@intel.com/reproduce)
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202609100732.jcpwPdM6-lkp@intel.com/
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>> drivers/ata/pata_parport/pata_parport.c: In function 'pi_remove_by_proto':
>>> drivers/ata/pata_parport/pata_parport.c:621:17: error: implicit declaration of function 'pi_remove_one' [-Wimplicit-function-declaration]
>> hi Maintainer,
>> I'm very sorry about this. I haven't had my physical machine with me
>> recently, so this patch hasn't been tested. What should I do now? Do I
>> need to revert this patch, or should I just fix this compilation error?
>
> I dropped this series from for-7.4.
>
> Please send a new version that you have actually tested.
ok.>
>
> Kind regards,
> Niklas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-10 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09 23:15 [libata:for-next 7/7] drivers/ata/pata_parport/pata_parport.c:707:13: warning: conflicting types for 'pi_remove_one'; have 'void(struct device *)' kernel test robot
2026-09-10 0:53 ` Pei Xiao
2026-09-10 1:03 ` Niklas Cassel
2026-09-10 1:04 ` Pei Xiao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.