All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: gsh517025@gmail.com, alex@ghiti.fr, aou@eecs.berkeley.edu,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, pjw@kernel.org, robh@kernel.org,
	spacemit@lists.linux.dev
Subject: Re: [PATCH 1/1] riscv: dts: spacemit: enable onboard eeprom for OrangePi
Date: Thu, 10 Sep 2026 12:23:44 +0000	[thread overview]
Message-ID: <20260910122344-GKB20735@kernel.org> (raw)
In-Reply-To: <20260907063010.1882362-1-amadeus@jmu.edu.cn>

Hi Chukun,

On 14:30 Mon 07 Sep     , Chukun Pan wrote:
> Hi,
> 
> > -         mac-address {
> > +         mac_address: mac-address {
> 
> This requires removing the aliases for Ethernet.
> 
> > But I am not sure whether this wiring should be part of this patch.
> > Without such wiring, the kernel falls back to random MAC addresses
> > on this board.
> 
> Currently, U-Boot patches the MAC address using the Ethernet alias
> from the Device Tree. The vendor U-Boot reads the MAC address from
> the eeprom. I think the mainline U-Boot will add this feature, so
> we don't need to add this one?
> 
I think it would take long time for us to get there - to have a mainline
U-Boot which support parsing MAC address from eeprom. So, I have no
objection to the idea of adding mac info into the dts.. 

Just let me know if you guys want to do in another separate patch, so I could
take this patch first, or want to squash together and send an incremental
 version? P.S checked k1-bananapi-cm6 board which already done as suggested..

-- 
Yixun Lan (dlan)

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: gsh517025@gmail.com, alex@ghiti.fr, aou@eecs.berkeley.edu,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, pjw@kernel.org, robh@kernel.org,
	spacemit@lists.linux.dev
Subject: Re: [PATCH 1/1] riscv: dts: spacemit: enable onboard eeprom for OrangePi
Date: Thu, 10 Sep 2026 12:23:44 +0000	[thread overview]
Message-ID: <20260910122344-GKB20735@kernel.org> (raw)
In-Reply-To: <20260907063010.1882362-1-amadeus@jmu.edu.cn>

Hi Chukun,

On 14:30 Mon 07 Sep     , Chukun Pan wrote:
> Hi,
> 
> > -         mac-address {
> > +         mac_address: mac-address {
> 
> This requires removing the aliases for Ethernet.
> 
> > But I am not sure whether this wiring should be part of this patch.
> > Without such wiring, the kernel falls back to random MAC addresses
> > on this board.
> 
> Currently, U-Boot patches the MAC address using the Ethernet alias
> from the Device Tree. The vendor U-Boot reads the MAC address from
> the eeprom. I think the mainline U-Boot will add this feature, so
> we don't need to add this one?
> 
I think it would take long time for us to get there - to have a mainline
U-Boot which support parsing MAC address from eeprom. So, I have no
objection to the idea of adding mac info into the dts.. 

Just let me know if you guys want to do in another separate patch, so I could
take this patch first, or want to squash together and send an incremental
 version? P.S checked k1-bananapi-cm6 board which already done as suggested..

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-09-10 12:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  8:00 [PATCH 1/1] riscv: dts: spacemit: enable onboard eeprom for OrangePi Chukun Pan
2026-09-01  8:00 ` Chukun Pan
2026-09-05 17:05 ` Gong Shuai
2026-09-05 17:05   ` Gong Shuai
2026-09-07  6:30   ` Chukun Pan
2026-09-07  6:30     ` Chukun Pan
2026-09-10 12:23     ` Yixun Lan [this message]
2026-09-10 12:23       ` Yixun Lan
2026-09-10 12:36       ` Chukun Pan
2026-09-10 12:36         ` Chukun Pan
2026-09-10 21:54 ` Yixun Lan
2026-09-10 21:54   ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910122344-GKB20735@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=amadeus@jmu.edu.cn \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gsh517025@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.