Re: [PATCH v2 4/8] arm64: dts: rockchip: Rename rk3328 HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Changing the ALSA card name breaks userspace audio configurations (UCM, PulseAudio, PipeWire).
--

commit 7fe8827d3d20fa7fbaa3bf5003d353e243e34147
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3328 HDMI audio card
    
This commit renames the HDMI audio card in the RK3328 device tree from
"HDMI" to "RK3328 HDMI". This is intended to prevent name collisions in
ALSA fields with other Rockchip SoCs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 03b7c43137506..26c9f4558ed9c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -207,7 +207,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK3328 HDMI";

[Severity: High]
Does changing the ALSA card name break existing userspace audio
configurations?

When the kernel boots with the updated device tree, the ALSA card name is
exposed as "RK3328 HDMI" instead of "HDMI". Existing userspace UCM rules,
PulseAudio, or PipeWire configurations expecting "HDMI" will fail to match
the expected sound card profile, leaving users with broken audio.

While this change resolves a name collision between different Rockchip
boards, altering the user-visible simple-audio-card,name alters the exposed
ALSA card name and constitutes a userspace ABI breakage.

>  		status = "disabled";
>  
>  		simple-audio-card,cpu {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-fix-rockchip-hdmi-audio-names-v2-0-1396a6168e20@collabora.com?part=4