Re: [PATCH v2 8/8] arm64: dts: rockchip: Rename rk3588 HDMI audio cards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Changing the ALSA card name breaks backwards compatibility with userspace audio configurations.
--

commit 4e7ae2a4eeb352a3c16029392d27511fd5231a87
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3588 HDMI audio cards

This commit renames the HDMI audio cards in the rk3588 device tree. It updates
the simple audio card names from "hdmi0" and "hdmi1" to include the SoC
identifier, intending to match the naming scheme of the rest of the family.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 376ad04e07869..7892e18a7835a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -376,7 +376,7 @@ hdmi0_sound: hdmi0-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi0";
> +		simple-audio-card,name = "RK3588 HDMI0";

[Severity: Critical]
Does changing the simple-audio-card,name property break backwards
compatibility with existing userspace audio configurations?

Since this property directly sets the ALSA sound card name exposed to
userspace, sound servers (like PulseAudio and PipeWire) or custom user
configurations (such as ALSA UCM profiles and .asoundrc) that match on the
"hdmi0" string might fail to initialize or route the audio correctly after a
kernel upgrade.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index b251bb129cdbf..2bcf30d8a338d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> @@ -11,7 +11,7 @@ hdmi1_sound: hdmi1-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi1";
> +		simple-audio-card,name = "RK3588 HDMI1";

[Severity: Critical]
Similarly, could changing this exposed ALSA card name from "hdmi1" to
"RK3588 HDMI1" break existing userspace ABI configurations?

Users running setups configured for the old name may experience broken audio
routing on boot because their sound environments will no longer recognize the
device.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-fix-rockchip-hdmi-audio-names-v2-0-1396a6168e20@collabora.com?part=8