From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: HyeongJun An <sammiee5311@gmail.com>,
Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH 6.6.y 2/2] ALSA: rawmidi: Return the error from snd_rawmidi_input_params()
Date: Thu, 10 Sep 2026 15:42:40 -0400 [thread overview]
Message-ID: <20260910194240.1586464-2-sashal@kernel.org> (raw)
In-Reply-To: <20260910194240.1586464-1-sashal@kernel.org>
From: HyeongJun An <sammiee5311@gmail.com>
[ Upstream commit f4a23e17d84fd2a152d9e12369761934e1af0ee8 ]
The snd_rawmidi_input_params() computes err for the three invalid mode
combinations and for resize_runtime_buffer(), applies the new framing
and clock type only when err is zero, and then returns 0 anyway. A
caller that asked for parameters the kernel rejected is told the change
succeeded, and the substream keeps its old buffer.
The open_mutex conversion turned the early returns into assignments.
It handled the output sibling correctly, which still returns err, and
left this one behind.
Fixes: 94b98194b62e ("ALSA: rawmidi: Take open_mutex around parameter changes")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-opus-5
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Link: https://patch.msgid.link/20260902125058.19499-1-sammiee5311@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/core/rawmidi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c
index 7accf9a1ddf4c..00243e52fae2d 100644
--- a/sound/core/rawmidi.c
+++ b/sound/core/rawmidi.c
@@ -777,7 +777,7 @@ int snd_rawmidi_input_params(struct snd_rawmidi_substream *substream,
substream->framing = framing;
substream->clock_type = clock_type;
}
- return 0;
+ return err;
}
EXPORT_SYMBOL(snd_rawmidi_input_params);
--
2.53.0
prev parent reply other threads:[~2026-09-10 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 9:47 FAILED: patch "[PATCH] ALSA: rawmidi: Return the error from" failed to apply to 6.6-stable tree gregkh
2026-09-10 19:42 ` [PATCH 6.6.y 1/2] ALSA: rawmidi: Use guard() for locking Sasha Levin
2026-09-10 19:42 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910194240.1586464-2-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=sammiee5311@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.