From: Jennifer Guo <guojy.bj@gmail.com>
To: linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, guojy.bj@gmail.com
Subject: [PATCH 2/3] staging: rtl8723bs: delete empty comment lines in rtl8723b_*.h files
Date: Thu, 10 Sep 2026 15:03:58 -0700 [thread overview]
Message-ID: <20260910220359.6683-3-guojy.bj@gmail.com> (raw)
In-Reply-To: <20260910220359.6683-1-guojy.bj@gmail.com>
Delete all empty comment lines /* */ in
include/rtl8723b_*.h header files as they are not serving any purpose.
Add back a newline if needed for spacing, while avoiding multiple blank
lines.
Signed-off-by: Jennifer Guo <guojy.bj@gmail.com>
---
.../staging/rtl8723bs/include/rtl8723b_cmd.h | 8 +--
.../staging/rtl8723bs/include/rtl8723b_dm.h | 10 +--
.../staging/rtl8723bs/include/rtl8723b_hal.h | 4 --
.../staging/rtl8723bs/include/rtl8723b_spec.h | 72 +------------------
.../staging/rtl8723bs/include/rtl8723b_xmit.h | 10 +--
5 files changed, 7 insertions(+), 97 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h b/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h
index 6b2d79e19088..fb874971a2d4 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h
@@ -7,9 +7,7 @@
#ifndef __RTL8723B_CMD_H__
#define __RTL8723B_CMD_H__
-/* */
/* H2C CMD DEFINITION ------------------------------------------------ */
-/* */
enum {
/* Common Class: 000 */
@@ -71,9 +69,9 @@ enum {
H2C_8723B_RESET_TSF = 0xC0,
H2C_8723B_MAXID,
};
-/* */
+
/* H2C CMD CONTENT -------------------------------------------------- */
-/* */
+
/* _RSVDPAGE_LOC_CMD_0x00 */
#define SET_8723B_H2CCMD_RSVDPAGE_LOC_PROBE_RSP(__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd, 0, 8, __Value)
#define SET_8723B_H2CCMD_RSVDPAGE_LOC_PSPOLL(__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT((__pH2CCmd)+1, 0, 8, __Value)
@@ -158,9 +156,7 @@ enum {
#define SET_8723B_H2CCMD_BT_FW_PATCH_ADDR2(__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE((__pH2CCmd)+4, 0, 8, __Value)
#define SET_8723B_H2CCMD_BT_FW_PATCH_ADDR3(__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE((__pH2CCmd)+5, 0, 8, __Value)
-/* */
/* Function Statement -------------------------------------------------- */
-/* */
/* host message to firmware cmd */
void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapter, u8 Mode);
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_dm.h b/drivers/staging/rtl8723bs/include/rtl8723b_dm.h
index 50ab7aed079e..cc94edcaeb3c 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_dm.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_dm.h
@@ -6,21 +6,13 @@
******************************************************************************/
#ifndef __RTL8723B_DM_H__
#define __RTL8723B_DM_H__
-/* */
+
/* Description: */
-/* */
/* This file is for 8723B dynamic mechanism only */
-/* */
-/* */
-/* */
-/* */
/* structure and define */
-/* */
-/* */
/* function prototype */
-/* */
void rtl8723b_init_dm_priv(struct adapter *padapter);
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
index 497b1cbc54c8..8d1d721a6d72 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
@@ -19,9 +19,7 @@
#include "Hal8192CPhyReg.h"
#include "hal_phy_cfg.h"
-/* */
/* RTL8723B From header */
-/* */
#define FW_8723B_SIZE 0x8000
#define FW_8723B_START_ADDRESS 0x1000
@@ -150,9 +148,7 @@ struct rt_firmware_hdr {
#define EFUSE_ACCESS_ON 0x69 /* For RTL8723 only. */
#define EFUSE_ACCESS_OFF 0x00 /* For RTL8723 only. */
-/* */
/* EFUSE for BT definition */
-/* */
#define EFUSE_BT_REAL_BANK_CONTENT_LEN 512
#define EFUSE_BT_REAL_CONTENT_LEN 1536 /* 512*3 */
#define EFUSE_BT_MAP_LEN 1024 /* 1k bytes */
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h b/drivers/staging/rtl8723bs/include/rtl8723b_spec.h
index 7f749e32a5b9..a5ca5ae1a934 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_spec.h
@@ -9,11 +9,7 @@
#define HAL_NAV_UPPER_UNIT_8723B 128 /* micro-second */
-/* */
-/* */
/* 0x0000h ~ 0x00FFh System Configuration */
-/* */
-/* */
#define REG_RSV_CTRL_8723B 0x001C /* 3 Byte */
#define REG_BT_WIFI_ANTENNA_SWITCH_8723B 0x0038
#define REG_HSISR_8723B 0x005c
@@ -29,11 +25,7 @@
#define REG_HISR1_8723B 0x00BC
#define REG_PMC_DBG_CTRL2_8723B 0x00CC
-/* */
-/* */
/* 0x0100h ~ 0x01FFh MACTOP General Configuration */
-/* */
-/* */
#define REG_C2HEVT_CMD_ID_8723B 0x01A0
#define REG_C2HEVT_CMD_LEN_8723B 0x01AE
#define REG_WOWLAN_WAKE_REASON 0x01C7
@@ -45,25 +37,14 @@
#define REG_HMEBOX_EXT2_8723B 0x01F8
#define REG_HMEBOX_EXT3_8723B 0x01FC
-/* */
-/* */
/* 0x0200h ~ 0x027Fh TXDMA Configuration */
-/* */
-/* */
-/* */
-/* */
/* 0x0280h ~ 0x02FFh RXDMA Configuration */
-/* */
-/* */
+
#define REG_RXDMA_CONTROL_8723B 0x0286 /* Control the RX DMA. */
#define REG_RXDMA_MODE_CTRL_8723B 0x0290
-/* */
-/* */
/* 0x0300h ~ 0x03FFh PCIe */
-/* */
-/* */
#define REG_PCIE_CTRL_REG_8723B 0x0300
#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */
#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address */
@@ -86,49 +67,27 @@
#define REG_PCIE_HCPWM_8723B 0x0363 /* PCIe CPWM */
#define REG_PCIE_MULTIFET_CTRL_8723B 0x036A /* PCIE Multi-Fethc Control */
-/* */
-/* */
/* 0x0400h ~ 0x047Fh Protocol Configuration */
-/* */
-/* */
#define REG_TXPKTBUF_BCNQ_BDNY_8723B 0x0424
#define REG_TXPKTBUF_MGQ_BDNY_8723B 0x0425
#define REG_TXPKTBUF_WMAC_LBK_BF_HD_8723B 0x045D
#define REG_AMPDU_BURST_MODE_8723B 0x04BC
-/* */
-/* */
/* 0x0500h ~ 0x05FFh EDCA Configuration */
-/* */
-/* */
#define REG_SECONDARY_CCA_CTRL_8723B 0x0577
-/* */
-/* */
/* 0x0600h ~ 0x07FFh WMAC Configuration */
-/* */
-/* */
-/* */
/* SDIO Bus Specification */
-/* */
-/* */
/* SDIO CMD Address Mapping */
-/* */
-/* */
/* I/O bus domain (Host) */
-/* */
-/* */
/* SDIO register */
-/* */
#define SDIO_REG_HCPWM1_8723B 0x025 /* HCI Current Power Mode 1 */
-/* */
/* 8723 Register Bit and Content definition */
-/* */
/* 2 HSISR */
/* interrupt mask which needs to clear */
@@ -138,54 +97,27 @@
HSISR_PDNINT |\
HSISR_GPIO9_INT)
-/* */
-/* */
/* 0x0100h ~ 0x01FFh MACTOP General Configuration */
-/* */
-/* */
-/* */
-/* */
/* 0x0200h ~ 0x027Fh TXDMA Configuration */
-/* */
-/* */
-/* */
-/* */
/* 0x0280h ~ 0x02FFh RXDMA Configuration */
-/* */
-/* */
#define BIT_USB_RXDMA_AGG_EN BIT(31)
#define RXDMA_AGG_MODE_EN BIT(1)
-/* */
-/* */
/* 0x0400h ~ 0x047Fh Protocol Configuration */
-/* */
-/* */
-/* */
/* 8723B REG_CCK_CHECK (offset 0x454) */
-/* */
+
#define BIT_BCN_PORT_SEL BIT(5)
-/* */
-/* */
/* 0x0500h ~ 0x05FFh EDCA Configuration */
-/* */
-/* */
-/* */
-/* */
/* 0x0600h ~ 0x07FFh WMAC Configuration */
-/* */
-/* */
#define EEPROM_RF_GAIN_OFFSET 0xC1
#define EEPROM_RF_GAIN_VAL 0x1F6
-/* */
/* 8195 IMR/ISR bits (offset 0xB0, 8bits) */
-/* */
#define IMR_DISABLED_8723B 0
/* IMR DW0(0x00B0-00B3) Bit 0-31 */
#define IMR_TIMER2_8723B BIT(31) /* Timeout interrupt 2 */
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
index ddf868c7899b..d02ead67777a 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
@@ -7,9 +7,7 @@
#ifndef __RTL8723B_XMIT_H__
#define __RTL8723B_XMIT_H__
-/* */
/* Queue Select Value in TxDesc */
-/* */
#define QSLT_BK 0x2/* 0x01 */
#define QSLT_BE 0x0
#define QSLT_VI 0x5/* 0x4 */
@@ -56,9 +54,7 @@
/* OFFSET 20 */
#define SGI BIT(6)
-/* */
/* defined for TX DESC Operation */
-/* */
struct txdesc_8723b {
/* Offset 0 */
u32 pktlen:16;
@@ -364,11 +360,9 @@ struct txdesc_8723b {
#define SET_EARLYMODE_LEN3_8723B(__pAddr, __Value) SET_BITS_TO_LE_4BYTE(__pAddr+4, 17, 15, __Value)
#endif
-/* */
-/* */
+
/* Rate */
-/* */
-/* */
+
/* CCK Rates, TxHT = 0 */
#define DESC8723B_RATE1M 0x00
#define DESC8723B_RATE2M 0x01
--
2.34.1
next prev parent reply other threads:[~2026-09-10 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 22:03 [PATCH 0/3] staging: rtl8723bs: delete empty comment lines Jennifer Guo
2026-09-10 22:03 ` [PATCH 1/3] staging: rtl8723bs: delete empty comment lines in hal_com_reg.h Jennifer Guo
2026-09-10 22:03 ` Jennifer Guo [this message]
2026-09-10 22:03 ` [PATCH 3/3] staging: rtl8723bs: delete empty comment lines in header files Jennifer Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910220359.6683-3-guojy.bj@gmail.com \
--to=guojy.bj@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.