[PATCH 0/2] ARM: dts: ti: Clean up OMAP crypto bindings and dt

[PATCH 0/2] ARM: dts: ti: Clean up OMAP crypto bindings and dt

[Bhargav Joshi]

Patch 1 removes redundant "clocks" and "clock-names" properties from the
DRA7 crypto dt nodes.

Patch 2 updates the ti,omap-sham YAML binding to add the missing
"ti,omap3-sham" compatible, deprecates "ti,hwmods" and removes it from
the required properties list.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Bhargav Joshi (2):
      ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes
      dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods

 Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml | 3 ++-
 arch/arm/boot/dts/ti/omap/dra7.dtsi                        | 8 --------
 2 files changed, 2 insertions(+), 9 deletions(-)
---
base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
change-id: 20260911-ti-dra7-omap-sham-fix-388a067572b3

Best regards,
-- 
Bhargav

[PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Bhargav Joshi]

The omap-sham and omap-aes crypto drivers do not use "clocks" and
"clock-names" properties. Clock management is handled by the ti-sysc
interconnect parent wrapper. The dt-bindings for ti,omap-sham and
ti,omap-aes don't define these clock properties. Having them in the
child nodes causes dtbs_check warnings.

Remove the "clocks" and "clock-names" properties from the sham and aes
nodes.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 arch/arm/boot/dts/ti/omap/dra7.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
index 711ce4c31bb1..0784c6d9cbe4 100644
--- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
@@ -1012,8 +1012,6 @@ aes1: aes@0 {
 				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
 				dma-names = "tx", "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1043,8 +1041,6 @@ aes2: aes@0 {
 				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
 				dma-names = "tx", "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1073,8 +1069,6 @@ sham1: sham@0 {
 				interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 119 0>;
 				dma-names = "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 
@@ -1103,8 +1097,6 @@ sham2: sham@0 {
 				interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
 				dmas = <&edma_xbar 165 0>;
 				dma-names = "rx";
-				clocks = <&l3_iclk_div>;
-				clock-names = "fck";
 			};
 		};
 

-- 
2.55.0

[PATCH 2/2] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods

[Bhargav Joshi]

The OMAP SHAM driver supports OMAP3 SoCs, and "ti,omap3-sham" is
actively used in existing dts. However, it was previously missing from
binding. Add "ti,omap3-sham" to the list of valid compatibles.

The legacy "ti,hwmods" property is no longer needed as TI OMAP mirgrated
to "ti-sysc". Mark it as deprecated and remove it from the required
properties.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
index d69b50228009..3ef05890e13a 100644
--- a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
@@ -13,6 +13,7 @@ properties:
   compatible:
     enum:
       - ti,omap2-sham
+      - ti,omap3-sham
       - ti,omap4-sham
       - ti,omap5-sham
 
@@ -32,6 +33,7 @@ properties:
     description: Name of the hwmod associated with the SHAM module
     $ref: /schemas/types.yaml#/definitions/string
     enum: [sham]
+    deprecated: true
 
 dependencies:
   dmas: [dma-names]
@@ -40,7 +42,6 @@ additionalProperties: false
 
 required:
   - compatible
-  - ti,hwmods
   - reg
   - interrupts
 

-- 
2.55.0

Re: [PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] The $id field in the YAML binding schemas for ti,omap2-aes and ti,omap4-des lacks the required 'crypto/' subdirectory path component, breaking schema cross-referencing.
--

commit c96c7ea0473045fc72e713eb6392d7342cfcdd4f
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

This patch removes the "clocks" and "clock-names" properties from the
omap-sham and omap-aes nodes in the dra7 device tree. The crypto
drivers do not use these properties, and their dt-bindings do not define
them, which currently causes dtbs_check warnings.

>     The omap-sham and omap-aes crypto drivers do not use "clocks" and
>     "clock-names" properties. Clock management is handled by the ti-sysc
>     interconnect parent wrapper. The dt-bindings for ti,omap-sham and
>     ti,omap-aes don't define these clock properties. Having them in the
>     child nodes causes dtbs_check warnings.

[Severity: Low]
This is a pre-existing issue, but the $id fields in the YAML binding schemas
for ti,omap2-aes and ti,omap4-des lack the required 'crypto/' subdirectory
path component.

For example, in Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml:

  $id: http://devicetree.org/schemas/ti,omap2-aes.yaml#

And in Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml:

  $id: http://devicetree.org/schemas/ti,omap4-des.yaml#

Could this break schema cross-referencing ($ref) and cause dt_binding_check
to report misleading errors or skip validation?

Should these files be updated to include the crypto/ subdirectory path
component?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-ti-dra7-omap-sham-fix-v1-0-c430f01b4e13@gmail.com?part=1

Re: [PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

[Andreas Kemnade]

On Fri, 11 Sep 2026 03:41:57 +0530
Bhargav Joshi <j.bhargav.u@gmail.com> wrote:

> The omap-sham and omap-aes crypto drivers do not use "clocks" and
> "clock-names" properties. Clock management is handled by the ti-sysc
> interconnect parent wrapper. The dt-bindings for ti,omap-sham and
> ti,omap-aes don't define these clock properties. Having them in the
> child nodes causes dtbs_check warnings.
> 
> Remove the "clocks" and "clock-names" properties from the sham and aes
> nodes.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

> ---
>  arch/arm/boot/dts/ti/omap/dra7.dtsi | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> index 711ce4c31bb1..0784c6d9cbe4 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
> @@ -1012,8 +1012,6 @@ aes1: aes@0 {
>  				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 111 0>, <&edma_xbar 110 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1043,8 +1041,6 @@ aes2: aes@0 {
>  				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 114 0>, <&edma_xbar 113 0>;
>  				dma-names = "tx", "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1073,8 +1069,6 @@ sham1: sham@0 {
>  				interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 119 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> @@ -1103,8 +1097,6 @@ sham2: sham@0 {
>  				interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
>  				dmas = <&edma_xbar 165 0>;
>  				dma-names = "rx";
> -				clocks = <&l3_iclk_div>;
> -				clock-names = "fck";
>  			};
>  		};
>  
> 

Re: [PATCH 2/2] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods

[Andreas Kemnade]

On Fri, 11 Sep 2026 03:41:58 +0530
Bhargav Joshi <j.bhargav.u@gmail.com> wrote:

> The OMAP SHAM driver supports OMAP3 SoCs, and "ti,omap3-sham" is
> actively used in existing dts. However, it was previously missing from
> binding. Add "ti,omap3-sham" to the list of valid compatibles.
> 
> The legacy "ti,hwmods" property is no longer needed as TI OMAP mirgrated
> to "ti-sysc". Mark it as deprecated and remove it from the required
> properties.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>

What about also removing ti,hwmods usage while you are deprecating it?

Regards,
Andreas
> ---
>  Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> index d69b50228009..3ef05890e13a 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> @@ -13,6 +13,7 @@ properties:
>    compatible:
>      enum:
>        - ti,omap2-sham
> +      - ti,omap3-sham
>        - ti,omap4-sham
>        - ti,omap5-sham
>  
> @@ -32,6 +33,7 @@ properties:
>      description: Name of the hwmod associated with the SHAM module
>      $ref: /schemas/types.yaml#/definitions/string
>      enum: [sham]
> +    deprecated: true
>  
>  dependencies:
>    dmas: [dma-names]
> @@ -40,7 +42,6 @@ additionalProperties: false
>  
>  required:
>    - compatible
> -  - ti,hwmods
>    - reg
>    - interrupts
>  
> 

Re: [PATCH 2/2] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods

[Bhargav Joshi]

On Fri, Sep 11, 2026 at 11:54 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> On Fri, 11 Sep 2026 03:41:58 +0530
> Bhargav Joshi <j.bhargav.u@gmail.com> wrote:
>
> > The OMAP SHAM driver supports OMAP3 SoCs, and "ti,omap3-sham" is
> > actively used in existing dts. However, it was previously missing from
> > binding. Add "ti,omap3-sham" to the list of valid compatibles.
> >
> > The legacy "ti,hwmods" property is no longer needed as TI OMAP mirgrated
> > to "ti-sysc". Mark it as deprecated and remove it from the required
> > properties.
> >
> > Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
>
> What about also removing ti,hwmods usage while you are deprecating it?

Omap 4, 5 and dra7 already use ti,sysc wrapper and don't actually use ti,hwmods.
but legacy omap 2 and 3 still use ti,hwmods but I don't have hardware
to test changes.

Since omap 4,5 etc don't use it,hwmods keeping it in required causes warnings,
Deprecating it and removing it from "required" fixes the warnings for
modern SoCs without
breaking the legacy ones.

Best Regards,
Bhargav

>
> Regards,
> Andreas
> > ---
> >  Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> > index d69b50228009..3ef05890e13a 100644
> > --- a/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/ti,omap-sham.yaml
> > @@ -13,6 +13,7 @@ properties:
> >    compatible:
> >      enum:
> >        - ti,omap2-sham
> > +      - ti,omap3-sham
> >        - ti,omap4-sham
> >        - ti,omap5-sham
> >
> > @@ -32,6 +33,7 @@ properties:
> >      description: Name of the hwmod associated with the SHAM module
> >      $ref: /schemas/types.yaml#/definitions/string
> >      enum: [sham]
> > +    deprecated: true
> >
> >  dependencies:
> >    dmas: [dma-names]
> > @@ -40,7 +42,6 @@ additionalProperties: false
> >
> >  required:
> >    - compatible
> > -  - ti,hwmods
> >    - reg
> >    - interrupts
> >
> >
>