* [PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14
@ 2026-09-02 9:58 Suneeth D
2026-09-03 18:39 ` John Kacur
2026-09-10 18:06 ` John Kacur
0 siblings, 2 replies; 4+ messages in thread
From: Suneeth D @ 2026-09-02 9:58 UTC (permalink / raw)
To: linux-rt-users; +Cc: williams, jkacur, bigeasy, Suneeth D
timerthread() uses bool, true, and false. Those are keywords in C23,
which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
there without stdbool.h. With the earlier versions of GCC the default is gnu17,
where they are provided by <stdbool.h>, and the build fails without it.
Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/
Signed-off-by: Suneeth D <Suneeth.D@amd.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
Changes since v1 ---> v2:
* Modify commit message to include Tomas Glozar's note on default
changes happened since GCC 15.
based on: fd45df830803dd7f26d2ca8bdcf05fd7e0d62ae8 (rt-tests/main)
src/cyclictest/cyclictest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 99194378f946..58b56bcede0f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -15,6 +15,7 @@
#include <stdlib.h>
#include <stdint.h>
#include <stdarg.h>
+#include <stdbool.h>
#include <unistd.h>
#include <fcntl.h>
#include <getopt.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14
2026-09-02 9:58 Suneeth D
@ 2026-09-03 18:39 ` John Kacur
2026-09-10 18:06 ` John Kacur
1 sibling, 0 replies; 4+ messages in thread
From: John Kacur @ 2026-09-03 18:39 UTC (permalink / raw)
To: Suneeth D; +Cc: linux-rt-users, williams, jkacur, bigeasy
On Wed, 2 Sep 2026, Suneeth D wrote:
> timerthread() uses bool, true, and false. Those are keywords in C23,
> which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
> there without stdbool.h. With the earlier versions of GCC the default is gnu17,
> where they are provided by <stdbool.h>, and the build fails without it.
>
> Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
> Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/
> Signed-off-by: Suneeth D <Suneeth.D@amd.com>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14
2026-09-02 9:58 Suneeth D
2026-09-03 18:39 ` John Kacur
@ 2026-09-10 18:06 ` John Kacur
1 sibling, 0 replies; 4+ messages in thread
From: John Kacur @ 2026-09-10 18:06 UTC (permalink / raw)
To: Suneeth D; +Cc: linux-rt-users, williams, jkacur, bigeasy
On Wed, 2 Sep 2026, Suneeth D wrote:
> timerthread() uses bool, true, and false. Those are keywords in C23,
> which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
> there without stdbool.h. With the earlier versions of GCC the default is gnu17,
> where they are provided by <stdbool.h>, and the build fails without it.
>
> Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
> Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/
> Signed-off-by: Suneeth D <Suneeth.D@amd.com>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>
> Changes since v1 ---> v2:
>
> * Modify commit message to include Tomas Glozar's note on default
> changes happened since GCC 15.
>
[snip]
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14
@ 2026-09-11 5:29 Suneeth D
0 siblings, 0 replies; 4+ messages in thread
From: Suneeth D @ 2026-09-11 5:29 UTC (permalink / raw)
To: linux-rt-users; +Cc: williams, jkacur, bigeasy, Suneeth D
timerthread() uses bool, true, and false. Those are keywords in C23,
which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
there without stdbool.h. With the earlier versions of GCC the default is gnu17,
where they are provided by <stdbool.h>, and the build fails without it.
Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/
Signed-off-by: Suneeth D <Suneeth.D@amd.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
Changes since v1 ---> v2:
* Modify commit message to include Tomas Glozar's note on default
changes happened since GCC 15.
based on: fd45df830803dd7f26d2ca8bdcf05fd7e0d62ae8 (rt-tests/main)
src/cyclictest/cyclictest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 99194378f946..58b56bcede0f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -15,6 +15,7 @@
#include <stdlib.h>
#include <stdint.h>
#include <stdarg.h>
+#include <stdbool.h>
#include <unistd.h>
#include <fcntl.h>
#include <getopt.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-11 5:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 5:29 [PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14 Suneeth D
-- strict thread matches above, loose matches on Subject: below --
2026-09-02 9:58 Suneeth D
2026-09-03 18:39 ` John Kacur
2026-09-10 18:06 ` John Kacur
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.