From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 7/8] arm64: dts: qcom: sm8750: Add t-power-on-us property for PCIe root port
Date: Fri, 11 Sep 2026 06:58:17 +0000 [thread overview]
Message-ID: <20260911065817.AA2181F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911-t_pwr_on-v1-7-c9eee197d082@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The property 't-power-on-us' is introduced in the device tree without a corresponding update to the device tree binding schema.
--
commit 0f66318dcdfeebf212674b31a30fbfa300a4c149
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
arm64: dts: qcom: sm8750: Add t-power-on-us property for PCIe root port
This commit adds the t-power-on-us property to the PCIe root port on the
sm8750 platform. This ensures T_POWER_ON is correctly programmed during host
initialization, preventing improper L1.2 exit behavior.
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index dd738d13df8e0..bb57385678f4d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -5577,6 +5577,8 @@ pcieport0: pcie@0 {
> #size-cells = <2>;
> ranges;
> phys = <&pcie0_phy>;
> +
> + t-power-on-us = <80>;
[Severity: Low]
Does this new property cause make dtbs_check to emit schema validation
warnings? It appears t-power-on-us is being introduced here in pcieport0
without a corresponding update to the device tree binding schema.
> };
> };
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-t_pwr_on-v1-0-c9eee197d082@oss.qualcomm.com?part=7
next prev parent reply other threads:[~2026-09-11 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 6:50 [PATCH 0/8] arm64: dts: qcom: Add t-power-on-us property for PCIe root ports Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 1/8] arm64: dts: qcom: kodiak: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 2/8] arm64: dts: qcom: lemans: " Krishna Chaitanya Chundru
2026-09-11 7:03 ` sashiko-bot
2026-09-11 6:50 ` [PATCH 3/8] arm64: dts: qcom: monaco: " Krishna Chaitanya Chundru
2026-09-11 7:02 ` sashiko-bot
2026-09-11 6:50 ` [PATCH 4/8] arm64: dts: qcom: hamoa: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 5/8] arm64: dts: qcom: glymur: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 6/8] arm64: dts: qcom: talos: Add t-power-on-us property for PCIe root port Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 7/8] arm64: dts: qcom: sm8750: " Krishna Chaitanya Chundru
2026-09-11 6:58 ` sashiko-bot [this message]
2026-09-11 6:50 ` [PATCH 8/8] arm64: dts: qcom: kaanapali: " Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911065817.AA2181F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.