From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/8] arm64: dts: qcom: monaco: Add t-power-on-us property for PCIe root ports
Date: Fri, 11 Sep 2026 07:02:50 +0000 [thread overview]
Message-ID: <20260911070250.8C0321F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911-t_pwr_on-v1-3-c9eee197d082@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 't-power-on-us' property is added to the device tree but is not documented in any DT binding schema, which will cause dtbs_check schema validation errors.
--
commit 9b34f8b26e1f1d145e5d0352099be4384e076f5b
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
arm64: dts: qcom: monaco: Add t-power-on-us property for PCIe root ports
This commit adds the t-power-on-us property to the PCIe root ports in the
Monaco device tree. The property is intended to correctly program the
T_POWER_ON value during host initialization to prevent improper L1.2 exit
behavior.
> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index cfe39f923224f..d9c3669b5e1b7 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
> @@ -2402,6 +2402,8 @@ pcieport0: pcie@0 {
> #size-cells = <2>;
> ranges;
> phys = <&pcie0_phy>;
> +
> + t-power-on-us = <80>;
[Severity: Low]
Is there a corresponding device tree binding schema update for this property?
Since t-power-on-us is not currently documented in the schema, it looks like
this addition will trigger make dtbs_check validation errors when
qcom,pcie-common.yaml enforces unevaluatedProperties: false on the pcie@
child nodes.
> };
> };
>
> @@ -2593,6 +2595,8 @@ pcieport1: pcie@0 {
> #size-cells = <2>;
> ranges;
> phys = <&pcie1_phy>;
> +
> + t-power-on-us = <80>;
> };
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-t_pwr_on-v1-0-c9eee197d082@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-09-11 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 6:50 [PATCH 0/8] arm64: dts: qcom: Add t-power-on-us property for PCIe root ports Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 1/8] arm64: dts: qcom: kodiak: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 2/8] arm64: dts: qcom: lemans: " Krishna Chaitanya Chundru
2026-09-11 7:03 ` sashiko-bot
2026-09-11 6:50 ` [PATCH 3/8] arm64: dts: qcom: monaco: " Krishna Chaitanya Chundru
2026-09-11 7:02 ` sashiko-bot [this message]
2026-09-11 6:50 ` [PATCH 4/8] arm64: dts: qcom: hamoa: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 5/8] arm64: dts: qcom: glymur: " Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 6/8] arm64: dts: qcom: talos: Add t-power-on-us property for PCIe root port Krishna Chaitanya Chundru
2026-09-11 6:50 ` [PATCH 7/8] arm64: dts: qcom: sm8750: " Krishna Chaitanya Chundru
2026-09-11 6:58 ` sashiko-bot
2026-09-11 6:50 ` [PATCH 8/8] arm64: dts: qcom: kaanapali: " Krishna Chaitanya Chundru
2026-09-21 8:39 ` [PATCH 0/8] arm64: dts: qcom: Add t-power-on-us property for PCIe root ports Konrad Dybcio
2026-09-21 11:10 ` Krishna Chaitanya Chundru
2026-09-21 11:34 ` Manivannan Sadhasivam
2026-09-21 11:44 ` Konrad Dybcio
2026-09-21 11:54 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911070250.8C0321F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.