All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Melendez <chrismelnu@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Jonas Gorski <jonas.gorski@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org
Subject: b53.rst: is the 5325/5365 "no tagging support" section still accurate?
Date: Fri, 11 Sep 2026 12:35:10 +0200	[thread overview]
Message-ID: <20260911103511.171722-1-chrismelnu@gmail.com> (raw)

Hi Álvaro,

Documentation/networking/dsa/b53.rst still lists 5325/5365 under
"Configuration without tagging support", saying they "support a
different tag format that is not supported yet". But
b53_get_tag_protocol() assigns them DSA_TAG_PROTO_BRCM_LEGACY_FCS,
which seems to have an implementation in net/dsa/tag_brcm.c
(brcm_leg_fcs_tag_xmit). This looks like it's been true since
c3cf059a4d41.

Separately, ds->untag_bridge_pvid (b53_common.c) is only set when
tag_protocol == DSA_TAG_PROTO_NONE -- which I guess no longer applies
to 5325/5365 -- so the VLAN workaround described right after
(removing the default VLAN 1) may not apply to them either anymore.

Is the doc just stale on both counts, or is there a reason 5325/5365
still belong in that section in practice? I don't have this hardware
to test against. Happy to send a fix once I know which parts still
hold.

Thanks,
Christian

             reply	other threads:[~2026-09-11 10:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 10:35 Christian Melendez [this message]
2026-09-14 14:16 ` b53.rst: is the 5325/5365 "no tagging support" section still accurate? Jonas Gorski
2026-09-22 17:48   ` Christian Melendez
2026-09-22 18:25     ` Jonas Gorski
2026-09-22 21:14       ` [PATCH 1/2] Documentation: dsa: b53: fix stale tagging-support section Christian Melendez
2026-09-22 21:14         ` [PATCH 2/2] MAINTAINERS: add missing entry for b53.rst Christian Melendez
2026-09-23 21:17         ` [PATCH 1/2] Documentation: dsa: b53: fix stale tagging-support section netdev-bot+sashiko
2026-09-26  0:55           ` Jakub Kicinski
2026-09-29  0:00         ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911103511.171722-1-chrismelnu@gmail.com \
    --to=chrismelnu@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noltari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.