From: Christian Melendez <chrismelnu@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Melendez <chrismelnu@gmail.com>
Subject: [PATCH 1/2] Documentation: dsa: b53: fix stale tagging-support section
Date: Tue, 22 Sep 2026 23:14:38 +0200 [thread overview]
Message-ID: <20260922211439.369917-1-chrismelnu@gmail.com> (raw)
In-Reply-To: <CAOiHx==_ixY-VNWX=XxqCFoJvE-80i+r2y6SNnxwQe9uZQJL6w@mail.gmail.com>
5325/5365 were listed under "Configuration without tagging support".
b53_get_tag_protocol() assigns them DSA_TAG_PROTO_BRCM_LEGACY_FCS
(commit c3cf059a4d41), implemented in net/dsa/tag_brcm.c. Move them to
the tagging-supported section.
539x/531x5, the only chips left in that section, get no special case
in b53_get_tag_protocol() either. The section and its config examples
no longer apply to any b53 switch, so remove them.
Link: https://patch.msgid.link/CAOiHx==_ixY-VNWX=XxqCFoJvE-80i+r2y6SNnxwQe9uZQJL6w@mail.gmail.com
Signed-off-by: Christian Melendez <chrismelnu@gmail.com>
---
Documentation/networking/dsa/b53.rst | 151 +--------------------------
1 file changed, 3 insertions(+), 148 deletions(-)
diff --git a/Documentation/networking/dsa/b53.rst b/Documentation/networking/dsa/b53.rst
index 1cb3ff648f88..b67864b2d314 100644
--- a/Documentation/networking/dsa/b53.rst
+++ b/Documentation/networking/dsa/b53.rst
@@ -23,9 +23,6 @@ CPU interface, conversely, the CPU network interface should insert a similar
tag for packets entering the CPU port. The tag format is described in
``net/dsa/tag_brcm.c``.
-The configuration of the device depends on whether or not tagging is
-supported.
-
The interface names and example network configuration are used according the
configuration described in the :ref:`dsa-config-showcases`.
@@ -35,149 +32,7 @@ Configuration with tagging support
The tagging based configuration is desired. It is not specific to the b53
DSA driver and will work like all DSA drivers which supports tagging.
-See :ref:`dsa-tagged-configuration`.
-
-Configuration without tagging support
--------------------------------------
-
-Older models (5325, 5365) support a different tag format that is not supported
-yet. 539x and 531x5 require managed mode and some special handling, which is
-also not yet supported. The tagging support is disabled in these cases and the
-switch need a different configuration.
-
-The configuration slightly differ from the :ref:`dsa-vlan-configuration`.
-
-The b53 tags the CPU port in all VLANs, since otherwise any PVID untagged
-VLAN programming would basically change the CPU port's default PVID and make
-it untagged, undesirable.
-
-In difference to the configuration described in :ref:`dsa-vlan-configuration`
-the default VLAN 1 has to be removed from the user interface configuration in
-single port and gateway configuration, while there is no need to add an extra
-VLAN configuration in the bridge showcase.
-
-single port
-~~~~~~~~~~~
-The configuration can only be set up via VLAN tagging and bridge setup.
-By default packages are tagged with vid 1:
-
-.. code-block:: sh
-
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
- ip link add link eth0 name eth0.2 type vlan id 2
- ip link add link eth0 name eth0.3 type vlan id 3
-
- # The conduit interface needs to be brought up before the user ports.
- ip link set eth0 up
- ip link set eth0.1 up
- ip link set eth0.2 up
- ip link set eth0.3 up
-
- # bring up the user interfaces
- ip link set wan up
- ip link set lan1 up
- ip link set lan2 up
-
- # create bridge
- ip link add name br0 type bridge
-
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
-
- # add ports to bridges
- ip link set dev wan master br0
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
-
- # tag traffic on ports
- bridge vlan add dev lan1 vid 2 pvid untagged
- bridge vlan del dev lan1 vid 1
- bridge vlan add dev lan2 vid 3 pvid untagged
- bridge vlan del dev lan2 vid 1
-
- # configure the VLANs
- ip addr add 192.0.2.1/30 dev eth0.1
- ip addr add 192.0.2.5/30 dev eth0.2
- ip addr add 192.0.2.9/30 dev eth0.3
-
- # bring up the bridge devices
- ip link set br0 up
-
-
-bridge
-~~~~~~
+Older models (5325, 5365) use a different, legacy tag format, but tagging
+is supported.
-.. code-block:: sh
-
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
-
- # The conduit interface needs to be brought up before the user ports.
- ip link set eth0 up
- ip link set eth0.1 up
-
- # bring up the user interfaces
- ip link set wan up
- ip link set lan1 up
- ip link set lan2 up
-
- # create bridge
- ip link add name br0 type bridge
-
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
-
- # add ports to bridge
- ip link set dev wan master br0
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
- ip link set eth0.1 master br0
-
- # configure the bridge
- ip addr add 192.0.2.129/25 dev br0
-
- # bring up the bridge
- ip link set dev br0 up
-
-gateway
-~~~~~~~
-
-.. code-block:: sh
-
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
- ip link add link eth0 name eth0.2 type vlan id 2
-
- # The conduit interface needs to be brought up before the user ports.
- ip link set eth0 up
- ip link set eth0.1 up
- ip link set eth0.2 up
-
- # bring up the user interfaces
- ip link set wan up
- ip link set lan1 up
- ip link set lan2 up
-
- # create bridge
- ip link add name br0 type bridge
-
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
-
- # add ports to bridges
- ip link set dev wan master br0
- ip link set eth0.1 master br0
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
-
- # tag traffic on ports
- bridge vlan add dev wan vid 2 pvid untagged
- bridge vlan del dev wan vid 1
-
- # configure the VLANs
- ip addr add 192.0.2.1/30 dev eth0.2
- ip addr add 192.0.2.129/25 dev br0
-
- # bring up the bridge devices
- ip link set br0 up
+See :ref:`dsa-tagged-configuration`.
--
2.34.1
next prev parent reply other threads:[~2026-09-22 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 10:35 b53.rst: is the 5325/5365 "no tagging support" section still accurate? Christian Melendez
2026-09-14 14:16 ` Jonas Gorski
2026-09-22 17:48 ` Christian Melendez
2026-09-22 18:25 ` Jonas Gorski
2026-09-22 21:14 ` Christian Melendez [this message]
2026-09-22 21:14 ` [PATCH 2/2] MAINTAINERS: add missing entry for b53.rst Christian Melendez
2026-09-23 21:17 ` [PATCH 1/2] Documentation: dsa: b53: fix stale tagging-support section netdev-bot+sashiko
2026-09-26 0:55 ` Jakub Kicinski
2026-09-29 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922211439.369917-1-chrismelnu@gmail.com \
--to=chrismelnu@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.