From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/usb/typec/hd3ss3220.c:221:37-39: opportunity for str_enable_disable(on)
Date: Fri, 11 Sep 2026 15:42:16 +0200 [thread overview]
Message-ID: <202609111509.BqH8fDQ8-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Xu Rao <raoxu@uniontech.com>
CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 08df884136f1c1197bab2a27814404fd329d9aac
commit: 10ff55ff552b3bf1dadba03fcc430ea205fa2761 usb: typec: hd3ss3220: fix VBUS regulator error message
date: 4 weeks ago
:::::: branch date: 16 hours ago
:::::: commit date: 4 weeks ago
config: i386-randconfig-054-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111509.BqH8fDQ8-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 10ff55ff552b ("usb: typec: hd3ss3220: fix VBUS regulator error message")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202609111509.BqH8fDQ8-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/usb/typec/hd3ss3220.c:221:37-39: opportunity for str_enable_disable(on)
vim +221 drivers/usb/typec/hd3ss3220.c
642b1017dc4371b Heikki Krogerus 2019-11-04 206
27fbc19e52b9a76 Jan Remmet 2026-01-15 207 static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on)
27fbc19e52b9a76 Jan Remmet 2026-01-15 208 {
27fbc19e52b9a76 Jan Remmet 2026-01-15 209 int ret;
27fbc19e52b9a76 Jan Remmet 2026-01-15 210
b3f9d6e491fda73 Jan Remmet 2026-02-06 211 if (regulator_is_enabled(hd3ss3220->vbus) == on)
b3f9d6e491fda73 Jan Remmet 2026-02-06 212 return;
b3f9d6e491fda73 Jan Remmet 2026-02-06 213
27fbc19e52b9a76 Jan Remmet 2026-01-15 214 if (on)
27fbc19e52b9a76 Jan Remmet 2026-01-15 215 ret = regulator_enable(hd3ss3220->vbus);
27fbc19e52b9a76 Jan Remmet 2026-01-15 216 else
27fbc19e52b9a76 Jan Remmet 2026-01-15 217 ret = regulator_disable(hd3ss3220->vbus);
27fbc19e52b9a76 Jan Remmet 2026-01-15 218
27fbc19e52b9a76 Jan Remmet 2026-01-15 219 if (ret)
27fbc19e52b9a76 Jan Remmet 2026-01-15 220 dev_err(hd3ss3220->dev,
10ff55ff552b3bf Xu Rao 2026-08-12 @221 "vbus regulator %s failed: %d\n", on ? "enable" : "disable", ret);
27fbc19e52b9a76 Jan Remmet 2026-01-15 222 }
27fbc19e52b9a76 Jan Remmet 2026-01-15 223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-09-11 13:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609111509.BqH8fDQ8-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.