drivers/usb/typec/hd3ss3220.c:221:37-39: opportunity for str_enable_disable(on)

drivers/usb/typec/hd3ss3220.c:221:37-39: opportunity for str_enable_disable(on)

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Xu Rao <raoxu@uniontech.com>
CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   08df884136f1c1197bab2a27814404fd329d9aac
commit: 10ff55ff552b3bf1dadba03fcc430ea205fa2761 usb: typec: hd3ss3220: fix VBUS regulator error message
date:   4 weeks ago
:::::: branch date: 16 hours ago
:::::: commit date: 4 weeks ago
config: i386-randconfig-054-20260911 (https://download.01.org/0day-ci/archive/20260911/202609111509.BqH8fDQ8-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 10ff55ff552b ("usb: typec: hd3ss3220: fix VBUS regulator error message")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202609111509.BqH8fDQ8-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/usb/typec/hd3ss3220.c:221:37-39: opportunity for str_enable_disable(on)

vim +221 drivers/usb/typec/hd3ss3220.c

642b1017dc4371b Heikki Krogerus 2019-11-04  206  
27fbc19e52b9a76 Jan Remmet      2026-01-15  207  static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on)
27fbc19e52b9a76 Jan Remmet      2026-01-15  208  {
27fbc19e52b9a76 Jan Remmet      2026-01-15  209  	int ret;
27fbc19e52b9a76 Jan Remmet      2026-01-15  210  
b3f9d6e491fda73 Jan Remmet      2026-02-06  211  	if (regulator_is_enabled(hd3ss3220->vbus) == on)
b3f9d6e491fda73 Jan Remmet      2026-02-06  212  		return;
b3f9d6e491fda73 Jan Remmet      2026-02-06  213  
27fbc19e52b9a76 Jan Remmet      2026-01-15  214  	if (on)
27fbc19e52b9a76 Jan Remmet      2026-01-15  215  		ret = regulator_enable(hd3ss3220->vbus);
27fbc19e52b9a76 Jan Remmet      2026-01-15  216  	else
27fbc19e52b9a76 Jan Remmet      2026-01-15  217  		ret = regulator_disable(hd3ss3220->vbus);
27fbc19e52b9a76 Jan Remmet      2026-01-15  218  
27fbc19e52b9a76 Jan Remmet      2026-01-15  219  	if (ret)
27fbc19e52b9a76 Jan Remmet      2026-01-15  220  		dev_err(hd3ss3220->dev,
10ff55ff552b3bf Xu Rao          2026-08-12 @221  			"vbus regulator %s failed: %d\n", on ? "enable" : "disable", ret);
27fbc19e52b9a76 Jan Remmet      2026-01-15  222  }
27fbc19e52b9a76 Jan Remmet      2026-01-15  223  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki