Re: [PATCH 02/58] objtool/klp: Check the klp test environment once, before any test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch regarding 'preflight.sh'
--

commit 61d3f6be171a4f4b4f3dea4ae2f0323ab1631fcd
Author: Song Liu <song@kernel.org>

objtool/klp: Check the klp test environment once, before any test

This commit centralizes the objtool and compiler environment checks for the
klp test suite, running them once upfront rather than in every test. It
aims to fail the entire test suite if the environment is unsuitable,
speeding up runs and avoiding misleading per-test skips.

>     Do it once, before any test, in preflight.sh, and record the answers where
>     the tests can read them.  If the suite cannot run the whole run fails and
>     says why; a test which gets as far as running can assume its environment.
>     
>     The recorded file is required, not optional: a test which cannot tell where
>     objtool is or which architecture it is on should say so rather than guess
>     at an empty value.

[Severity: Medium]
Does the implementation match this description?

The commit message explicitly states that the checks are done in preflight.sh
and that a recorded file is required. However, the patch implements this logic
in a bash function instead, and the state is recorded via exported environment
variables.

> diff --git a/tools/objtool/tests/lib.sh b/tools/objtool/tests/lib.sh
> index 714371232fa30..6e4e54b108659 100644
> --- a/tools/objtool/tests/lib.sh
> +++ b/tools/objtool/tests/lib.sh
[ ... ]
> +# klp_preflight
> +#
> +# Check the environment once, before any test runs, and report what was found.
> +#
> +klp_preflight()
> +{
> +	local tmp tool cc_version host cc_arch

Is this a stale commit message from a previous iteration, or is there a missing
piece of the intended implementation that was supposed to use a file-based
approach?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911185031.1534046-1-song@kernel.org?part=2