From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] arm64: dts: ti: k3-am62a: use ti,am62-mcan compatible for m_can devices
Date: Sat, 12 Sep 2026 21:40:59 +0000 [thread overview]
Message-ID: <20260912214059.ECD961F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912-smth-v3-2-6fa661ae5a4c@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added devicetree compatible string 'ti,am62-mcan' is undocumented in the DT bindings, causing schema validation violations.
--
commit 92a95f8fe8cc6fc6551c41c8019698e288ff900b
Author: Kendall Willis <k-willis@ti.com>
arm64: dts: ti: k3-am62a: use ti,am62-mcan compatible for m_can devices
Prepends the "ti,am62-mcan" compatible to the m_can devices in the
k3-am62a-main and k3-am62a-mcu device trees to support out-of-band wakeup.
This enables the m_can pins to serve as wakeup sources even when power
domains are off during deep low power states.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index 9e5b75a4e88e2..1552029fe4d49 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -848,7 +848,7 @@ mailbox0_cluster3: mailbox@29030000 {
> };
>
> main_mcan0: can@20701000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-mcan", "bosch,m_can";
[Severity: Low]
Does this new compatible string cause schema validation regressions during
dtbs_check? It appears that "ti,am62-mcan" has not been added to the DT
bindings documentation.
> reg = <0x00 0x20701000 0x00 0x200>,
> <0x00 0x20708000 0x00 0x8000>;
[ ... ]
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> index d22caa7c346b3..b9a66e8844341 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> @@ -152,7 +152,7 @@ mcu_rti0: watchdog@4880000 {
> };
>
> mcu_mcan0: can@4e08000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-mcan", "bosch,m_can";
[Severity: Low]
Are we missing a corresponding update to the bosch,m_can.yaml binding file
to document this new string for mcu_mcan0 and mcu_mcan1 as well?
> reg = <0x00 0x4e08000 0x00 0x200>,
> <0x00 0x4e00000 0x00 0x8000>;
> reg-names = "m_can", "message_ram";
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-smth-v3-0-6fa661ae5a4c@ti.com?part=2
next prev parent reply other threads:[~2026-09-12 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 21:32 [PATCH v3 0/3] arm64: dts: ti: use ti,am62-mcan compatible for m_can devices Kendall Willis
2026-09-12 21:32 ` [PATCH v3 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot
2026-09-12 21:32 ` [PATCH v3 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-12 21:40 ` sashiko-bot [this message]
2026-09-12 21:32 ` [PATCH v3 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-12 21:41 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912214059.ECD961F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.