Re: [PATCH v3 3/3] arm64: dts: ti: k3-am62p: use ti,am62-mcan compatible for m_can devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string 'ti,am62-mcan' is not documented or permitted by the corresponding device tree binding schema.
--

commit c9a5bd5e593b159b3d44f9ab0c75ab2dacec0f49
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62p: use ti,am62-mcan compatible for m_can devices

This commit prepends the "ti,am62-mcan" compatible string to the m_can devices
in the device tree for the AM62p. The new compatible string adds out-of-band
wakeup functionality.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index f130c7cb998d7..9e8d9246f6169 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -883,7 +883,7 @@ eqep2: counter@23220000 {
>  	};
>  
>  	main_mcan0: can@20701000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-mcan", "bosch,m_can";

[Severity: Low]
Does this change cause make dtbs_check to fail for the main_mcan0 and
main_mcan1 nodes?

Looking at Documentation/devicetree/bindings/net/can/bosch,m_can.yaml, the
schema expects the compatible property to be exactly the constant string:

  compatible:
    const: bosch,m_can

Without updating the device tree binding schema to permit the new
"ti,am62-mcan" string alongside "bosch,m_can", it appears the schema
validation will reject these nodes.

[ ... ]

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index 5288c959f3c1a..3db8b63ef01fe 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> @@ -154,7 +154,7 @@ mcu_rti0: watchdog@4880000 {
>  	};
>  
>  	mcu_mcan0: can@4e08000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-mcan", "bosch,m_can";

[Severity: Low]
Will this also trigger a dtbs_check validation failure for the mcu_mcan0 and
mcu_mcan1 nodes?

The same schema documentation issue applies here. Is there a missing
prerequisite patch to update the yaml binding?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-smth-v3-0-6fa661ae5a4c@ti.com?part=3