From: Myeonghun Pak <mhun512@gmail.com>
To: stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, krzk@kernel.org,
peter.griffin@linaro.org, alim.akhtar@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH 3/3] usb: ohci-exynos: Disable controller wakeup on removal
Date: Sun, 13 Sep 2026 18:37:32 -0400 [thread overview]
Message-ID: <20260913223732.92882-4-mhun512@gmail.com> (raw)
In-Reply-To: <20260913223732.92882-1-mhun512@gmail.com>
When OHCI reports remote-wakeup capability, a successful wakeup enable
leaves a source attached after driver unbind: usb_remove_hcd() does not
disable controller wakeup.
Disable it after usb_remove_hcd() to balance the enable.
This issue was identified during our ongoing static-analysis research while
reviewing kernel code.
Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver")
Assisted-by: OpenAI:GPT-5.6
Co-developed-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
---
drivers/usb/host/ohci-exynos.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index cc5cb09..86ff7a0 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -194,6 +194,7 @@ static void exynos_ohci_remove(struct platform_device *pdev)
pdev->dev.of_node = exynos_ohci->of_node;
usb_remove_hcd(hcd);
+ device_wakeup_disable(hcd->self.controller);
exynos_ohci_phy_disable(&pdev->dev);
prev parent reply other threads:[~2026-09-13 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 22:37 [PATCH 0/3] usb: host: Disable controller wakeup on removal Myeonghun Pak
2026-09-13 22:37 ` [PATCH 1/3] usb: ehci-platform: " Myeonghun Pak
2026-09-13 22:37 ` [PATCH 2/3] usb: ohci-platform: " Myeonghun Pak
2026-09-13 22:37 ` Myeonghun Pak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913223732.92882-4-mhun512@gmail.com \
--to=mhun512@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.