Re: [Patch v11 07/10] perf regs: Enable dumping of SIMD registers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit `<stdio.h>` inclusion for `printf` usage, which can cause musl build failures.
--

commit a307c3e7165562ef96094cdee1fc722a99865e02
Author: Dapeng Mi <dapeng1.mi@linux.intel.com>

perf regs: Enable dumping of SIMD registers

This commit adds support for dumping SIMD registers with the new
PERF_SAMPLE_REGS_ABI_SIMD ABI. It currently supports XMM, YMM, ZMM,
OPMASK, eGPRs, and SSP registers on x86 platforms.

> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 90d4e45f09f08..a5b596cd14be6 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1446,6 +1446,86 @@ static void regs_dump__printf(u64 mask, struct regs_dump *regs,
>  	}
>  }
>  
> +static void simd_regs_dump__printf(uint16_t e_machine, struct regs_dump *regs, bool intr)
> +{
> +	const char *name = "unknown";
> +	const char *simd_header;
> +	u32 i, j, idx, pred_base;
> +	uint16_t qwords;
> +	int reg_c;
> +
> +	if (!(regs->abi & PERF_SAMPLE_REGS_ABI_SIMD))
> +		return;
> +
> +	if (!regs->nr_vectors && !regs->nr_pred)
> +		return;
> +
> +	simd_header = "... SIMD ABI nr_vectors %" PRIu64 " vector_qwords %" PRIu64 \
> +		      " nr_pred %" PRIu64 "  pred_qwords %" PRIu64 "\n";
> +	printf(simd_header, regs->nr_vectors, regs->vector_qwords,
> +	       regs->nr_pred, regs->pred_qwords);

[Severity: Low]
Does this file need an explicit inclusion of <stdio.h>?

The perf tool can be compiled with musl libc, which enforces strict POSIX
namespace separation and does not implicitly include headers. Relying on
implicit header inclusion for printf() can cause build failures under musl.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914014049.2061519-1-dapeng1.mi@linux.intel.com?part=7