Re: [Patch v11 03/10] tools headers: Sync x86 headers with kernel sources

["Mi, Dapeng" <dapeng1.mi@linux.intel.com>]

On 9/14/2026 9:55 AM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch adds new `ARCH_PEBS_VECR_xxx` macros exclusively to the tools header without a corresponding update to the core kernel header, breaking header synchronization and indicating a missing prerequisite kernel patch.
> --
>
> commit 545cb1e6346c71f64b6106d48dfa9367ed61de8d
> Author: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> tools headers: Sync x86 headers with kernel sources
>
> This commit adds ARCH_PEBS_VECR_xxx macros into the tools version of the
> x86 msr-index.h header. The commit message indicates this is a sync from
> the kernel sources.
>
>> diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h
>> index 18c4be75e9271..9c26d4075c5f4 100644
>> --- a/tools/arch/x86/include/asm/msr-index.h
>> +++ b/tools/arch/x86/include/asm/msr-index.h
>> @@ -350,6 +350,13 @@
>>  #define ARCH_PEBS_LBR_SHIFT		40
>>  #define ARCH_PEBS_LBR			(0x3ull << ARCH_PEBS_LBR_SHIFT)
>>  #define ARCH_PEBS_VECR_XMM		BIT_ULL(49)
>> +#define ARCH_PEBS_VECR_YMMH		BIT_ULL(50)
> [Severity: Medium]
> The commit message mentions syncing newly introduced ARCH_PEBS_VECR_xxx macros
> from the kernel, but is there a missing prerequisite patch?
>
> These macros do not appear to exist in the core kernel's
> arch/x86/include/asm/msr-index.h at this commit.
>
> Will adding them exclusively to the tools header without a corresponding
> kernel update break header synchronization and trigger warnings from
> tools/perf/check-headers.sh when running make -C tools/perf?

The core kernel change is in another independent patch series and already
merged. 

Thanks.


>
>> +#define ARCH_PEBS_VECR_EGPRS		BIT_ULL(51)
>> +#define ARCH_PEBS_VECR_OPMASK		BIT_ULL(53)
>> +#define ARCH_PEBS_VECR_ZMMH		BIT_ULL(54)
>> +#define ARCH_PEBS_VECR_H16ZMM		BIT_ULL(55)
>> +#define ARCH_PEBS_VECR_EXT_SHIFT	49
>> +#define ARCH_PEBS_VECR_EXT		(0x7full << ARCH_PEBS_VECR_EXT_SHIFT)
>>  #define ARCH_PEBS_GPR			BIT_ULL(61)
>>  #define ARCH_PEBS_AUX			BIT_ULL(62)
>>  #define ARCH_PEBS_EN			BIT_ULL(63)