Re: [PATCH 3/4] arm64: dts: qcom: eliza: Add iris video codec node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `video-codec` node is missing the required `iommus` property in its main device node, instead hiding it in unsupported downstream-specific subnodes (`non-pixel` and `pixel`). This prevents the Linux driver core from configuring the IOMMU for the device.
--

commit a274945dd4b8c18268a9d385de4b677773a6b70a
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>

arm64: dts: qcom: eliza: Add iris video codec node

This commit describes the Iris video codec hardware found in the Eliza SoC.
It places the iris node at 0xaa00000 with VPU3.3 capabilities and configures
its clocks, interconnects, memory regions, and resets.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index a8042291bd075..5ebd2aa0a520a 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
[ ... ]
> +		iris: video-codec@aa00000 {
> +			compatible = "qcom,eliza-iris";
> +			reg = <0 0xaa00000 0 0xf0000>;
[ ... ]
> +			dma-coherent;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			dma-ranges = <0x0 0x0 0x0 0xe0000000>;

[Severity: High]
Are these address, size, and DMA ranges properties necessary here? Since the
upstream driver bindings for the video codec do not parse child devices for
these properties, they appear to be unused dead code that will fail dtbs_check
validation.

> +
> +			status = "disabled";
> +
> +			non-pixel {
> +				iommus = <&apps_smmu 0x1940 0x0>;
> +				iommu-ranges = <0x25800000 0xba800000>;
> +			};
> +
> +			pixel {
> +				iommus = <&apps_smmu 0x1947 0x0>;
> +			};

[Severity: High]
Does hiding the iommus property inside these downstream-specific subnodes
prevent the driver core from configuring the IOMMU for the device?

During probe, of_iommu_configure() attempts to set up the IOMMU translation
based on the iommus property in the main device node. Because this property
is omitted from the parent node and hidden in unparsed child nodes, no IOMMU
context is configured, which will lead to fatal SMMU translation faults during
video codec DMA operations.

Will this also trigger dtbs_check validation failures due to undocumented
subnodes missing compatible strings and downstream vendor properties like
iommu-ranges?

> +
> +			iris_opp_table: opp-table {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-add_iris_for_eliza-v1-0-e8ccd9b8cf7a@oss.qualcomm.com?part=3