Re: [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch modifies the YAML schema to strictly require 5-element storage-specific compatible strings for the Eliza CQS EVK, removing the generic 3-element definition. However, it fails to update the corresponding `arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts` file in the same commit, which breaks `make dtbs_check` validation and violates kernel bisectability rules. Although subsequent patches in the series (e.g., commit "arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC") remove the old `.dtb` from the Makefile and create new `.dts` files, they fail to actually delete the original `eliza-cqs-evk.dts` file. This leaves an orphaned, broken file in the source tree that still contains the invalid compatible string and includes a `.dtsi` that no longer exists.
--

commit 4f90c244c9f57e32c917bcd1103262760ccb1acd
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs

This patch documents the eMMC and UFS storage-specific compatible strings for
the Eliza CQS SoMs and EVKs, replacing the generic strings since the boards
are not yet publicly available.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index eddf87fbd0ccc..1dd187e92b680 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -56,7 +56,16 @@ properties:
>            - const: qcom,apq8084
>  
>        - items:
> +          - const: qcom,eliza-cqs-evk-emmc
>            - const: qcom,eliza-cqs-evk
> +          - const: qcom,eliza-cqs-som-emmc
> +          - const: qcom,eliza-cqs-som
> +          - const: qcom,eliza
> +
> +      - items:
> +          - const: qcom,eliza-cqs-evk-ufs
> +          - const: qcom,eliza-cqs-evk
> +          - const: qcom,eliza-cqs-som-ufs
>            - const: qcom,eliza-cqs-som
>            - const: qcom,eliza
>  

[Severity: Low]
Does this change break dtbs_check validation for the existing in-tree
device tree file?

By strictly requiring the 5-element storage-specific compatible strings here
and removing the generic 3-element definition, the existing file
arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts will fail validation until it is
updated:

arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts:
/ {
	model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
	compatible = "qcom,eliza-cqs-evk", "qcom,eliza-cqs-som", "qcom,eliza";
...

While later commits in the series address this by creating new .dts files,
updating the schema without updating the corresponding .dts file in the same
commit breaks bisectability.

Furthermore, the original eliza-cqs-evk.dts file does not appear to be removed
at the end of the series, leaving an orphaned and broken file in the source
tree.

Could the device tree file update be squashed into this commit, or the schema
change delayed until the new device tree files are introduced and the old file
is removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com?part=1