Re: [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit renames `eliza-cqs-som.dtsi` but fails to delete `eliza-cqs-evk.dts`, leaving it as an orphaned file that includes a now-nonexistent file.
--

commit a1174aba52e7db785b4c5053b74679986a1f1e7c
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC

This commit renames the Eliza SoM EVK and Eliza CQS EVK to reflect their
eMMC support and differentiate them from a newly discovered UFS variant.
It updates the Makefile, adds a new EVK dts, and renames the base dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index d6547fb18edf0..ccaca98ad4c8f 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -14,7 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= eliza-cqs-evk.dtb

[Severity: Low]
Does this commit forget to delete the corresponding eliza-cqs-evk.dts file?

While this file is removed from the Makefile build list here, it appears it
wasn't deleted from the repository. Because this patch also renames
eliza-cqs-som.dtsi to eliza-cqs-som-emmc.dtsi, the orphaned eliza-cqs-evk.dts
will fail to parse since it still contains:

#include "eliza-cqs-som.dtsi"

This will break any tool that processes all device tree files in the
directory, such as running make dtbs_check.

As a side note, previous concerns regarding this patch dropping hardware
configurations appear to be unfounded, as those configurations were safely
refactored into eliza-evk.dtsi in a preceding patch (commit "arm64: dts:
qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic"). However,
the forgotten deletion of the obsolete file remains an issue.

> +dtb-$(CONFIG_ARCH_QCOM)	+= eliza-cqs-evk-emmc.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com?part=3