* [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
2026-09-14 10:44 [PATCH 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts Abel Vesa
@ 2026-09-14 10:44 ` Abel Vesa
2026-09-14 10:57 ` sashiko-bot
2026-09-15 10:59 ` Krzysztof Kozlowski
2026-09-14 10:44 ` [PATCH 2/5] arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic Abel Vesa
` (3 subsequent siblings)
4 siblings, 2 replies; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 10:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
There are currently two different Eliza CQS SoMs. One comes with eMMC
and the other with UFS. So the Eliza CQS EVK can be connected to each
one of these SoMs.
So document the eMMC and UFS compatibles for each type of board and SoM.
Neither the CQS SoMs nor their corresponding EVKs have been made publicly
available. Therefore, replacing the generic compatible strings with
storage-specific ones does not affect any user.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index eddf87fbd0cc..1dd187e92b68 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -56,7 +56,16 @@ properties:
- const: qcom,apq8084
- items:
+ - const: qcom,eliza-cqs-evk-emmc
- const: qcom,eliza-cqs-evk
+ - const: qcom,eliza-cqs-som-emmc
+ - const: qcom,eliza-cqs-som
+ - const: qcom,eliza
+
+ - items:
+ - const: qcom,eliza-cqs-evk-ufs
+ - const: qcom,eliza-cqs-evk
+ - const: qcom,eliza-cqs-som-ufs
- const: qcom,eliza-cqs-som
- const: qcom,eliza
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
2026-09-14 10:44 ` [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs Abel Vesa
@ 2026-09-14 10:57 ` sashiko-bot
2026-09-15 10:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-09-14 10:57 UTC (permalink / raw)
To: Abel Vesa; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch modifies the YAML schema to strictly require 5-element storage-specific compatible strings for the Eliza CQS EVK, removing the generic 3-element definition. However, it fails to update the corresponding `arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts` file in the same commit, which breaks `make dtbs_check` validation and violates kernel bisectability rules. Although subsequent patches in the series (e.g., commit "arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC") remove the old `.dtb` from the Makefile and create new `.dts` files, they fail to actually delete the original `eliza-cqs-evk.dts` file. This leaves an orphaned, broken file in the source tree that still contains the invalid compatible string and includes a `.dtsi` that no longer exists.
--
commit 4f90c244c9f57e32c917bcd1103262760ccb1acd
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
This patch documents the eMMC and UFS storage-specific compatible strings for
the Eliza CQS SoMs and EVKs, replacing the generic strings since the boards
are not yet publicly available.
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index eddf87fbd0ccc..1dd187e92b680 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -56,7 +56,16 @@ properties:
> - const: qcom,apq8084
>
> - items:
> + - const: qcom,eliza-cqs-evk-emmc
> - const: qcom,eliza-cqs-evk
> + - const: qcom,eliza-cqs-som-emmc
> + - const: qcom,eliza-cqs-som
> + - const: qcom,eliza
> +
> + - items:
> + - const: qcom,eliza-cqs-evk-ufs
> + - const: qcom,eliza-cqs-evk
> + - const: qcom,eliza-cqs-som-ufs
> - const: qcom,eliza-cqs-som
> - const: qcom,eliza
>
[Severity: Low]
Does this change break dtbs_check validation for the existing in-tree
device tree file?
By strictly requiring the 5-element storage-specific compatible strings here
and removing the generic 3-element definition, the existing file
arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts will fail validation until it is
updated:
arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts:
/ {
model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
compatible = "qcom,eliza-cqs-evk", "qcom,eliza-cqs-som", "qcom,eliza";
...
While later commits in the series address this by creating new .dts files,
updating the schema without updating the corresponding .dts file in the same
commit breaks bisectability.
Furthermore, the original eliza-cqs-evk.dts file does not appear to be removed
at the end of the series, leaving an orphaned and broken file in the source
tree.
Could the device tree file update be squashed into this commit, or the schema
change delayed until the new device tree files are introduced and the old file
is removed?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
2026-09-14 10:44 ` [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs Abel Vesa
2026-09-14 10:57 ` sashiko-bot
@ 2026-09-15 10:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-15 10:59 UTC (permalink / raw)
To: Abel Vesa
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Mon, Sep 14, 2026 at 01:44:48PM +0300, Abel Vesa wrote:
> There are currently two different Eliza CQS SoMs. One comes with eMMC
> and the other with UFS. So the Eliza CQS EVK can be connected to each
> one of these SoMs.
>
> So document the eMMC and UFS compatibles for each type of board and SoM.
>
> Neither the CQS SoMs nor their corresponding EVKs have been made publicly
> available. Therefore, replacing the generic compatible strings with
> storage-specific ones does not affect any user.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic
2026-09-14 10:44 [PATCH 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts Abel Vesa
2026-09-14 10:44 ` [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs Abel Vesa
@ 2026-09-14 10:44 ` Abel Vesa
2026-09-14 10:44 ` [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC Abel Vesa
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 10:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
The sound card support is the same across all variants of the Eliza
EVK. That means we can reuse it even for Eliza CQM EVK later.
So move the sound related nodes from Eliza CQS EVK to Eliza EVK generic
implementation.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts | 141 -----------------------------
arch/arm64/boot/dts/qcom/eliza-evk.dtsi | 139 ++++++++++++++++++++++++++++
2 files changed, 139 insertions(+), 141 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
index 5e4175291f05..43d428a4ed2d 100644
--- a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
@@ -5,151 +5,10 @@
/dts-v1/;
-#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
-
#include "eliza-cqs-som.dtsi"
#include "eliza-evk.dtsi"
/ {
model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
compatible = "qcom,eliza-cqs-evk", "qcom,eliza-cqs-som", "qcom,eliza";
-
- sound {
- compatible = "qcom,eliza-sndcard", "qcom,sm8450-sndcard";
- model = "eliza-cqs-evk";
-
- audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
- "SpkrRight IN", "WSA_SPK2 OUT",
- "VA DMIC0", "vdd-micb",
- "VA DMIC1", "vdd-micb",
- "VA DMIC2", "vdd-micb",
- "VA DMIC3", "vdd-micb",
- "VA DMIC4", "vdd-micb",
- "VA DMIC5", "vdd-micb",
- "VA DMIC6", "vdd-micb",
- "VA DMIC7", "vdd-micb";
-
- va-dai-link {
- link-name = "VA Capture";
-
- codec {
- sound-dai = <&lpass_vamacro 0>;
- };
-
- cpu {
- sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
- };
-
- platform {
- sound-dai = <&q6apm>;
- };
- };
-
- wsa-dai-link {
- link-name = "WSA Playback";
-
- codec {
- sound-dai = <&left_spkr>, <&right_spkr>,
- <&swr0 0>, <&lpass_wsamacro 0>;
- };
-
- cpu {
- sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
- };
-
- platform {
- sound-dai = <&q6apm>;
- };
- };
- };
-
- dmic_eldo: regulator-dmic-eldo {
- compatible = "regulator-fixed";
- regulator-name = "dmic-eldo";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- gpio = <&pm7550_gpios 8 GPIO_ACTIVE_HIGH>;
- enable-active-high;
- vin-supply = <&vreg_bob>;
- };
-};
-
-&lpass_vamacro {
- pinctrl-0 = <&dmic01_default>, <&dmic23_default>,
- <&dmic45_default>, <&dmic67_default>;
- pinctrl-names = "default";
-
- vdd-micb-supply = <&dmic_eldo>;
- qcom,dmic-sample-rate = <4800000>;
-};
-
-&swr0 {
- pinctrl-0 = <&wsa_swr_active>;
- pinctrl-names = "default";
-
- status = "okay";
-
- /* WSA8845, Speaker Left */
- left_spkr: speaker@0,0 {
- compatible = "sdw20217020400";
- reg = <0 0>;
- pinctrl-0 = <&spkr_1_sd_n_active>;
- pinctrl-names = "default";
- powerdown-gpios = <&tlmm 59 GPIO_ACTIVE_LOW>;
- vdd-1p8-supply = <&vreg_l7b>;
- vdd-io-supply = <&vreg_l7b>;
-
- #sound-dai-cells = <0>;
- sound-name-prefix = "SpkrLeft";
-
- /*
- * WSA8845 Port 1 (DAC) <=> SWR0 Port 1 (SPKR_L)
- * WSA8845 Port 2 (COMP) <=> SWR0 Port 2 (SPKR_L_COMP)
- * WSA8845 Port 3 (BOOST) <=> SWR0 Port 3 (SPKR_L_BOOST)
- * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR)
- * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 10 (SPKR_L_VI)
- * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS)
- */
- qcom,port-mapping = <1 2 3 7 10 13>;
- };
-
- /* WSA8845, Speaker Right */
- right_spkr: speaker@0,1 {
- compatible = "sdw20217020400";
- reg = <0 1>;
- pinctrl-0 = <&spkr_2_sd_n_active>;
- pinctrl-names = "default";
- powerdown-gpios = <&tlmm 79 GPIO_ACTIVE_LOW>;
- vdd-1p8-supply = <&vreg_l7b>;
- vdd-io-supply = <&vreg_l7b>;
-
- #sound-dai-cells = <0>;
- sound-name-prefix = "SpkrRight";
-
- /*
- * WSA8845 Port 1 (DAC) <=> SWR0 Port 4 (SPKR_R)
- * WSA8845 Port 2 (COMP) <=> SWR0 Port 5 (SPKR_R_COMP)
- * WSA8845 Port 3 (BOOST) <=> SWR0 Port 6 (SPKR_R_BOOST)
- * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR)
- * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 11 (SPKR_R_VI)
- * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS)
- */
- qcom,port-mapping = <4 5 6 7 11 13>;
- };
-};
-
-&tlmm {
- spkr_1_sd_n_active: spkr-1-sd-n-active-state {
- pins = "gpio59";
- function = "gpio";
- drive-strength = <16>;
- bias-disable;
- };
-
- spkr_2_sd_n_active: spkr-2-sd-n-active-state {
- pins = "gpio79";
- function = "gpio";
- drive-strength = <16>;
- bias-disable;
- };
};
diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
index 6c5cc47a183e..726fd8dd6c0d 100644
--- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
@@ -3,6 +3,8 @@
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+
/ {
aliases {
serial0 = &uart13;
@@ -63,6 +65,55 @@ pmic_glink_ss_in: endpoint {
};
};
+ sound {
+ compatible = "qcom,eliza-sndcard", "qcom,sm8450-sndcard";
+ model = "eliza-cqs-evk";
+
+ audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+ "SpkrRight IN", "WSA_SPK2 OUT",
+ "VA DMIC0", "vdd-micb",
+ "VA DMIC1", "vdd-micb",
+ "VA DMIC2", "vdd-micb",
+ "VA DMIC3", "vdd-micb",
+ "VA DMIC4", "vdd-micb",
+ "VA DMIC5", "vdd-micb",
+ "VA DMIC6", "vdd-micb",
+ "VA DMIC7", "vdd-micb";
+
+ va-dai-link {
+ link-name = "VA Capture";
+
+ codec {
+ sound-dai = <&lpass_vamacro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ wsa-dai-link {
+ link-name = "WSA Playback";
+
+ codec {
+ sound-dai = <&left_spkr>, <&right_spkr>,
+ <&swr0 0>, <&lpass_wsamacro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+ };
+
vreg_0p9: regulator-0v9 {
compatible = "regulator-fixed";
regulator-name = "VREG_0P9";
@@ -94,6 +145,16 @@ vreg_pcie_m_3p3: regulator-3p3 {
enable-active-high;
};
+ dmic_eldo: regulator-dmic-eldo {
+ compatible = "regulator-fixed";
+ regulator-name = "dmic-eldo";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ gpio = <&pm7550_gpios 8 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <&vreg_bob>;
+ };
+
connector-0 {
compatible = "pcie-m2-e-connector";
vpcie3v3-supply = <&vreg_pcie_m_3p3>;
@@ -148,6 +209,15 @@ gpio_expander1: gpio@3c {
};
};
+&lpass_vamacro {
+ pinctrl-0 = <&dmic01_default>, <&dmic23_default>,
+ <&dmic45_default>, <&dmic67_default>;
+ pinctrl-names = "default";
+
+ vdd-micb-supply = <&dmic_eldo>;
+ qcom,dmic-sample-rate = <4800000>;
+};
+
&pcie0 {
status = "okay";
};
@@ -197,12 +267,81 @@ &sdhc_2 {
status = "okay";
};
+&swr0 {
+ pinctrl-0 = <&wsa_swr_active>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ /* WSA8845, Speaker Left */
+ left_spkr: speaker@0,0 {
+ compatible = "sdw20217020400";
+ reg = <0 0>;
+ pinctrl-0 = <&spkr_1_sd_n_active>;
+ pinctrl-names = "default";
+ powerdown-gpios = <&tlmm 59 GPIO_ACTIVE_LOW>;
+ vdd-1p8-supply = <&vreg_l7b>;
+ vdd-io-supply = <&vreg_l7b>;
+
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrLeft";
+
+ /*
+ * WSA8845 Port 1 (DAC) <=> SWR0 Port 1 (SPKR_L)
+ * WSA8845 Port 2 (COMP) <=> SWR0 Port 2 (SPKR_L_COMP)
+ * WSA8845 Port 3 (BOOST) <=> SWR0 Port 3 (SPKR_L_BOOST)
+ * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR)
+ * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 10 (SPKR_L_VI)
+ * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS)
+ */
+ qcom,port-mapping = <1 2 3 7 10 13>;
+ };
+
+ /* WSA8845, Speaker Right */
+ right_spkr: speaker@0,1 {
+ compatible = "sdw20217020400";
+ reg = <0 1>;
+ pinctrl-0 = <&spkr_2_sd_n_active>;
+ pinctrl-names = "default";
+ powerdown-gpios = <&tlmm 79 GPIO_ACTIVE_LOW>;
+ vdd-1p8-supply = <&vreg_l7b>;
+ vdd-io-supply = <&vreg_l7b>;
+
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrRight";
+
+ /*
+ * WSA8845 Port 1 (DAC) <=> SWR0 Port 4 (SPKR_R)
+ * WSA8845 Port 2 (COMP) <=> SWR0 Port 5 (SPKR_R_COMP)
+ * WSA8845 Port 3 (BOOST) <=> SWR0 Port 6 (SPKR_R_BOOST)
+ * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR)
+ * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 11 (SPKR_R_VI)
+ * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS)
+ */
+ qcom,port-mapping = <4 5 6 7 11 13>;
+ };
+};
+
&tlmm {
sd_cd: sd-cd-state {
pins = "gpio58";
function = "gpio";
bias-pull-up;
};
+
+ spkr_1_sd_n_active: spkr-1-sd-n-active-state {
+ pins = "gpio59";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-disable;
+ };
+
+ spkr_2_sd_n_active: spkr-2-sd-n-active-state {
+ pins = "gpio79";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-disable;
+ };
};
&pcie1 {
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
2026-09-14 10:44 [PATCH 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts Abel Vesa
2026-09-14 10:44 ` [PATCH 1/5] dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs Abel Vesa
2026-09-14 10:44 ` [PATCH 2/5] arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic Abel Vesa
@ 2026-09-14 10:44 ` Abel Vesa
2026-09-14 10:52 ` sashiko-bot
2026-09-14 10:44 ` [PATCH 4/5] arm64: dts: qcom: eliza: Add CQS SoM UFS variant Abel Vesa
2026-09-14 10:44 ` [PATCH 5/5] arm64: dts: qcom: eliza: Add CQS EVK " Abel Vesa
4 siblings, 1 reply; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 10:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
It turns out that there is a variant of the Eliza SoM EVK that comes
with UFS instead of eMMC.
So let's rename the current Eliza SoM EVK to suggest that it supports eMMC,
and then rename the Eliza CQS EVK to suggest it is also eMMC based.
Also update the compatible for the Eliza CQS EVK to include the eMMC
string, in order to differentiate from UFS variant.
Neither the CQS SoM nor the CQS EVK has been made publicly available, so
renaming the DTB will not affect any users.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 +-
arch/arm64/boot/dts/qcom/eliza-cqs-evk-emmc.dts | 18 ++++++++++++++++++
.../{eliza-cqs-som.dtsi => eliza-cqs-som-emmc.dtsi} | 0
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index d6547fb18edf..ccaca98ad4c8 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -14,7 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096sg-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
-dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk.dtb
+dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk-emmc.dtb
dtb-$(CONFIG_ARCH_QCOM) += eliza-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += glymur-asus-zenbook-a16-ux3607oa.dtb
dtb-$(CONFIG_ARCH_QCOM) += glymur-crd.dtb
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk-emmc.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk-emmc.dts
new file mode 100644
index 000000000000..36f63dd1637f
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk-emmc.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "eliza-cqs-som-emmc.dtsi"
+#include "eliza-evk.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. Eliza CQS EVK (eMMC)";
+ compatible = "qcom,eliza-cqs-evk-emmc",
+ "qcom,eliza-cqs-evk",
+ "qcom,eliza-cqs-som-emmc",
+ "qcom,eliza-cqs-som",
+ "qcom,eliza";
+};
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som-emmc.dtsi
similarity index 100%
rename from arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
rename to arch/arm64/boot/dts/qcom/eliza-cqs-som-emmc.dtsi
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
2026-09-14 10:44 ` [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC Abel Vesa
@ 2026-09-14 10:52 ` sashiko-bot
2026-09-14 11:41 ` Abel Vesa
0 siblings, 1 reply; 10+ messages in thread
From: sashiko-bot @ 2026-09-14 10:52 UTC (permalink / raw)
To: Abel Vesa; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit renames `eliza-cqs-som.dtsi` but fails to delete `eliza-cqs-evk.dts`, leaving it as an orphaned file that includes a now-nonexistent file.
--
commit a1174aba52e7db785b4c5053b74679986a1f1e7c
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
This commit renames the Eliza SoM EVK and Eliza CQS EVK to reflect their
eMMC support and differentiate them from a newly discovered UFS variant.
It updates the Makefile, adds a new EVK dts, and renames the base dtsi.
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index d6547fb18edf0..ccaca98ad4c8f 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -14,7 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
> dtb-$(CONFIG_ARCH_QCOM) += apq8096sg-db820c.dtb
> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk.dtb
[Severity: Low]
Does this commit forget to delete the corresponding eliza-cqs-evk.dts file?
While this file is removed from the Makefile build list here, it appears it
wasn't deleted from the repository. Because this patch also renames
eliza-cqs-som.dtsi to eliza-cqs-som-emmc.dtsi, the orphaned eliza-cqs-evk.dts
will fail to parse since it still contains:
#include "eliza-cqs-som.dtsi"
This will break any tool that processes all device tree files in the
directory, such as running make dtbs_check.
As a side note, previous concerns regarding this patch dropping hardware
configurations appear to be unfounded, as those configurations were safely
refactored into eliza-evk.dtsi in a preceding patch (commit "arm64: dts:
qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic"). However,
the forgotten deletion of the obsolete file remains an issue.
> +dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk-emmc.dtb
> dtb-$(CONFIG_ARCH_QCOM) += eliza-mtp.dtb
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
2026-09-14 10:52 ` sashiko-bot
@ 2026-09-14 11:41 ` Abel Vesa
0 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 11:41 UTC (permalink / raw)
To: sashiko-reviews; +Cc: robh, conor+dt, devicetree
On 26-09-14 10:52:43, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The commit renames `eliza-cqs-som.dtsi` but fails to delete `eliza-cqs-evk.dts`, leaving it as an orphaned file that includes a now-nonexistent file.
> --
>
> commit a1174aba52e7db785b4c5053b74679986a1f1e7c
> Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
>
> arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
>
> This commit renames the Eliza SoM EVK and Eliza CQS EVK to reflect their
> eMMC support and differentiate them from a newly discovered UFS variant.
> It updates the Makefile, adds a new EVK dts, and renames the base dtsi.
>
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index d6547fb18edf0..ccaca98ad4c8f 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -14,7 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += apq8096sg-db820c.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
> > -dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk.dtb
>
> [Severity: Low]
> Does this commit forget to delete the corresponding eliza-cqs-evk.dts file?
>
> While this file is removed from the Makefile build list here, it appears it
> wasn't deleted from the repository. Because this patch also renames
> eliza-cqs-som.dtsi to eliza-cqs-som-emmc.dtsi, the orphaned eliza-cqs-evk.dts
> will fail to parse since it still contains:
>
> #include "eliza-cqs-som.dtsi"
>
> This will break any tool that processes all device tree files in the
> directory, such as running make dtbs_check.
>
> As a side note, previous concerns regarding this patch dropping hardware
> configurations appear to be unfounded, as those configurations were safely
> refactored into eliza-evk.dtsi in a preceding patch (commit "arm64: dts:
> qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic"). However,
> the forgotten deletion of the obsolete file remains an issue.
Yep. Will remove in v2.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/5] arm64: dts: qcom: eliza: Add CQS SoM UFS variant
2026-09-14 10:44 [PATCH 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts Abel Vesa
` (2 preceding siblings ...)
2026-09-14 10:44 ` [PATCH 3/5] arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC Abel Vesa
@ 2026-09-14 10:44 ` Abel Vesa
2026-09-14 10:44 ` [PATCH 5/5] arm64: dts: qcom: eliza: Add CQS EVK " Abel Vesa
4 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 10:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
Add a new dtsi for the Eliza CQS SoM UFS variant.
This SoM only comes with UFS installed.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-cqs-som-ufs.dtsi | 421 ++++++++++++++++++++++++
1 file changed, 421 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som-ufs.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som-ufs.dtsi
new file mode 100644
index 000000000000..cf1cd97065b4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som-ufs.dtsi
@@ -0,0 +1,421 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+#include "eliza.dtsi"
+#include "pm7550ba-eliza.dtsi"
+#include "pm7550-eliza.dtsi"
+#include "pm8550vs-d-eliza.dtsi"
+#include "pm8550vs-g-eliza.dtsi"
+#include "pmr735d-eliza.dtsi"
+#include "pmk8550-eliza.dtsi"
+
+/ {
+ clocks {
+ xo_board: xo-board {
+ compatible = "fixed-clock";
+ clock-frequency = <76800000>;
+ #clock-cells = <0>;
+ };
+
+ sleep_clk: sleep-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <32764>;
+ #clock-cells = <0>;
+ };
+
+ bi_tcxo_div2: bi-tcxo-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+
+ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK_A>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+ };
+
+ vph_pwr: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+
+ regulator-name = "vph_pwr";
+ regulator-min-microvolt = <3700000>;
+ regulator-max-microvolt = <3700000>;
+
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&apps_rsc {
+ regulators-0 {
+ compatible = "qcom,pm7550-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s3b>;
+ vdd-l2-l3-supply = <&vreg_s3b>;
+ vdd-l4-l5-supply = <&vreg_s2b>;
+ vdd-l6-supply = <&vreg_s2b>;
+ vdd-l7-supply = <&vreg_s1b>;
+ vdd-l8-supply = <&vreg_s1b>;
+ vdd-l9-l10-supply = <&vreg_s1b>;
+ vdd-l11-supply = <&vreg_s1b>;
+ vdd-l12-l14-supply = <&vreg_bob>;
+ vdd-l13-l16-supply = <&vreg_bob>;
+ vdd-l15-l17-l18-l19-l20-l21-l22-l23-supply = <&vreg_bob>;
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+ vdd-s4-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s6-supply = <&vph_pwr>;
+
+ vdd-bob-supply = <&vph_pwr>;
+
+ qcom,pmic-id = "b";
+
+ vreg_s1b: smps1 {
+ regulator-name = "vreg_s1b";
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <2040000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s2b: smps2 {
+ regulator-name = "vreg_s2b";
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <2744000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s3b: smps3 {
+ regulator-name = "vreg_s3b";
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <2744000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_s4b: smps4 {
+ regulator-name = "vreg_s4b";
+ regulator-min-microvolt = <2156000>;
+ regulator-max-microvolt = <2400000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2b: ldo2 {
+ regulator-name = "vreg_l2b";
+ regulator-min-microvolt = <720000>;
+ regulator-max-microvolt = <950000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3b: ldo3 {
+ regulator-name = "vreg_l3b";
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <912000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l4b: ldo4 {
+ regulator-name = "vreg_l4b";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l6b: ldo6 {
+ regulator-name = "vreg_l6b";
+ regulator-min-microvolt = <866000>;
+ regulator-max-microvolt = <958000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7b: ldo7 {
+ regulator-name = "vreg_l7b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l8b: ldo8 {
+ regulator-name = "vreg_l8b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l9b: ldo9 {
+ regulator-name = "vreg_l9b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l10b: ldo10 {
+ regulator-name = "vreg_l10b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l11b: ldo11 {
+ regulator-name = "vreg_l11b";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l12b: ldo12 {
+ regulator-name = "vreg_l12b";
+ regulator-min-microvolt = <2400000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l13b: ldo13 {
+ regulator-name = "vreg_l13b";
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l14b: ldo14 {
+ regulator-name = "vreg_l14b";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l15b: ldo15 {
+ regulator-name = "vreg_l15b";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l16b: ldo16 {
+ regulator-name = "vreg_l16b";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3008000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l17b: ldo17 {
+ regulator-name = "vreg_l17b";
+ regulator-min-microvolt = <3104000>;
+ regulator-max-microvolt = <3104000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l18b: ldo18 {
+ regulator-name = "vreg_l18b";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l19b: ldo19 {
+ regulator-name = "vreg_l19b";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l20b: ldo20 {
+ regulator-name = "vreg_l20b";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l21b: ldo21 {
+ regulator-name = "vreg_l21b";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l22b: ldo22 {
+ regulator-name = "vreg_l22b";
+ regulator-min-microvolt = <3200000>;
+ regulator-max-microvolt = <3200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l23b: ldo23 {
+ regulator-name = "vreg_l23b";
+ regulator-min-microvolt = <1650000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_bob: bob {
+ regulator-name = "vreg_bob";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3960000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-1 {
+ compatible = "qcom,pm8550vs-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s1b>;
+
+ qcom,pmic-id = "d";
+
+ vreg_l1d: ldo1 {
+ regulator-name = "vreg_l1d";
+ regulator-min-microvolt = <1140000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-2 {
+ compatible = "qcom,pm8550vs-rpmh-regulators";
+
+ vdd-l1-supply = <&vreg_s2b>;
+ vdd-l3-supply = <&vreg_s2b>;
+
+ qcom,pmic-id = "g";
+
+ vreg_l1g: ldo1 {
+ regulator-name = "vreg_l1g";
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3g: ldo3 {
+ regulator-name = "vreg_l3g";
+ regulator-min-microvolt = <1150000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ };
+
+ regulators-3 {
+ compatible = "qcom,pmr735d-rpmh-regulators";
+
+ vdd-l1-l2-l5-supply = <&vreg_s3b>;
+ vdd-l3-l4-supply = <&vreg_s2b>;
+ vdd-l6-supply = <&vreg_s1b>;
+ vdd-l7-supply = <&vreg_s3b>;
+
+ qcom,pmic-id = "k";
+
+ vreg_l1k: ldo1 {
+ regulator-name = "vreg_l1k";
+ regulator-min-microvolt = <488000>;
+ regulator-max-microvolt = <912000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2k: ldo2 {
+ regulator-name = "vreg_l2k";
+ regulator-min-microvolt = <920000>;
+ regulator-max-microvolt = <969000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l3k: ldo3 {
+ regulator-name = "vreg_l3k";
+ regulator-min-microvolt = <1080000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l4k: ldo4 {
+ regulator-name = "vreg_l4k";
+ regulator-min-microvolt = <960000>;
+ regulator-max-microvolt = <1980000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l5k: ldo5 {
+ regulator-name = "vreg_l5k";
+ regulator-min-microvolt = <866000>;
+ regulator-max-microvolt = <931000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l6k: ldo6 {
+ regulator-name = "vreg_l6k";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7k: ldo7 {
+ regulator-name = "vreg_l7k";
+ regulator-min-microvolt = <720000>;
+ regulator-max-microvolt = <958000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+};
+
+&pm7550ba_eusb2_repeater {
+ vdd18-supply = <&vreg_l7b>;
+ vdd3-supply = <&vreg_l17b>;
+};
+
+&gpu {
+ status = "okay";
+};
+
+&gpu_zap_shader {
+ firmware-name = "qcom/eliza/gen71700_zap.mbn";
+};
+
+&remoteproc_adsp {
+ firmware-name = "qcom/eliza/adsp.mbn",
+ "qcom/eliza/adsp_dtb.mbn";
+
+ status = "okay";
+};
+
+&remoteproc_cdsp {
+ firmware-name = "qcom/eliza/cdsp.mbn",
+ "qcom/eliza/cdsp_dtb.mbn";
+
+ status = "okay";
+};
+
+&tlmm {
+ gpio-reserved-ranges = <20 4>, /* NFC SPI */
+ <111 2>, /* WCN UART1 */
+ <118 1>; /* NFC Secure I/O */
+};
+
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
+
+ vcc-supply = <&vreg_l12b>;
+ vcc-max-microamp = <1300000>;
+ vccq-supply = <&vreg_l1d>;
+ vccq-max-microamp = <1200000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vreg_l6b>;
+ vdda-pll-supply = <&vreg_l4b>;
+
+ status = "okay";
+};
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/5] arm64: dts: qcom: eliza: Add CQS EVK UFS variant
2026-09-14 10:44 [PATCH 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts Abel Vesa
` (3 preceding siblings ...)
2026-09-14 10:44 ` [PATCH 4/5] arm64: dts: qcom: eliza: Add CQS SoM UFS variant Abel Vesa
@ 2026-09-14 10:44 ` Abel Vesa
4 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-09-14 10:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa
Add new board dts for the Eliza CQS EVK that uses the UFS SoM.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/eliza-cqs-evk-ufs.dts | 18 ++++++++++++++++++
2 files changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index ccaca98ad4c8..f44d7ec94216 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096sg-db820c.dtb
dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk-emmc.dtb
+dtb-$(CONFIG_ARCH_QCOM) += eliza-cqs-evk-ufs.dtb
dtb-$(CONFIG_ARCH_QCOM) += eliza-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += glymur-asus-zenbook-a16-ux3607oa.dtb
dtb-$(CONFIG_ARCH_QCOM) += glymur-crd.dtb
diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk-ufs.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk-ufs.dts
new file mode 100644
index 000000000000..f5bdb2526429
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk-ufs.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "eliza-cqs-som-ufs.dtsi"
+#include "eliza-evk.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
+ compatible = "qcom,eliza-cqs-evk-ufs",
+ "qcom,eliza-cqs-evk",
+ "qcom,eliza-cqs-som-ufs",
+ "qcom,eliza-cqs-som",
+ "qcom,eliza";
+};
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread