* [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment
@ 2026-09-13 14:54 Im7CK
2026-09-15 1:37 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Im7CK @ 2026-09-13 14:54 UTC (permalink / raw)
To: linux-kbuild; +Cc: Nathan Chancellor, nsc, linux-kernel
Fixed grammar in the comment describing the generation of the output
Makefile and .gitignore file.
Signed-off-by: Mebecool1 <computergod47@gmail.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 66654fa71..13236b460 100644
--- a/Makefile
+++ b/Makefile
@@ -681,8 +681,8 @@ ifdef building_out_of_srctree
# outputmakefile generates a Makefile in the output directory, if using a
# separate output directory. This allows convenient use of make in the
# output directory.
-# At the same time when output Makefile generated, generate .gitignore to
-# ignore whole output directory
+# At the same time as the output Makefile is generated, generate .gitignore to
+# ignore the whole output directory.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment
2026-09-13 14:54 [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment Im7CK
@ 2026-09-15 1:37 ` Nathan Chancellor
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2026-09-15 1:37 UTC (permalink / raw)
To: Im7CK; +Cc: linux-kbuild, nsc, linux-kernel
Hi,
On Sun, Sep 13, 2026 at 08:24:32PM +0530, Im7CK wrote:
> Fixed grammar in the comment describing the generation of the output
> Makefile and .gitignore file.
>
> Signed-off-by: Mebecool1 <computergod47@gmail.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 66654fa71..13236b460 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -681,8 +681,8 @@ ifdef building_out_of_srctree
> # outputmakefile generates a Makefile in the output directory, if using a
> # separate output directory. This allows convenient use of make in the
> # output directory.
> -# At the same time when output Makefile generated, generate .gitignore to
> -# ignore whole output directory
> +# At the same time as the output Makefile is generated, generate .gitignore to
> +# ignore the whole output directory.
>
Your email client mangled this patch, it cannot be applied. Please read
https://docs.kernel.org/process/email-clients.html
for some information on clients and git send-email or consider using
https://b4.docs.kernel.org/en/latest/contributor/overview.html
to use 'b4 prep' and 'b4 send' to properly handle some of that in a more
user-friendly manner. An example of that workflow (use the kbuild tree
as the base though: https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git/):
https://github.com/ClangBuiltLinux/linux/issues/2093#issuecomment-2932754317
Additionally, you need to signoff your patch with a proper name, as
neither Im7CK or Mebecool1 are a "known identity" per
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
--
Cheers,
Nathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment
@ 2026-09-15 6:26 Aayansh Ranjan
2026-09-16 6:54 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Aayansh Ranjan @ 2026-09-15 6:26 UTC (permalink / raw)
To: nathan, nsc; +Cc: linux-kbuild, linux-kernel, Aayansh Ranjan
Fix the grammar in the comment describing the generation of the
output Makefile .gitignore file.
Signed-off-by: Aayansh Ranjan <computergod47@gmail.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 4ad67b737..ffc8732c7 100644
--- a/Makefile
+++ b/Makefile
@@ -681,8 +681,8 @@ ifdef building_out_of_srctree
# outputmakefile generates a Makefile in the output directory, if using a
# separate output directory. This allows convenient use of make in the
# output directory.
-# At the same time when output Makefile generated, generate .gitignore to
-# ignore whole output directory
+# At the same time as when output Makefile is generated, generate .gitignore to
+# ignore the whole output directory
ifdef KBUILD_EXTMOD
print_env_for_makefile = \
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment
2026-09-15 6:26 Aayansh Ranjan
@ 2026-09-16 6:54 ` Nathan Chancellor
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2026-09-16 6:54 UTC (permalink / raw)
To: nsc, Aayansh Ranjan; +Cc: linux-kbuild, linux-kernel
On Tue, 15 Sep 2026 11:56:13 +0530, Aayansh Ranjan wrote:
> kbuild: fix grammar in output Makefile .gitignore generation comment
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git kbuild-next-unstable
Thanks!
[1/1] kbuild: fix grammar in output Makefile .gitignore generation comment
https://git.kernel.org/kbuild/c/322b0463f30b0
I adjusted "when" to "the" in the comment to make it flow a little
better.
Please look out for regression or issue reports or other follow up
comments, as they may result in the patch/series getting dropped or
reverted. Patches applied to an "unstable" branch are accepted pending
wider testing in -next and any post-commit review; they will generally
be moved to the main branch in a week if no issues are found.
Best regards,
--
Cheers,
Nathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-16 6:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-13 14:54 [PATCH] kbuild: fix grammar in output Makefile .gitignore generation comment Im7CK
2026-09-15 1:37 ` Nathan Chancellor
-- strict thread matches above, loose matches on Subject: below --
2026-09-15 6:26 Aayansh Ranjan
2026-09-16 6:54 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.