From: Ethan Nelson-Moore <enelsonmoore@gmail.com>
To: "Jakub Kicinski" <kuba@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Michael Grzeschik" <mgr@kernel.org>,
"Denis Benato" <benato.denis96@gmail.com>,
netdev@vger.kernel.org
Cc: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jijie Shao <shaojijie@huawei.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: [PATCH] net: fealnx: remove never-true 486 CPU check
Date: Mon, 14 Sep 2026 19:46:33 -0700 [thread overview]
Message-ID: <20260915024638.198865-1-enelsonmoore@gmail.com> (raw)
The fealnx driver contains a check for boot_cpu_data.x86 <= 4.
This field encodes the x86 generation (3 = 386, 4 = 486, etc).
Therefore, since 486 support was removed from the kernel in commit
8b793a92d862 ("x86/cpu: Remove M486/M486SX/ELAN support"), the
condition is always true. Remove the check.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/ethernet/fealnx.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
index bdc38aac5850..708b61f21915 100644
--- a/drivers/net/ethernet/fealnx.c
+++ b/drivers/net/ethernet/fealnx.c
@@ -839,8 +839,7 @@ static int netdev_open(struct net_device *dev)
/* Initialize other registers. */
/* Configure the PCI bus bursts and FIFO thresholds.
- 486: Set 8 longword burst.
- 586: no burst limit.
+ No burst limit.
Burst length 5:3
0 0 0 1
0 0 1 4
@@ -858,13 +857,7 @@ static int netdev_open(struct net_device *dev)
#ifdef __BIG_ENDIAN
np->bcrvalue |= 0x04; /* big-endian */
#endif
-
-#if defined(__i386__) && !defined(MODULE) && !defined(CONFIG_UML)
- if (boot_cpu_data.x86 <= 4)
- np->crvalue = 0xa00;
- else
-#endif
- np->crvalue = 0xe00; /* rx 128 burst length */
+ np->crvalue = 0xe00; /* rx 128 burst length */
// 89/12/29 add,
--
2.43.0
next reply other threads:[~2026-09-15 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:46 Ethan Nelson-Moore [this message]
2026-09-15 3:36 ` [PATCH] net: fealnx: remove never-true 486 CPU check Ethan Nelson-Moore
2026-09-15 22:51 ` Jakub Kicinski
2026-09-15 5:42 ` Loktionov, Aleksandr
2026-09-16 5:48 ` netdev-bot+sashiko
2026-09-17 2:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915024638.198865-1-enelsonmoore@gmail.com \
--to=enelsonmoore@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=arend.vanspriel@broadcom.com \
--cc=benato.denis96@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=mgr@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaojijie@huawei.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.