Re: [PATCH] net: fealnx: remove never-true 486 CPU check

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 16 Sep 2026 05:48:28 +0000 netdev-bot+sashiko@kernel.org wrote:
> > -#if defined(__i386__) && !defined(MODULE) && !defined(CONFIG_UML)
> > -	if (boot_cpu_data.x86 <= 4)
> > -		np->crvalue = 0xa00;
> > -	else
> > -#endif
> > -		np->crvalue = 0xe00;	/* rx 128 burst length */
> > +	np->crvalue = 0xe00;	/* rx 128 burst length */  
> 
> [Severity: Low]
> This removes the last user of asm/processor.h in the file, but the include and
> its justification comment near the top of drivers/net/ethernet/fealnx.c are
> left behind:
> 
> 	#include <asm/processor.h>	/* Processor type for cache alignment. */
> 
> After this patch, git grep boot_cpu_data on the file returns nothing, and a
> grep for other plausible users (cpu_relax, cpu_data, cache_line*) also finds
> nothing.  Should the include be dropped together with its only user?

Massaging the comment is more a judgment call (the other Low complaint
from AI) but the header we should probably remove..