All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Pei <cp0613@linux.alibaba.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment
Date: Tue, 15 Sep 2026 20:48:27 +0800	[thread overview]
Message-ID: <20260915124000.0000001-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <20260915122946.1953137-1-thomas.petazzoni@bootlin.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 926 bytes --]

Hi Thomas,

Thanks for the fixes. Both patches look good to me.

For the series:

Reviewed-by: Chen Pei <cp0613@linux.alibaba.com>

> On 15 Sep 2026, at 20:29, Thomas Petazzoni via buildroot
> <buildroot@buildroot.org> wrote:
>
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> ndctl selects kmod and keyutils, both of which depend on
> !BR2_STATIC_LIBS, but this dependency was not propagated into ndctl
> when the package was introduced. This commit fixes this issue.
>
> Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new package")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

I've confirmed that both kmod and keyutils carry `depends on
!BR2_STATIC_LIBS`, so the propagation is indeed necessary. The fix is
correct — the `|| BR2_STATIC_LIBS` in the comment's depends block is
the right way to express "show this comment when static libs are
enabled".

Best regards,
Chen

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-09-15 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 12:29 [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Thomas Petazzoni via buildroot
2026-09-15 12:29 ` [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency Thomas Petazzoni via buildroot
2026-09-25 14:45   ` Raphaël Mélotte via buildroot
2026-09-15 12:48 ` Chen Pei [this message]
2026-09-15 17:33 ` [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Julien Olivain via buildroot
2026-09-25 14:45 ` Raphaël Mélotte via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915124000.0000001-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.