* [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency
2026-09-15 12:29 [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Thomas Petazzoni via buildroot
@ 2026-09-15 12:29 ` Thomas Petazzoni via buildroot
2026-09-25 14:45 ` Raphaël Mélotte via buildroot
2026-09-15 12:48 ` [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Chen Pei
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-09-15 12:29 UTC (permalink / raw)
To: buildroot; +Cc: Thomas Petazzoni, Chen Pei
ndctl selects kmod and keyutils, both of which depend on
!BR2_STATIC_LIBS, but this dependency was not propagated into ndctl
when the package was introduced. This commit fixes this issue.
Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new package")
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/ndctl/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/ndctl/Config.in b/package/ndctl/Config.in
index 708871d693..79bae61ebb 100644
--- a/package/ndctl/Config.in
+++ b/package/ndctl/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_NDCTL
depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU
+ depends on !BR2_STATIC_LIBS # kmod, keyutils
select BR2_PACKAGE_INIPARSER
select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_KEYUTILS
@@ -19,9 +20,10 @@ config BR2_PACKAGE_NDCTL
https://github.com/pmem/ndctl
-comment "ndctl needs udev /dev management, a toolchain w/ threads, headers >= 5.10"
+comment "ndctl needs udev /dev management, a toolchain w/ threads, headers >= 5.10, dynamic library"
depends on BR2_USE_MMU
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_PACKAGE_HAS_UDEV \
|| !BR2_TOOLCHAIN_HAS_THREADS \
- || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_10
+ || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_10 \
+ || BR2_STATIC_LIBS
--
2.55.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency
2026-09-15 12:29 ` [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency Thomas Petazzoni via buildroot
@ 2026-09-25 14:45 ` Raphaël Mélotte via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Raphaël Mélotte via buildroot @ 2026-09-25 14:45 UTC (permalink / raw)
To: buildroot, Thomas Petazzoni; +Cc: Raphaël Mélotte
In reply of:
> ndctl selects kmod and keyutils, both of which depend on
> !BR2_STATIC_LIBS, but this dependency was not propagated into ndctl
> when the package was introduced. This commit fixes this issue.
>
> Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new package")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to 2026.08.x. Thanks
> ---
> package/ndctl/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/ndctl/Config.in b/package/ndctl/Config.in
> index 708871d693..79bae61ebb 100644
> --- a/package/ndctl/Config.in
> +++ b/package/ndctl/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_NDCTL
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU
> + depends on !BR2_STATIC_LIBS # kmod, keyutils
> select BR2_PACKAGE_INIPARSER
> select BR2_PACKAGE_JSON_C
> select BR2_PACKAGE_KEYUTILS
> @@ -19,9 +20,10 @@ config BR2_PACKAGE_NDCTL
>
> https://github.com/pmem/ndctl
>
> -comment "ndctl needs udev /dev management, a toolchain w/ threads, headers >= 5.10"
> +comment "ndctl needs udev /dev management, a toolchain w/ threads, headers >= 5.10, dynamic library"
> depends on BR2_USE_MMU
> depends on BR2_TOOLCHAIN_HAS_SYNC_4
> depends on !BR2_PACKAGE_HAS_UDEV \
> || !BR2_TOOLCHAIN_HAS_THREADS \
> - || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_10
> + || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_10 \
> + || BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment
2026-09-15 12:29 [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Thomas Petazzoni via buildroot
2026-09-15 12:29 ` [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency Thomas Petazzoni via buildroot
@ 2026-09-15 12:48 ` Chen Pei
2026-09-15 17:33 ` Julien Olivain via buildroot
2026-09-25 14:45 ` Raphaël Mélotte via buildroot
3 siblings, 0 replies; 6+ messages in thread
From: Chen Pei @ 2026-09-15 12:48 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 926 bytes --]
Hi Thomas,
Thanks for the fixes. Both patches look good to me.
For the series:
Reviewed-by: Chen Pei <cp0613@linux.alibaba.com>
> On 15 Sep 2026, at 20:29, Thomas Petazzoni via buildroot
> <buildroot@buildroot.org> wrote:
>
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> ndctl selects kmod and keyutils, both of which depend on
> !BR2_STATIC_LIBS, but this dependency was not propagated into ndctl
> when the package was introduced. This commit fixes this issue.
>
> Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new package")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
I've confirmed that both kmod and keyutils carry `depends on
!BR2_STATIC_LIBS`, so the propagation is indeed necessary. The fix is
correct — the `|| BR2_STATIC_LIBS` in the comment's depends block is
the right way to express "show this comment when static libs are
enabled".
Best regards,
Chen
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment
2026-09-15 12:29 [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Thomas Petazzoni via buildroot
2026-09-15 12:29 ` [Buildroot] [PATCH 2/2] package/ndctl: propagate !BR2_STATIC_LIBS dependency Thomas Petazzoni via buildroot
2026-09-15 12:48 ` [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Chen Pei
@ 2026-09-15 17:33 ` Julien Olivain via buildroot
2026-09-25 14:45 ` Raphaël Mélotte via buildroot
3 siblings, 0 replies; 6+ messages in thread
From: Julien Olivain via buildroot @ 2026-09-15 17:33 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot, Chen Pei
On 15/09/2026 14:29, Thomas Petazzoni via buildroot wrote:
> The Config.in comment has the correct dependency on
> !BR2_TOOLCHAIN_HAS_THREADS, but that was not reflected in the comment
> text itself.
>
> Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new
> package")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment
2026-09-15 12:29 [Buildroot] [PATCH 1/2] package/ndctl: fix Config.in comment Thomas Petazzoni via buildroot
` (2 preceding siblings ...)
2026-09-15 17:33 ` Julien Olivain via buildroot
@ 2026-09-25 14:45 ` Raphaël Mélotte via buildroot
3 siblings, 0 replies; 6+ messages in thread
From: Raphaël Mélotte via buildroot @ 2026-09-25 14:45 UTC (permalink / raw)
To: buildroot, Thomas Petazzoni; +Cc: Raphaël Mélotte
In reply of:
> The Config.in comment has the correct dependency on
> !BR2_TOOLCHAIN_HAS_THREADS, but that was not reflected in the comment
> text itself.
>
> Fixes: 039c1ae13ec12f7cebddf86f37080d0a1fee28e6 ("package/ndctl: new package")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to 2026.08.x. Thanks
> ---
> package/ndctl/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/ndctl/Config.in b/package/ndctl/Config.in
> index 9d3972bd2f..708871d693 100644
> --- a/package/ndctl/Config.in
> +++ b/package/ndctl/Config.in
> @@ -19,7 +19,7 @@ config BR2_PACKAGE_NDCTL
>
> https://github.com/pmem/ndctl
>
> -comment "ndctl needs udev /dev management, a toolchain headers >= 5.10"
> +comment "ndctl needs udev /dev management, a toolchain w/ threads, headers >= 5.10"
> depends on BR2_USE_MMU
> depends on BR2_TOOLCHAIN_HAS_SYNC_4
> depends on !BR2_PACKAGE_HAS_UDEV \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread