Re: [PATCH 7/8] Docs/admin-guide/mm/damon/usage: update for hugepage_size

[SJ Park <sj@kernel.org>]

On Tue, 15 Sep 2026 14:39:48 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] doc: grammatical error in damon usage documentation
> --
> 
> commit f587d7d9920741b1ef2aaf02c04d27dcea002f5e
> Author: SJ Park <sj@kernel.org>
> 
> Docs/admin-guide/mm/damon/usage: update for hugepage_size
> 
> Update DAMON usage document for the newly added hugepage_size data
> attribute filter type.
> 
> > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
> > index d3e37400367bd..6b80bce5d678d 100644
> > --- a/Documentation/admin-guide/mm/damon/usage.rst
> > +++ b/Documentation/admin-guide/mm/damon/usage.rst
> 
> [ ... ]
> 
> > @@ -308,6 +308,8 @@ Writing a number (``N``) to the file creates the number of child directories
> >  named ``0`` to ``N-1``.  Each directory represents each filter and works in a
> >  way similar to that for :ref:`DAMOS filter <sysfs_filters>`.  When the filter
> >  ``type`` is ``memcg``, ``path`` file acts as ``memcg_path`` for :ref:`DAMOS
> > +filter <sysfs_filters>`.  When the filter ``type`` is ``hugepage_size``,
> > +``min`` and ``max`` files acts as files of the same names for :ref:`DAMOS
> 
> [Severity: Low]
> This isn't a bug, but should "acts" be "act" here since "files" is plural?

Good catch.  It is too trivial to respin the series in my humble opinion.  I
will fix this later unless others do that in near future.

> 
> >  filter <sysfs_filters>`.
> >  
> >  .. _sysfs_targets:
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260915143359.91472-1-sj@kernel.org?part=7
> 


Thanks,
SJ