All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SJ Park <sj@kernel.org>, "Liam R. Howlett" <liam@infradead.org>,
	David Hildenbrand <david@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	damon@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/8] mm/damon: introduce hugepage_size probe filter
Date: Tue, 15 Sep 2026 22:57:10 -0700	[thread overview]
Message-ID: <20260916055711.24926-1-sj@kernel.org> (raw)
In-Reply-To: <20260915163928.9d6260f445d895429d115fd8@linux-foundation.org>

Hi Andrew,

On Tue, 15 Sep 2026 16:39:28 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 15 Sep 2026 07:33:49 -0700 SJ Park <sj@kernel.org> wrote:
> 
> > Knowing whether a given memory is backed by a hugepage of specific size
> > is useful for efficient utilization of hugepages.  For easy monitoring
> > of the information, introduce a new data attribute probe filter type,
> > hugepage_size.  It works similar to the DAMOS filter of the same name.
> > It works for memory that is backed by a hugepage of a given size range.
> > 
> > Patch 1 introduces the new probe filter type to DAMON API and extends
> > related data structures.  Patch 2 updates probe filter commit logic to
> > handle the size range.  Patch 3 Updates the filtering logic to support
> > the new type.  Patch 4 adds new DAMON sysfs files for the size range.
> > Patch 5 updates DAMON sysfs interface to fully support the new filter
> > type.  Patches 6-8 updates design, usage and ABI documents for the new
> > feature.
> 
> All queued up, thanks.  With a -fix for [7/8].

Thank you!  I found the -fix is in the mm.git as below:

'''
$ git show 81c69fbb4128
[...]
--- a/Documentation/admin-guide/mm/damon/usage.rst
+++ b/Documentation/admin-guide/mm/damon/usage.rst
@@ -309,7 +309,7 @@ named ``0`` to ``N-1``.  Each directory represents each filter and works in a
 way similar to that for :ref:`DAMOS filter <sysfs_filters>`.  When the filter
 ``type`` is ``memcg``, ``path`` file acts as ``memcg_path`` for :ref:`DAMOS
 filter <sysfs_filters>`.  When the filter ``type`` is ``hugepage_size``,
-``min`` and ``max`` files acts as files of the same names for :ref:`DAMOS
+``min`` and ``max`` file acts as files of the same names for :ref:`DAMOS
 filter <sysfs_filters>`.

 .. _sysfs_targets:
'''

But, I think it is slightly wrong.  The fix I requested is
's/files acts/files act/', but the committed fix is doing
's/files acts/file acts/'.  Could you please fix it when you get a chance?  Let
me know if there is anything that I can help, too.


Thanks,
SJ

[...]


      parent reply	other threads:[~2026-09-16  5:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 14:33 [PATCH 0/8] mm/damon: introduce hugepage_size probe filter SJ Park
2026-09-15 14:33 ` [PATCH 1/8] mm/damon/api: introduce DAMON_FILTER_TYPE_HUGEPAGE_SIZE SJ Park
2026-09-15 14:43   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 2/8] mm/damon/core: commit hugepage_size type damon filter SJ Park
2026-09-15 14:44   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 3/8] mm/damon/ops-common: support hugepage_size damon filter matching SJ Park
2026-09-15 14:47   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 4/8] mm/damon/sysfs: add min,max files under probe filter directory SJ Park
2026-09-15 14:42   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 5/8] mm/damon/sysfs: support hugepage_size probe filter SJ Park
2026-09-15 14:44   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 6/8] Docs/mm/damon/design: update for " SJ Park
2026-09-15 14:36   ` sashiko-bot
2026-09-15 14:33 ` [PATCH 7/8] Docs/admin-guide/mm/damon/usage: update for hugepage_size SJ Park
2026-09-15 14:39   ` sashiko-bot
2026-09-15 14:53     ` SJ Park
2026-09-15 15:01   ` SJ Park
2026-09-15 14:33 ` [PATCH 8/8] Docs/ABI/damon: update for hugepage_size probe filter SJ Park
2026-09-15 14:41   ` sashiko-bot
2026-09-15 14:58 ` [PATCH 0/8] mm/damon: introduce " SJ Park
2026-09-15 23:39 ` Andrew Morton
2026-09-15 23:49   ` SJ Park
2026-09-16  5:57   ` SJ Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916055711.24926-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.