From: Rosen Penev <rosenp@gmail.com>
To: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] dmaengine: bestcomm: drop unneeded sram exports
Date: Tue, 15 Sep 2026 11:09:19 -0700 [thread overview]
Message-ID: <20260915180919.8899-1-rosenp@gmail.com> (raw)
bcom_sram_init(), bcom_sram_cleanup(), bcom_sram_alloc() and
bcom_sram_free() are only called from bestcomm.c, which is part of
the same bestcomm-core module as sram.c. Remove the now-pointless
EXPORT_SYMBOL_GPL() statements; the functions stay non-static because
they cross compilation units within the module. bcom_sram itself
remains exported for the inline helpers in sram.h.
Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/bestcomm/sram.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/dma/bestcomm/sram.c b/drivers/dma/bestcomm/sram.c
index 09ef5142c26c..d33e0f931682 100644
--- a/drivers/dma/bestcomm/sram.c
+++ b/drivers/dma/bestcomm/sram.c
@@ -119,7 +119,6 @@ int bcom_sram_init(struct device_node *sram_node, char *owner)
return rv;
}
-EXPORT_SYMBOL_GPL(bcom_sram_init);
void bcom_sram_cleanup(void)
{
@@ -132,7 +131,6 @@ void bcom_sram_cleanup(void)
bcom_sram = NULL;
}
}
-EXPORT_SYMBOL_GPL(bcom_sram_cleanup);
void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
{
@@ -148,7 +146,6 @@ void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
*phys = bcom_sram->base_phys + offset;
return bcom_sram->base_virt + offset;
}
-EXPORT_SYMBOL_GPL(bcom_sram_alloc);
void bcom_sram_free(void *ptr)
{
@@ -163,4 +160,3 @@ void bcom_sram_free(void *ptr)
rh_free(bcom_sram->rh, offset);
spin_unlock(&bcom_sram->lock);
}
-EXPORT_SYMBOL_GPL(bcom_sram_free);
--
2.55.0
next reply other threads:[~2026-09-15 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 18:09 Rosen Penev [this message]
2026-10-13 20:41 ` [PATCH] dmaengine: bestcomm: drop unneeded sram exports Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915180919.8899-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.