[PATCH] dmaengine: bestcomm: drop unneeded sram exports

[PATCH] dmaengine: bestcomm: drop unneeded sram exports

[Rosen Penev]

bcom_sram_init(), bcom_sram_cleanup(), bcom_sram_alloc() and
bcom_sram_free() are only called from bestcomm.c, which is part of
the same bestcomm-core module as sram.c.  Remove the now-pointless
EXPORT_SYMBOL_GPL() statements; the functions stay non-static because
they cross compilation units within the module.  bcom_sram itself
remains exported for the inline helpers in sram.h.

Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/dma/bestcomm/sram.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/bestcomm/sram.c b/drivers/dma/bestcomm/sram.c
index 09ef5142c26c..d33e0f931682 100644
--- a/drivers/dma/bestcomm/sram.c
+++ b/drivers/dma/bestcomm/sram.c
@@ -119,7 +119,6 @@ int bcom_sram_init(struct device_node *sram_node, char *owner)
 
 	return rv;
 }
-EXPORT_SYMBOL_GPL(bcom_sram_init);
 
 void bcom_sram_cleanup(void)
 {
@@ -132,7 +131,6 @@ void bcom_sram_cleanup(void)
 		bcom_sram = NULL;
 	}
 }
-EXPORT_SYMBOL_GPL(bcom_sram_cleanup);
 
 void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
 {
@@ -148,7 +146,6 @@ void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
 	*phys = bcom_sram->base_phys + offset;
 	return bcom_sram->base_virt + offset;
 }
-EXPORT_SYMBOL_GPL(bcom_sram_alloc);
 
 void bcom_sram_free(void *ptr)
 {
@@ -163,4 +160,3 @@ void bcom_sram_free(void *ptr)
 	rh_free(bcom_sram->rh, offset);
 	spin_unlock(&bcom_sram->lock);
 }
-EXPORT_SYMBOL_GPL(bcom_sram_free);
-- 
2.55.0

Re: [PATCH] dmaengine: bestcomm: drop unneeded sram exports

[Frank Li]

On Tue, Sep 15, 2026 at 11:09:19AM -0700, Rosen Penev wrote:
> bcom_sram_init(), bcom_sram_cleanup(), bcom_sram_alloc() and
> bcom_sram_free() are only called from bestcomm.c, which is part of
> the same bestcomm-core module as sram.c.  Remove the now-pointless
> EXPORT_SYMBOL_GPL() statements; the functions stay non-static because
> they cross compilation units within the module.  bcom_sram itself
> remains exported for the inline helpers in sram.h.
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/bestcomm/sram.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/sram.c b/drivers/dma/bestcomm/sram.c
> index 09ef5142c26c..d33e0f931682 100644
> --- a/drivers/dma/bestcomm/sram.c
> +++ b/drivers/dma/bestcomm/sram.c
> @@ -119,7 +119,6 @@ int bcom_sram_init(struct device_node *sram_node, char *owner)
>
>  	return rv;
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_init);
>
>  void bcom_sram_cleanup(void)
>  {
> @@ -132,7 +131,6 @@ void bcom_sram_cleanup(void)
>  		bcom_sram = NULL;
>  	}
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_cleanup);
>
>  void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
>  {
> @@ -148,7 +146,6 @@ void* bcom_sram_alloc(int size, int align, phys_addr_t *phys)
>  	*phys = bcom_sram->base_phys + offset;
>  	return bcom_sram->base_virt + offset;
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_alloc);
>
>  void bcom_sram_free(void *ptr)
>  {
> @@ -163,4 +160,3 @@ void bcom_sram_free(void *ptr)
>  	rh_free(bcom_sram->rh, offset);
>  	spin_unlock(&bcom_sram->lock);
>  }
> -EXPORT_SYMBOL_GPL(bcom_sram_free);
> --
> 2.55.0
>