Re: [PATCH v2 1/2] dt-bindings: display: ti,tpd12s015: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation regression for tpd12s015 gpios maxItems constraint
--

commit cd852360cf92f4482c02f981e6fec97ded13c090
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: display: ti,tpd12s015: Convert to DT schema

Converts the TPD12S015 HDMI level shifter binding to DT schema and restricts
the gpios property to three entries based on the assumption that no in-tree
board uses more than three.

> diff --git a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
> new file mode 100644
> index 0000000000000..96b44bd665f1f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml

[ ... ]

> +  gpios:
> +    description:
> +      The CT CP HPD, LS OE and HPD GPIOs, in that order. The first controls
> +      the level shifter, the second enables the level shifter outputs and
> +      the third reads the hot-plug detect line.
> +    minItems: 3
> +    maxItems: 3

[Severity: Medium]
The commit message claims that no in-tree board passes more than three GPIOs,
but does this maxItems limit cause a dtbs_check validation regression for
existing boards?

Looking at arch/arm/boot/dts/ti/omap/omap5-igep0050.dts, it appears to define
5 items for its tpd12s015 node:

&tpd12s015 {
	gpios = <&tca6416 11 0>,	/* TCA6416 P01, CT_CP_HDP */
		<&tca6416 12 0>,	/* TCA6416 P00, LS_OE*/
		<&gpio7 1 0>,		/* 193, HPD */
		<&gpio7 2 0>,		/* 194, SCL */
		<&gpio7 3 0>;		/* 195, SDA */
};

Should the schema accommodate all 5 pins, or does the omap5-igep0050.dts board
file need to be updated first before enforcing this constraint?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915120327.47114-1-quchaosheng000406@163.com?part=1