All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaosheng Qu <quchaosheng000406@163.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh@kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Eduard Bostina <egbostina@gmail.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: Convert to DT schema
Date: Wed, 30 Sep 2026 15:40:10 +0800 (CST)	[thread overview]
Message-ID: <6ABCBCD9.079C08.00008@m16.mail.163.com> (raw)
In-Reply-To: <20260930052925.GA931211@killaraus.ideasonboard.com>

Hi Laurent,

You are right, and the two extra entries should not be in the binding.

Both drivers take exactly three GPIOs:

  drivers/gpu/drm/bridge/ti-tpd12s015.c:150,157,164
  drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:237,246,255

They ask for indices 0, 1 and 2 -- CT_CP_HPD, LS_OE and HPD.  Nothing reads
index 3 or 4, and neither file mentions scl, sda or ddc.

The text binding I replaced said the same thing:

  - gpios: CT CP HPD, LS OE and HPD gpios

omap5-igep0050.dts passes two more, and there is no pinctrl group for them
and nothing in-tree consumes them.  v3 raised maxItems to five only so that
dtbs_check would keep passing for that board.  That was the wrong direction:
it wrote a defect of the DT source into the binding instead of holding the
binding to what the hardware and the driver use.

So it splits the way you pointed at earlier:

  - the conversion keeps gpios at three entries, which is what the driver
    requires, and
  - a separate patch drops the two extra entries from omap5-igep0050.dts.

My earlier question still stands: would you rather have that as a v4 from
me, or should I leave it to Eduard's series?

Thanks,
Chaosheng Qu


  reply	other threads:[~2026-09-30  7:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 12:03 [PATCH 1/2] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-09-16  1:58 ` [PATCH v2 " Quchaosheng
2026-09-16  1:58   ` [PATCH v2 1/2] dt-bindings: display: ti, tpd12s015: " Quchaosheng
2026-09-16  1:58   ` [PATCH v2 2/2] ARM: dts: ti/omap: drop unit-address from tpd12s015 endpoints Quchaosheng
2026-09-16  2:07   ` [PATCH v2 1/2] dt-bindings: display: ti,tpd12s015: Convert to DT schema sashiko-bot
2026-09-16 12:32   ` [PATCH v3 " Quchaosheng
2026-09-16 12:32     ` [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: " Quchaosheng
2026-09-16 12:32     ` [PATCH v3 2/2] ARM: dts: ti/omap: drop unit-address from tpd12s015 endpoints Quchaosheng
2026-09-28  9:46       ` Quchaosheng
2026-09-23  2:30     ` [PATCH v3 1/2] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-09-23  2:30       ` [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: " Quchaosheng
2026-09-24 21:53     ` [PATCH v3 1/2] dt-bindings: display: ti,tpd12s015: " Rob Herring (Arm)
2026-09-24 21:53       ` [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: " Rob Herring (Arm)
2026-09-30  5:29       ` Laurent Pinchart
2026-09-30  7:40         ` Chaosheng Qu [this message]
2026-09-29 12:12 ` [PATCH 1/2] dt-bindings: display: ti,tpd12s015: " Laurent Pinchart
2026-09-30  2:24   ` Chaosheng Qu
2026-09-30  2:24     ` [PATCH 1/2] dt-bindings: display: ti, tpd12s015: " Chaosheng Qu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ABCBCD9.079C08.00008@m16.mail.163.com \
    --to=quchaosheng000406@163.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=egbostina@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.