[broonie-ci:asoc-7.4 5/23] sound/soc/codecs/es9356.c:1124:12: warning: suggest explicit braces to avoid ambiguous 'else'

[broonie-ci:asoc-7.4 5/23] sound/soc/codecs/es9356.c:1124:12: warning: suggest explicit braces to avoid ambiguous 'else'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git asoc-7.4
head:   323637a0aa19e59490a4449f2ab149d97fc5272d
commit: 31a7178425356d459bf7397941a3fbeff1782122 [5/23] ASoC: es9356: Publish IRQ readiness after cache replay
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260916/202609160652.5njTpCaF-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260916/202609160652.5njTpCaF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609160652.5njTpCaF-lkp@intel.com/

All warnings (new ones prefixed by >>):

   sound/soc/codecs/es9356.c: In function 'es9356_sdca_dev_resume':
>> sound/soc/codecs/es9356.c:1124:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
    1124 |         if (!slave->unattach_request)
         |            ^


vim +/else +1124 sound/soc/codecs/es9356.c

  1103	
  1104	static int es9356_sdca_dev_resume(struct device *dev)
  1105	{
  1106		struct sdw_slave *slave = dev_to_sdw_dev(dev);
  1107		struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev);
  1108		int ret;
  1109	
  1110		ret = sdw_slave_wait_for_init(slave, es9356_PROBE_TIMEOUT);
  1111		if (ret) {
  1112			sdw_show_ping_status(slave->bus, true);
  1113			return ret;
  1114		}
  1115	
  1116		regcache_cache_only(es9356->regmap, false);
  1117		ret = regcache_sync(es9356->regmap);
  1118		if (ret) {
  1119			regcache_cache_only(es9356->regmap, true);
  1120			regcache_mark_dirty(es9356->regmap);
  1121			return ret;
  1122		}
  1123	
> 1124		if (!slave->unattach_request)
  1125			scoped_guard(mutex, &es9356->disable_irq_lock)
  1126				es9356->disable_irq = false;
  1127		return 0;
  1128	}
  1129	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki