All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: linux-i3c@lists.infradead.org, robh@kernel.org,
	Frank.Li@kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v19 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
Date: Wed, 16 Sep 2026 07:15:17 +0000	[thread overview]
Message-ID: <20260916071517.A5E7B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916070728.1088801-4-lakshay.piplani@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing compatible in the required properties list
--

commit 99e5e0734a8e4028d9b6a9430b09604b1fe931b7
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>

dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

This commit adds device tree bindings for the NXP P3H2x4x multiport I3C
hub family. These devices connect to a host via I3C/I2C/SMBus and allow
communication with multiple downstream peripherals.

> diff --git a/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
> new file mode 100644
> index 0000000000000..09508a7bcbeb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
[ ... ]
> +      ldo-tpg1:
> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml#
> +        unevaluatedProperties: false
> +
> +required:
> +  - reg
> +  - '#address-cells'
> +  - '#size-cells'

[Severity: Low]
Does this list incorrectly omit the compatible property?

Device tree nodes referenced directly via a schema $ref might incorrectly
pass validation if they omit the compatible property, as the schema does
not enforce its presence. If a parent schema uses $ref to include this
schema for a child node, and the child node lacks a compatible string,
validation would silently succeed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916070728.1088801-1-lakshay.piplani@nxp.com?part=3

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: linux-i3c@lists.infradead.org, robh@kernel.org,
	Frank.Li@kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v19 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
Date: Wed, 16 Sep 2026 07:15:17 +0000	[thread overview]
Message-ID: <20260916071517.A5E7B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916070728.1088801-4-lakshay.piplani@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing compatible in the required properties list
--

commit 99e5e0734a8e4028d9b6a9430b09604b1fe931b7
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>

dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

This commit adds device tree bindings for the NXP P3H2x4x multiport I3C
hub family. These devices connect to a host via I3C/I2C/SMBus and allow
communication with multiple downstream peripherals.

> diff --git a/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
> new file mode 100644
> index 0000000000000..09508a7bcbeb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
[ ... ]
> +      ldo-tpg1:
> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml#
> +        unevaluatedProperties: false
> +
> +required:
> +  - reg
> +  - '#address-cells'
> +  - '#size-cells'

[Severity: Low]
Does this list incorrectly omit the compatible property?

Device tree nodes referenced directly via a schema $ref might incorrectly
pass validation if they omit the compatible property, as the schema does
not enforce its presence. If a parent schema uses $ref to include this
schema for a child node, and the child node lacks a compatible string,
validation would silently succeed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916070728.1088801-1-lakshay.piplani@nxp.com?part=3

  reply	other threads:[~2026-09-16  7:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:07 [PATCH v19 0/8] Add support for NXP P3H2x4x I3C hub driver Lakshay Piplani
2026-09-16  7:07 ` Lakshay Piplani
2026-09-16  7:07 ` [PATCH v19 1/8] i3c: master: Add APIs for I3C hub support Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:07 ` [PATCH v19 2/8] i3c: master: Add controller-only device operation helpers Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:07 ` [PATCH v19 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:15   ` sashiko-bot [this message]
2026-09-16  7:15     ` sashiko-bot
2026-09-16  7:07 ` [PATCH v19 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:19   ` sashiko-bot
2026-09-16  7:19     ` sashiko-bot
2026-09-16  7:07 ` [PATCH v19 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:17   ` sashiko-bot
2026-09-16  7:17     ` sashiko-bot
2026-09-16  7:07 ` [PATCH v19 6/8] i3c: hub: Add support for the I3C interface in the I3C hub Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:21   ` sashiko-bot
2026-09-16  7:21     ` sashiko-bot
2026-09-21 21:15   ` Alexandre Belloni
2026-09-21 21:15     ` Alexandre Belloni
2026-09-16  7:07 ` [PATCH v19 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:22   ` sashiko-bot
2026-09-16  7:22     ` sashiko-bot
2026-09-16  7:07 ` [PATCH v19 8/8] i3c: hub: p3h2x4x: Add SMBus slave mode support Lakshay Piplani
2026-09-16  7:07   ` Lakshay Piplani
2026-09-16  7:25   ` sashiko-bot
2026-09-16  7:25     ` sashiko-bot
2026-09-22  7:26 ` [PATCH v19 0/8] Add support for NXP P3H2x4x I3C hub driver Lee Jones
2026-09-22  7:26   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916071517.A5E7B1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lakshay.piplani@nxp.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.