* Re: [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm [not found] <20260916090705.2796356-1-paul.elder@ideasonboard.com> @ 2026-09-16 16:43 ` Laurent Pinchart 2026-09-16 18:34 ` Fiona Klute via buildroot 0 siblings, 1 reply; 3+ messages in thread From: Laurent Pinchart @ 2026-09-16 16:43 UTC (permalink / raw) To: Paul Elder; +Cc: buildroot, sakari.ailus, Eric Le Bihan Hi Paul, Thank you for the patch. On Wed, Sep 16, 2026 at 06:07:04PM +0900, Paul Elder wrote: > Add package for raw2rgbpnm. It is a tool for converting raw images to > RGB PNM. While the original repo is at: > https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git > A mirror is hosted on freedesktop: > https://gitlab.freedesktop.org/camera/raw2rgbpnm > so use that instead. > > As the build is simple and has no dependencies nor releases, use the > master branch for the version. I don't know what buildroot's policy is with this, but using the master branch will make builds non-reproducible. I would instead use the commit ID of the current master branch head. It can be updated in future buildroot releases. > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > This patch is based on 2026.08. > --- > package/Config.in | 1 + > package/raw2rgbpnm/Config.in | 6 ++++++ > package/raw2rgbpnm/raw2rgbpnm.mk | 16 ++++++++++++++++ > 3 files changed, 23 insertions(+) > create mode 100644 package/raw2rgbpnm/Config.in > create mode 100644 package/raw2rgbpnm/raw2rgbpnm.mk > > diff --git a/package/Config.in b/package/Config.in > index 6058800682b4..6d9daeadafec 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -195,6 +195,7 @@ menu "Development tools" > source "package/mawk/Config.in" > source "package/patch/Config.in" > source "package/pkgconf/Config.in" > + source "package/raw2rgbpnm/Config.in" > source "package/ripgrep/Config.in" > source "package/sed/Config.in" > source "package/subversion/Config.in" > diff --git a/package/raw2rgbpnm/Config.in b/package/raw2rgbpnm/Config.in > new file mode 100644 > index 000000000000..3d8f36459f4e > --- /dev/null > +++ b/package/raw2rgbpnm/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_RAW2RGBPNM > + bool "raw2rgbpnm" > + help > + Convert raw bayer images to RGB PNM for easier viewing > + > + https://gitlab.freedesktop.org/camera/raw2rgbpnm > diff --git a/package/raw2rgbpnm/raw2rgbpnm.mk b/package/raw2rgbpnm/raw2rgbpnm.mk > new file mode 100644 > index 000000000000..275fe6f32be3 > --- /dev/null > +++ b/package/raw2rgbpnm/raw2rgbpnm.mk > @@ -0,0 +1,16 @@ > +################################################################################ > +# > +# raw2rgbpnm > +# > +################################################################################ > + > +RAW2RGBPNM_SITE = https://gitlab.freedesktop.org/camera/raw2rgbpnm > +RAW2RGBPNM_SITE_METHOD = git > +RAW2RGBPNM_VERSION = master > + > +RAW2RGBPNM_LICENSE = GPL-2.0 > +RAW2RGBPNM_LICENSE_FILES = LICENSE > + > +RAW2RGBPNM_INSTALL_TARGET = YES > + > +$(eval $(meson-package)) -- Regards, Laurent Pinchart _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm 2026-09-16 16:43 ` [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm Laurent Pinchart @ 2026-09-16 18:34 ` Fiona Klute via buildroot 2026-09-16 19:48 ` Laurent Pinchart 0 siblings, 1 reply; 3+ messages in thread From: Fiona Klute via buildroot @ 2026-09-16 18:34 UTC (permalink / raw) To: Laurent Pinchart, Paul Elder; +Cc: buildroot, sakari.ailus, Eric Le Bihan Hi Paul, Laurent, everyone! Am 16.09.26 um 18:43 schrieb Laurent Pinchart: > On Wed, Sep 16, 2026 at 06:07:04PM +0900, Paul Elder wrote: >> Add package for raw2rgbpnm. It is a tool for converting raw images to >> RGB PNM. While the original repo is at: >> https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git >> A mirror is hosted on freedesktop: >> https://gitlab.freedesktop.org/camera/raw2rgbpnm >> so use that instead. Why use a mirror instead of the primary repository? >> As the build is simple and has no dependencies nor releases, use the >> master branch for the version. > > I don't know what buildroot's policy is with this, but using the master > branch will make builds non-reproducible. I would instead use the commit > ID of the current master branch head. It can be updated in future > buildroot releases. That is indeed against policy: "Note: Using a branch name as FOO_VERSION is not supported, because it does not and can not work as people would expect it should" [1]. The version must be fixed, if there are no releases using a commit hash is the right thing to do. Also, Buildroot policy is that a package must contain a hash file that gives hashes of relevant archives and license files, see section 18.4. "The .hash file" [2] in the manual. That is missing here, and would necessarily break with a branch HEAD. >> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> >> >> --- >> This patch is based on 2026.08. >> --- >> package/Config.in | 1 + >> package/raw2rgbpnm/Config.in | 6 ++++++ >> package/raw2rgbpnm/raw2rgbpnm.mk | 16 ++++++++++++++++ >> 3 files changed, 23 insertions(+) >> create mode 100644 package/raw2rgbpnm/Config.in >> create mode 100644 package/raw2rgbpnm/raw2rgbpnm.mk >> >> diff --git a/package/Config.in b/package/Config.in >> index 6058800682b4..6d9daeadafec 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -195,6 +195,7 @@ menu "Development tools" >> source "package/mawk/Config.in" >> source "package/patch/Config.in" >> source "package/pkgconf/Config.in" >> + source "package/raw2rgbpnm/Config.in" >> source "package/ripgrep/Config.in" >> source "package/sed/Config.in" >> source "package/subversion/Config.in" >> diff --git a/package/raw2rgbpnm/Config.in b/package/raw2rgbpnm/Config.in >> new file mode 100644 >> index 000000000000..3d8f36459f4e >> --- /dev/null >> +++ b/package/raw2rgbpnm/Config.in >> @@ -0,0 +1,6 @@ >> +config BR2_PACKAGE_RAW2RGBPNM >> + bool "raw2rgbpnm" >> + help >> + Convert raw bayer images to RGB PNM for easier viewing >> + >> + https://gitlab.freedesktop.org/camera/raw2rgbpnm >> diff --git a/package/raw2rgbpnm/raw2rgbpnm.mk b/package/raw2rgbpnm/raw2rgbpnm.mk >> new file mode 100644 >> index 000000000000..275fe6f32be3 >> --- /dev/null >> +++ b/package/raw2rgbpnm/raw2rgbpnm.mk >> @@ -0,0 +1,16 @@ >> +################################################################################ >> +# >> +# raw2rgbpnm >> +# >> +################################################################################ >> + >> +RAW2RGBPNM_SITE = https://gitlab.freedesktop.org/camera/raw2rgbpnm >> +RAW2RGBPNM_SITE_METHOD = git >> +RAW2RGBPNM_VERSION = master >> + >> +RAW2RGBPNM_LICENSE = GPL-2.0 SPDX has deprecated "GPL-2.0" because it's easily confused with the "or later" version, this should be "GPL-2.0-only" [3]. @Laurent, you appear to be the author of the raw2rgbpnm meson.build file. The license is listed as "GPL 2.0+" there, which is not an SPDX identifier (dash, not space) and does not match the C file headers, which indicate 2.0 *only*. >> +RAW2RGBPNM_LICENSE_FILES = LICENSE >> + >> +RAW2RGBPNM_INSTALL_TARGET = YES This is the default, so remove it. If you run "make check-package", it should warn you about that. @Paul: Also the initial patch didn't go over the mailing list, only Laurent's reply. Have you subscribed to the ML? Best regards, Fiona [1] https://nightly.buildroot.org/#generic-package-reference [2] https://nightly.buildroot.org/#adding-packages-hash [3] https://spdx.org/licenses/GPL-2.0.html [4] https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git;a=commitdiff;h=HEAD;hp=c23c8fa65fcfdfbb6c3ebd63d101fe9844e3c19f >> +$(eval $(meson-package)) > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm 2026-09-16 18:34 ` Fiona Klute via buildroot @ 2026-09-16 19:48 ` Laurent Pinchart 0 siblings, 0 replies; 3+ messages in thread From: Laurent Pinchart @ 2026-09-16 19:48 UTC (permalink / raw) To: Fiona Klute; +Cc: Paul Elder, buildroot, sakari.ailus, Eric Le Bihan Hello Fiona, Thank you for the quick reviews. On Wed, Sep 16, 2026 at 08:34:54PM +0200, Fiona Klute wrote: > Hi Paul, Laurent, everyone! > > Am 16.09.26 um 18:43 schrieb Laurent Pinchart: > > On Wed, Sep 16, 2026 at 06:07:04PM +0900, Paul Elder wrote: > >> Add package for raw2rgbpnm. It is a tool for converting raw images to > >> RGB PNM. While the original repo is at: > >> https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git > >> A mirror is hosted on freedesktop: > >> https://gitlab.freedesktop.org/camera/raw2rgbpnm > >> so use that instead. > > Why use a mirror instead of the primary repository? The primary repository is on a small self-hosted server that may have trouble coping with higher traffic. Sakari, could you tell what your preference is ? > >> As the build is simple and has no dependencies nor releases, use the > >> master branch for the version. > > > > I don't know what buildroot's policy is with this, but using the master > > branch will make builds non-reproducible. I would instead use the commit > > ID of the current master branch head. It can be updated in future > > buildroot releases. > > That is indeed against policy: "Note: Using a branch name as FOO_VERSION > is not supported, because it does not and can not work as people would > expect it should" [1]. The version must be fixed, if there are no > releases using a commit hash is the right thing to do. > > Also, Buildroot policy is that a package must contain a hash file that > gives hashes of relevant archives and license files, see section 18.4. > "The .hash file" [2] in the manual. That is missing here, and would > necessarily break with a branch HEAD. > > >> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > >> > >> --- > >> This patch is based on 2026.08. > >> --- > >> package/Config.in | 1 + > >> package/raw2rgbpnm/Config.in | 6 ++++++ > >> package/raw2rgbpnm/raw2rgbpnm.mk | 16 ++++++++++++++++ > >> 3 files changed, 23 insertions(+) > >> create mode 100644 package/raw2rgbpnm/Config.in > >> create mode 100644 package/raw2rgbpnm/raw2rgbpnm.mk > >> > >> diff --git a/package/Config.in b/package/Config.in > >> index 6058800682b4..6d9daeadafec 100644 > >> --- a/package/Config.in > >> +++ b/package/Config.in > >> @@ -195,6 +195,7 @@ menu "Development tools" > >> source "package/mawk/Config.in" > >> source "package/patch/Config.in" > >> source "package/pkgconf/Config.in" > >> + source "package/raw2rgbpnm/Config.in" > >> source "package/ripgrep/Config.in" > >> source "package/sed/Config.in" > >> source "package/subversion/Config.in" > >> diff --git a/package/raw2rgbpnm/Config.in b/package/raw2rgbpnm/Config.in > >> new file mode 100644 > >> index 000000000000..3d8f36459f4e > >> --- /dev/null > >> +++ b/package/raw2rgbpnm/Config.in > >> @@ -0,0 +1,6 @@ > >> +config BR2_PACKAGE_RAW2RGBPNM > >> + bool "raw2rgbpnm" > >> + help > >> + Convert raw bayer images to RGB PNM for easier viewing > >> + > >> + https://gitlab.freedesktop.org/camera/raw2rgbpnm > >> diff --git a/package/raw2rgbpnm/raw2rgbpnm.mk b/package/raw2rgbpnm/raw2rgbpnm.mk > >> new file mode 100644 > >> index 000000000000..275fe6f32be3 > >> --- /dev/null > >> +++ b/package/raw2rgbpnm/raw2rgbpnm.mk > >> @@ -0,0 +1,16 @@ > >> +################################################################################ > >> +# > >> +# raw2rgbpnm > >> +# > >> +################################################################################ > >> + > >> +RAW2RGBPNM_SITE = https://gitlab.freedesktop.org/camera/raw2rgbpnm > >> +RAW2RGBPNM_SITE_METHOD = git > >> +RAW2RGBPNM_VERSION = master > >> + > >> +RAW2RGBPNM_LICENSE = GPL-2.0 > > SPDX has deprecated "GPL-2.0" because it's easily confused with the "or > later" version, this should be "GPL-2.0-only" [3]. > > @Laurent, you appear to be the author of the raw2rgbpnm meson.build > file. The license is listed as "GPL 2.0+" there, which is not an SPDX > identifier (dash, not space) and does not match the C file headers, > which indicate 2.0 *only*. Good point. I'll send patches to fix that. Or I'll nicely ask Paul to do so :-) > >> +RAW2RGBPNM_LICENSE_FILES = LICENSE > >> + > >> +RAW2RGBPNM_INSTALL_TARGET = YES > > This is the default, so remove it. If you run "make check-package", it > should warn you about that. > > @Paul: Also the initial patch didn't go over the mailing list, only > Laurent's reply. Have you subscribed to the ML? > > Best regards, > Fiona > > > [1] https://nightly.buildroot.org/#generic-package-reference > [2] https://nightly.buildroot.org/#adding-packages-hash > [3] https://spdx.org/licenses/GPL-2.0.html > [4] https://git.retiisi.eu/?p=~sailus/raw2rgbpnm.git;a=commitdiff;h=HEAD;hp=c23c8fa65fcfdfbb6c3ebd63d101fe9844e3c19f > > >> +$(eval $(meson-package)) -- Regards, Laurent Pinchart _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-16 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260916090705.2796356-1-paul.elder@ideasonboard.com>
2026-09-16 16:43 ` [Buildroot] [PATCH] package/raw2rgbpnm: Add package for raw2rgbpnm Laurent Pinchart
2026-09-16 18:34 ` Fiona Klute via buildroot
2026-09-16 19:48 ` Laurent Pinchart
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.