Re: [PATCH V17 07/13] net/colo: track IOThread references using path-based holder

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Tue, Sep 15, 2026 at 06:16:49PM +0800, Zhang Chen wrote:
> @@ -1404,6 +1410,7 @@ static void colo_compare_finalize(Object *obj)
>  {
>      CompareState *s = COLO_COMPARE(obj);
>      CompareState *tmp;
> +    g_autofree char *path = object_get_canonical_path(OBJECT(s));

Did you test this? I think object_get_canonical_path() doesn't work here
because the object's ->parent link is already NULL:

  static void object_finalize_child_property(Object *obj, const char *name,
                                             void *opaque)
  {
      Object *child = opaque;
  
      if (child->class->unparent) {
          (child->class->unparent)(child);
      }
      child->parent = NULL;
      ^^^^^^^^^^^^^^^^^^^^^
      object_unref(child);
      ^^   we are here  ^^
  }

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]